RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Thank you for your feedback! > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback snip > > > > To further detail the problem, the system is vulnerable from before the > > last write > > performed by sii902x_i2c_bypass_select to after we conf

Re: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Peter Rosin
On 2018-11-01 18:32, Fabrizio Castro wrote: > Hello Peter, > > Thank you for your feedback! > >> Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback > > snip > >>> >>> To further detail the problem, the system is vulnerable

Re: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Peter Rosin
On 2018-11-01 17:04, Fabrizio Castro wrote: > Hello Peter, > > Thank you for your feedback! > >>> The "mux-locked" implementation was the one I first tried and I discovered >>> it doesn't work for me, as other traffic on the parent adapter can get in >>> the >>> way. What we need for this

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Thank you for your feedback! snip > > Yeah, there is some issue with locking here, and that's coming down > > from the fact that when we call into drm_get_edid, we implicitly call > > i2c_transfer which ultimately locks the i2c adapter, and then calls > > into our

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Again, thank you very much for your precious comments. I'll send a patch out shortly addressing all of the comments I have received so far, including yours. Cheers, Fab > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback > > On 2018-11-01 18:32, Fabrizio Cas

Re: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Peter Rosin
On 2018-11-01 12:04, Fabrizio Castro wrote: > Hello Peter, > > Thank you for your feedback! > > snip > >>> Yeah, there is some issue with locking here, and that's coming down >>> from the fact that when we call into drm_get_edid, we implicitly call >>> i2c_transfer which ultimately locks the

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Peter, Thank you for your feedback! > > The "mux-locked" implementation was the one I first tried and I discovered > > it doesn't work for me, as other traffic on the parent adapter can get in > > the > > way. What we need for this device is no other traffic on the bus during the > >

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-02 Thread Fabrizio Castro
Hello Mark, Thank you for your feedback! > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback > > On Wed, Oct 31, 2018 at 04:55:53PM +, Fabrizio Castro wrote: > > > Having the option of using "unlocked" flavours of reads and writes > > is what we need

Re: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-01 Thread Mark Brown
On Wed, Oct 31, 2018 at 04:55:53PM +, Fabrizio Castro wrote: > Having the option of using "unlocked" flavours of reads and writes > is what we need here, but looking at drivers/base/regmap/regmap-i2c.c > I couldn't find anything suitable for my case, maybe Mark could advise > on this one? I

RE: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-01 Thread Fabrizio Castro
Hello Linus, > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback > > Hi Fabrizio, > > thanks for your patch! Thank you for your feedback! > > On Wed, Oct 31, 2018 at 1:58 PM Fabrizio Castro > wrote: > > > While adding SiI9022A support to the iwg2

Re: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-11-01 Thread Peter Rosin
On 2018-10-31 17:55, Fabrizio Castro wrote: > Hello Linus, > >> Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback >> >> Hi Fabrizio, >> >> thanks for your patch! > > Thank you for your feedback! > >> >> On Wed, Oct 31, 2018

Re: [RFC] drm/bridge/sii902x: Fix EDID readback

2018-10-31 Thread Linus Walleij
Hi Fabrizio, thanks for your patch! On Wed, Oct 31, 2018 at 1:58 PM Fabrizio Castro wrote: > While adding SiI9022A support to the iwg23s board it came up > that when the HDMI transmitter is in pass through mode the > device is not compliant with the I2C specification anymore, > as it requires