Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob

2017-05-23 Thread Daniel Stone
Hi Ben, On 16 May 2017 at 22:31, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) If you take the attached fixup, this is: Reviewed-by: Daniel Stone The rest of the series looks fine to me, so you can take my Acked-by, but I'm

Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob

2017-05-18 Thread Emil Velikov
On 18 May 2017 at 01:46, Ben Widawsky wrote: >>> + blob_size += modifiers_size; >>> + >>> + blob = drm_property_create_blob(dev, blob_size, NULL); >>> + if (IS_ERR(blob)) >>> + return -1; >>> + >> >> Maybe propagate the exact error... Hmm we

Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob

2017-05-18 Thread Ville Syrjälä
On Wed, May 17, 2017 at 05:46:18PM -0700, Ben Widawsky wrote: > On 17-05-17 01:06:16, Emil Velikov wrote: > >Hi Ben, > > > >On 16 May 2017 at 22:31, Ben Widawsky wrote: > >> Updated blob layout (Rob, Daniel, Kristian, xerpi) > >> > >> v2: > >> * Removed __packed, and alignment

Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob

2017-05-17 Thread Ben Widawsky
On 17-05-17 01:06:16, Emil Velikov wrote: Hi Ben, On 16 May 2017 at 22:31, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) v2: * Removed __packed, and alignment (.+) * Fix indent in drm_format_modifier fields (Liviu) * Remove duplicated modifier > 64

Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob

2017-05-16 Thread Emil Velikov
Hi Ben, On 16 May 2017 at 22:31, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) > > v2: > * Removed __packed, and alignment (.+) > * Fix indent in drm_format_modifier fields (Liviu) > * Remove duplicated modifier > 64 check (Liviu) > * Change comment