Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-11 Thread Christian König
Am 11.03.21 um 14:17 schrieb Daniel Vetter: [SNIP] So I did the following quick experiment on vmwgfx, and it turns out that with it, fast gup never succeeds. Without the "| PFN_MAP", it typically succeeds I should probably craft an RFC formalizing this. Yeah I think that would be good.

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-11 Thread Intel
On 3/11/21 2:17 PM, Daniel Vetter wrote: On Thu, Mar 11, 2021 at 2:12 PM Thomas Hellström (Intel) wrote: Hi! On 3/11/21 2:00 PM, Daniel Vetter wrote: On Thu, Mar 11, 2021 at 11:22:06AM +0100, Thomas Hellström (Intel) wrote: On 3/1/21 3:09 PM, Daniel Vetter wrote: On Mon, Mar 1, 2021 at

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-11 Thread Daniel Vetter
On Thu, Mar 11, 2021 at 2:12 PM Thomas Hellström (Intel) wrote: > > Hi! > > On 3/11/21 2:00 PM, Daniel Vetter wrote: > > On Thu, Mar 11, 2021 at 11:22:06AM +0100, Thomas Hellström (Intel) wrote: > >> On 3/1/21 3:09 PM, Daniel Vetter wrote: > >>> On Mon, Mar 1, 2021 at 11:17 AM Christian König >

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-11 Thread Intel
Hi! On 3/11/21 2:00 PM, Daniel Vetter wrote: On Thu, Mar 11, 2021 at 11:22:06AM +0100, Thomas Hellström (Intel) wrote: On 3/1/21 3:09 PM, Daniel Vetter wrote: On Mon, Mar 1, 2021 at 11:17 AM Christian König wrote: Am 01.03.21 um 10:21 schrieb Thomas Hellström (Intel): On 3/1/21 10:05 AM,

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-11 Thread Daniel Vetter
On Thu, Mar 11, 2021 at 11:22:06AM +0100, Thomas Hellström (Intel) wrote: > > On 3/1/21 3:09 PM, Daniel Vetter wrote: > > On Mon, Mar 1, 2021 at 11:17 AM Christian König > > wrote: > > > > > > > > > Am 01.03.21 um 10:21 schrieb Thomas Hellström (Intel): > > > > On 3/1/21 10:05 AM, Daniel

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-11 Thread Intel
On 3/1/21 3:09 PM, Daniel Vetter wrote: On Mon, Mar 1, 2021 at 11:17 AM Christian König wrote: Am 01.03.21 um 10:21 schrieb Thomas Hellström (Intel): On 3/1/21 10:05 AM, Daniel Vetter wrote: On Mon, Mar 01, 2021 at 09:39:53AM +0100, Thomas Hellström (Intel) wrote: Hi, On 3/1/21 9:28 AM,

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-01 Thread Daniel Vetter
On Mon, Mar 1, 2021 at 11:17 AM Christian König wrote: > > > > Am 01.03.21 um 10:21 schrieb Thomas Hellström (Intel): > > > > On 3/1/21 10:05 AM, Daniel Vetter wrote: > >> On Mon, Mar 01, 2021 at 09:39:53AM +0100, Thomas Hellström (Intel) > >> wrote: > >>> Hi, > >>> > >>> On 3/1/21 9:28 AM,

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-01 Thread Christian König
Am 01.03.21 um 10:21 schrieb Thomas Hellström (Intel): On 3/1/21 10:05 AM, Daniel Vetter wrote: On Mon, Mar 01, 2021 at 09:39:53AM +0100, Thomas Hellström (Intel) wrote: Hi, On 3/1/21 9:28 AM, Daniel Vetter wrote: On Sat, Feb 27, 2021 at 9:06 AM Thomas Hellström (Intel) wrote: On

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-01 Thread Intel
On 3/1/21 10:05 AM, Daniel Vetter wrote: On Mon, Mar 01, 2021 at 09:39:53AM +0100, Thomas Hellström (Intel) wrote: Hi, On 3/1/21 9:28 AM, Daniel Vetter wrote: On Sat, Feb 27, 2021 at 9:06 AM Thomas Hellström (Intel) wrote: On 2/26/21 2:28 PM, Daniel Vetter wrote: So I think it stops gup.

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-01 Thread Daniel Vetter
On Mon, Mar 01, 2021 at 09:39:53AM +0100, Thomas Hellström (Intel) wrote: > Hi, > > On 3/1/21 9:28 AM, Daniel Vetter wrote: > > On Sat, Feb 27, 2021 at 9:06 AM Thomas Hellström (Intel) > > wrote: > > > On 2/26/21 2:28 PM, Daniel Vetter wrote: > > > > So I think it stops gup. But I haven't

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-01 Thread Intel
Hi, On 3/1/21 9:28 AM, Daniel Vetter wrote: On Sat, Feb 27, 2021 at 9:06 AM Thomas Hellström (Intel) wrote: On 2/26/21 2:28 PM, Daniel Vetter wrote: So I think it stops gup. But I haven't verified at all. Would be good if Christian can check this with some direct io to a buffer in system

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-03-01 Thread Daniel Vetter
On Sat, Feb 27, 2021 at 9:06 AM Thomas Hellström (Intel) wrote: > On 2/26/21 2:28 PM, Daniel Vetter wrote: > > So I think it stops gup. But I haven't verified at all. Would be good > > if Christian can check this with some direct io to a buffer in system > > memory. > > Hmm, > > Docs (again

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-27 Thread Intel
On 2/26/21 2:28 PM, Daniel Vetter wrote: On Fri, Feb 26, 2021 at 10:41 AM Thomas Hellström (Intel) wrote: On 2/25/21 4:49 PM, Daniel Vetter wrote: On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: Am 24.02.21 um 10:31

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-26 Thread Daniel Vetter
On Fri, Feb 26, 2021 at 10:41 AM Thomas Hellström (Intel) wrote: > > > On 2/25/21 4:49 PM, Daniel Vetter wrote: > > On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: > >> On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: > >>> Am 24.02.21 um 10:31 schrieb Daniel Vetter: >

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-26 Thread Intel
On 2/25/21 4:49 PM, Daniel Vetter wrote: On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: Am 24.02.21 um 10:31 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: On 2/24/21 9:45 AM,

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 25.02.21 um 16:49 schrieb Daniel Vetter: On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: Am 24.02.21 um 10:31 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: On 2/24/21 9:45

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: > > On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: > > Am 24.02.21 um 10:31 schrieb Daniel Vetter: > > > On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) > > > wrote: > > > > > > > > On 2/24/21 9:45 AM, Daniel

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:30:23AM +0100, Christian König wrote: > > > Am 24.02.21 um 19:46 schrieb Jason Gunthorpe: > > On Wed, Feb 24, 2021 at 09:45:51AM +0100, Daniel Vetter wrote: > > > > > Hm I figured everyone just uses MAP_SHARED for buffer objects since > > > COW really makes absolutely

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: > Am 24.02.21 um 10:31 schrieb Daniel Vetter: > > On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) > > wrote: > > > > > > On 2/24/21 9:45 AM, Daniel Vetter wrote: > > > > On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 24.02.21 um 19:46 schrieb Jason Gunthorpe: On Wed, Feb 24, 2021 at 09:45:51AM +0100, Daniel Vetter wrote: Hm I figured everyone just uses MAP_SHARED for buffer objects since COW really makes absolutely no sense. How would we enforce this? In RDMA we test

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 24.02.21 um 10:31 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: On 2/24/21 9:45 AM, Daniel Vetter wrote: On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) wrote: On 2/23/21 11:59 AM, Daniel Vetter wrote: tldr; DMA buffers aren't normal

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-24 Thread Jason Gunthorpe
On Wed, Feb 24, 2021 at 09:45:51AM +0100, Daniel Vetter wrote: > Hm I figured everyone just uses MAP_SHARED for buffer objects since > COW really makes absolutely no sense. How would we enforce this? In RDMA we test drivers/infiniband/core/ib_core_uverbs.c: if (!(vma->vm_flags &

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-24 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: > > > On 2/24/21 9:45 AM, Daniel Vetter wrote: > > On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) > > wrote: > >> > >> On 2/23/21 11:59 AM, Daniel Vetter wrote: > >>> tldr; DMA buffers aren't normal memory, expecting that

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-24 Thread Intel
On 2/24/21 9:45 AM, Daniel Vetter wrote: On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) wrote: On 2/23/21 11:59 AM, Daniel Vetter wrote: tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-24 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) wrote: > > > On 2/23/21 11:59 AM, Daniel Vetter wrote: > > tldr; DMA buffers aren't normal memory, expecting that you can use > > them like that (like calling get_user_pages works, or that they're > > accounting like any other normal

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-23 Thread Intel
On 2/23/21 11:59 AM, Daniel Vetter wrote: tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices,