RE: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

2024-03-18 Thread FLAVIO SULIGOI
Hi Dan, > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't cause an > issue at runtime because devm_kcalloc() won't allocate negative sizes. > However, it's still worth fixing. > > Fixes: b54c828bdba9 ("backlight: mp

Re: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

2024-03-18 Thread Daniel Thompson
On Sat, Mar 16, 2024 at 12:45:27PM +0300, Dan Carpenter wrote: > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't > cause an issue at runtime because devm_kcalloc() won't allocate negative > sizes. However, it's still

Re: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

2024-03-18 Thread Andy Shevchenko
On Sat, Mar 16, 2024 at 12:45:27PM +0300, Dan Carpenter wrote: > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't > cause an issue at runtime because devm_kcalloc() won't allocate negative > sizes. However, it's still