Re: [PATCH] drm/imx/lcdc: fix a NULL vs IS_ERR() bug in probe

2023-05-03 Thread Dan Carpenter
On Sat, Apr 15, 2023 at 11:51:28PM +0200, Javier Martinez Canillas wrote: > Uwe Kleine-König writes: > > > On Wed, Mar 22, 2023 at 12:06:55PM +0300, Dan Carpenter wrote: > >> The devm_drm_dev_alloc() function returns error pointers. It never > >> returns NULL. Fix the check. > >> > >> Fixes: c

Re: [PATCH] drm/imx/lcdc: fix a NULL vs IS_ERR() bug in probe

2023-04-15 Thread Javier Martinez Canillas
Uwe Kleine-König writes: > On Wed, Mar 22, 2023 at 12:06:55PM +0300, Dan Carpenter wrote: >> The devm_drm_dev_alloc() function returns error pointers. It never >> returns NULL. Fix the check. >> >> Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25") >> Signed-off-by: Dan Carpe

Re: [PATCH] drm/imx/lcdc: fix a NULL vs IS_ERR() bug in probe

2023-03-22 Thread Uwe Kleine-König
On Wed, Mar 22, 2023 at 12:06:55PM +0300, Dan Carpenter wrote: > The devm_drm_dev_alloc() function returns error pointers. It never > returns NULL. Fix the check. > > Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25") > Signed-off-by: Dan Carpenter Reviewed-by: Uwe Kleine-Kön