Re: [PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-22 Thread Neil Armstrong
Hi, On Mon, 06 Mar 2023 11:35:33 +0100, Johan Hovold wrote: > Make sure to unbind all subcomponents when binding the aggregate device > fails. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/1] drm/meson: fix missing component unbind on bind

Re: [PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-21 Thread Johan Hovold
On Tue, Mar 21, 2023 at 02:27:08PM +0100, Neil Armstrong wrote: > Anyway for this patch, sorry for the delay, but it's looks fine: > > Acked-by: Neil Armstrong Thanks for reviewing! Johan

Re: [PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-21 Thread Neil Armstrong
On 21/03/2023 14:14, Johan Hovold wrote: On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote: On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold wrote: [...] @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) ret =

Re: [PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-21 Thread Johan Hovold
On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote: > On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold wrote: > [...] > > @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, > > bool has_components) > > > > ret = meson_encoder_hdmi_init(priv); > I'm

Re: [PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-09 Thread Martin Blumenstingl
Hi Johan, thanks for your patch! On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold wrote: [...] > @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, > bool has_components) > > ret = meson_encoder_hdmi_init(priv); I'm wondering if component_bind_all() can be moved