Re: [PATCH] drm/msm/a6xx: Fix speed-bin detection vs probe-defer

2022-11-14 Thread Rob Clark
On Mon, Nov 14, 2022 at 11:59 AM Akhil P Oommen wrote: > > On 11/15/2022 1:11 AM, Rob Clark wrote: > > From: Rob Clark > > > > If we get an error (other than -ENOENT) we need to propagate that up the > > stack. Otherwise if the nvmem driver hasn't probed yet, we'll end up with > > whatever

Re: [PATCH] drm/msm/a6xx: Fix speed-bin detection vs probe-defer

2022-11-14 Thread Rob Clark
On Mon, Nov 14, 2022 at 12:27 PM Doug Anderson wrote: > > Hi, > > On Mon, Nov 14, 2022 at 11:41 AM Rob Clark wrote: > > > > From: Rob Clark > > > > If we get an error (other than -ENOENT) we need to propagate that up the > > stack. Otherwise if the nvmem driver hasn't probed yet, we'll end up

Re: [PATCH] drm/msm/a6xx: Fix speed-bin detection vs probe-defer

2022-11-14 Thread Akhil P Oommen
On 11/15/2022 1:57 AM, Doug Anderson wrote: Hi, On Mon, Nov 14, 2022 at 11:41 AM Rob Clark wrote: From: Rob Clark If we get an error (other than -ENOENT) we need to propagate that up the stack. Otherwise if the nvmem driver hasn't probed yet, we'll end up with whatever OPP(s) are

Re: [PATCH] drm/msm/a6xx: Fix speed-bin detection vs probe-defer

2022-11-14 Thread Doug Anderson
Hi, On Mon, Nov 14, 2022 at 11:41 AM Rob Clark wrote: > > From: Rob Clark > > If we get an error (other than -ENOENT) we need to propagate that up the > stack. Otherwise if the nvmem driver hasn't probed yet, we'll end up with > whatever OPP(s) are represented by bit zero. Can you explain the

Re: [PATCH] drm/msm/a6xx: Fix speed-bin detection vs probe-defer

2022-11-14 Thread Akhil P Oommen
On 11/15/2022 1:11 AM, Rob Clark wrote: From: Rob Clark If we get an error (other than -ENOENT) we need to propagate that up the stack. Otherwise if the nvmem driver hasn't probed yet, we'll end up with whatever OPP(s) are represented by bit zero. Fixed: fe7952c629da ("drm/msm: Add speed-bin