Re: [PATCH] drm/of: free the iterator object on failure

2021-07-14 Thread Laurent Pinchart
Hi Steven, On Tue, Jul 13, 2021 at 05:16:16PM +0100, Steven Price wrote: > On 12/07/2021 22:55, Laurent Pinchart wrote: > > On Mon, Jul 12, 2021 at 10:31:52PM +0100, Steven Price wrote: > >> On 12/07/2021 17:50, Laurent Pinchart wrote: > >>> On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price w

Re: [PATCH] drm/of: free the iterator object on failure

2021-07-13 Thread Steven Price
On 12/07/2021 22:55, Laurent Pinchart wrote: > Hi Steven, Hi Laurent, > On Mon, Jul 12, 2021 at 10:31:52PM +0100, Steven Price wrote: >> On 12/07/2021 17:50, Laurent Pinchart wrote: >>> On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote: When bailing out due to the sanity check the

RE: [PATCH] drm/of: free the iterator object on failure

2021-07-13 Thread Biju Das
+ Pavel > -Original Message- > From: Steven Price > Sent: 12 July 2021 16:58 > To: Daniel Vetter ; David Airlie ; > Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann > Cc: Steven Price ; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org; Biju Das ; > Laurent Pinchart

Re: [PATCH] drm/of: free the iterator object on failure

2021-07-12 Thread Laurent Pinchart
Hi Steven, On Mon, Jul 12, 2021 at 10:31:52PM +0100, Steven Price wrote: > On 12/07/2021 17:50, Laurent Pinchart wrote: > > On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote: > >> When bailing out due to the sanity check the iterator value needs to be > >> freed because the early return

Re: [PATCH] drm/of: free the iterator object on failure

2021-07-12 Thread Steven Price
On 12/07/2021 17:50, Laurent Pinchart wrote: > Hi Steven, > > Thank you for the patch. > > On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote: >> When bailing out due to the sanity check the iterator value needs to be >> freed because the early return prevents for_each_child_of_node() f

Re: [PATCH] drm/of: free the iterator object on failure

2021-07-12 Thread Laurent Pinchart
Hi Steven, Thank you for the patch. On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote: > When bailing out due to the sanity check the iterator value needs to be > freed because the early return prevents for_each_child_of_node() from > doing the dereference itself. > > Fixes: 4ee48cc55