Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-04-09 Thread Gerd Hoffmann
Hi, > > Should we add something like DRM_PRIME_CAP_SAME_DEVICE? > > Yeah I expect we need some sort of same device only capability, so > that dri3 userspace can work. > > If we just fail importing in these cases what happens? userspace just > gets confused, I know we used to print a backtrace

Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-04-09 Thread David Airlie
On Tue, Apr 9, 2019 at 4:03 PM Gerd Hoffmann wrote: > > On Tue, Apr 09, 2019 at 02:01:33PM +1000, Dave Airlie wrote: > > On Sat, 12 Jan 2019 at 07:13, Dave Airlie wrote: > > > > > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann wrote: > > > > > > > > Also set prime_handle_to_fd and

Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-04-09 Thread Gerd Hoffmann
On Tue, Apr 09, 2019 at 02:01:33PM +1000, Dave Airlie wrote: > On Sat, 12 Jan 2019 at 07:13, Dave Airlie wrote: > > > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann wrote: > > > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > > so drm will not advertive

Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-04-08 Thread Dave Airlie
On Sat, 12 Jan 2019 at 07:13, Dave Airlie wrote: > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann wrote: > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > > userspace. It's been pointed out to me that disables

Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-01-11 Thread Dave Airlie
On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann wrote: > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > userspace. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Dave Airlie > --- > drivers/gpu/drm/qxl/qxl_drv.c | 4