Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Das, Nirmoy
On 6/8/2021 11:42 AM, Christian König wrote: Am 08.06.21 um 11:40 schrieb Das, Nirmoy: On 6/8/2021 11:38 AM, Das, Nirmoy wrote: On 6/8/2021 9:21 AM, Christian König wrote: Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel): [SNIP] Do you have the log to double check?

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Christian König
Am 08.06.21 um 11:40 schrieb Das, Nirmoy: On 6/8/2021 11:38 AM, Das, Nirmoy wrote: On 6/8/2021 9:21 AM, Christian König wrote: Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel): [SNIP] Do you have the log to double check? Unfortunately not, but IIRC it was directly from

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Das, Nirmoy
On 6/8/2021 11:38 AM, Das, Nirmoy wrote: On 6/8/2021 9:21 AM, Christian König wrote: Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel): [SNIP] Do you have the log to double check? Unfortunately not, but IIRC it was directly from vmw_move(). Nirmoy do you still have your vmwgfx

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Das, Nirmoy
On 6/8/2021 9:21 AM, Christian König wrote: Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel): [SNIP] Do you have the log to double check? Unfortunately not, but IIRC it was directly from vmw_move(). Nirmoy do you still have your vmwgfx test environment? Yes! Thanks,

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Christian König
Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel): [SNIP] Do you have the log to double check? Unfortunately not, but IIRC it was directly from vmw_move(). Nirmoy do you still have your vmwgfx test environment? Thanks, Christian. /Thomas

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Intel
Hi, On 6/8/21 9:14 AM, Christian König wrote: Am 08.06.21 um 07:29 schrieb Thomas Hellström (Intel): Hi, On 6/7/21 7:59 PM, Christian König wrote: Am 07.06.21 um 19:58 schrieb Thomas Hellström (Intel): On 6/7/21 7:54 PM, Christian König wrote: Am 07.06.21 um 19:06 schrieb Thomas

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Christian König
Am 08.06.21 um 07:29 schrieb Thomas Hellström (Intel): Hi, On 6/7/21 7:59 PM, Christian König wrote: Am 07.06.21 um 19:58 schrieb Thomas Hellström (Intel): On 6/7/21 7:54 PM, Christian König wrote: Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-08 Thread Thomas Hellström
Hi, On 6/2/21 12:09 PM, Christian König wrote: To improve the handling we want the establish the resource object as base class for the backend allocations. v2: add missing error handling Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +-

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Intel
Hi, On 6/7/21 7:59 PM, Christian König wrote: Am 07.06.21 um 19:58 schrieb Thomas Hellström (Intel): On 6/7/21 7:54 PM, Christian König wrote: Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Christian König
Am 07.06.21 um 19:58 schrieb Thomas Hellström (Intel): On 6/7/21 7:54 PM, Christian König wrote: Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Intel
On 6/7/21 7:54 PM, Christian König wrote: Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */  

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Christian König
Am 07.06.21 um 19:06 schrieb Thomas Hellström (Intel): On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */   static int ttm_bo_mem_force_space(struct

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Christian König
Am 07.06.21 um 18:40 schrieb Thomas Hellström (Intel): On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */   static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,     const

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Intel
On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,    */   static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,     const struct

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Intel
On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, */ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, const struct ttm_place *place, -

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-04 Thread Christian König
Am 03.06.21 um 10:45 schrieb Matthew Auld: On 02/06/2021 11:09, Christian König wrote: [SNIP] -/** - * ttm_bo_mem_placement - check if placement is compatible - * @bo: BO to find memory for - * @place: where to search - * @mem: the memory object to fill in - * - * Check if placement is

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-04 Thread Intel
Hi, Christian, It looks like all patches in the series have been reviewed or acked by Matthew, and while still a little worried about the final outcome of embedding a struct ttm_mem_resource, FWIW, Acked-by: Thomas Hellström /Thomas On 6/2/21 12:09 PM, Christian König wrote: To improve

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-03 Thread Matthew Auld
On 02/06/2021 11:09, Christian König wrote: To improve the handling we want the establish the resource object as base class for the backend allocations. v2: add missing error handling Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +-