Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hi Thomas, Thanks a lot for your review. On Tue, Jun 07, 2022 at 09:22:38AM +0200, Thomas Zimmermann wrote: > Hi, > > ading Kunit tests for the conversion helpers is pretty cool. Thanks for > doing that. > > Am 06.06.22 um 11:55 schrieb José Expósito: > > Test the conversion from XRGB to

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hi, ading Kunit tests for the conversion helpers is pretty cool. Thanks for doing that. Am 06.06.22 um 11:55 schrieb José Expósito: Test the conversion from XRGB to RGB332. What is tested? - Different values for the X in XRGB to make sure it is ignored - Different clip values:

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hi! Javier Martinez Canillas wrote: > Hello José, > > On 6/6/22 11:55, José Expósito wrote: > > Test the conversion from XRGB to RGB332. > > > > What is tested? > > > > - Different values for the X in XRGB to make sure it is ignored > > - Different clip values: Single pixel and full

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hello Daniel, On 6/6/22 16:19, Daniel Latypov wrote: [snip] >> That's what I asked in the previous RFC too. Daniel mentioned that it >> shouldn't >> go there because is platform specific (AFAIU, one might want to test it on >> x86, > > Slight correction, it was David who explicitly suggested

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

On Mon, Jun 06, 2022 at 03:57:45PM +0200, Javier Martinez Canillas wrote: > Hello Maxime, > > On 6/6/22 15:52, Maxime Ripard wrote: > > hi, > > > > On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote: > >> Hello Maxime, > >> > >> On 6/6/22 15:42, Maxime Ripard wrote: > >>>

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hello Maxime, On 6/6/22 15:52, Maxime Ripard wrote: > hi, > > On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote: >> Hello Maxime, >> >> On 6/6/22 15:42, Maxime Ripard wrote: >>> Hi, >>> >>> On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: Test the

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

hi, On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote: > Hello Maxime, > > On 6/6/22 15:42, Maxime Ripard wrote: > > Hi, > > > > On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: > >> Test the conversion from XRGB to RGB332. > >> > >> What is tested? > >>

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hello Maxime, On 6/6/22 15:42, Maxime Ripard wrote: > Hi, > > On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: >> Test the conversion from XRGB to RGB332. >> >> What is tested? >> >> - Different values for the X in XRGB to make sure it is ignored >> - Different clip

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hi, On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote: > Test the conversion from XRGB to RGB332. > > What is tested? > > - Different values for the X in XRGB to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well known

Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

Hello José, On 6/6/22 11:55, José Expósito wrote: > Test the conversion from XRGB to RGB332. > > What is tested? > > - Different values for the X in XRGB to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well known colors: White,