On Wed, Aug 12, 2020 at 9:34 AM Sam Ravnborg wrote:
> Hmm, I think I looked at leds/ when I wrote that comment about
> common.yaml.
>
> Please consider Rob's comment in commit:
> 44e1655a444fe7a1bd81994d34c6bbb5245b9e60
> ("dt-bindings: backlight: Convert common backlight bindings to DT
>
Hi Linus.
On Wed, Aug 12, 2020 at 08:48:42AM +0200, Linus Walleij wrote:
> On Tue, Jul 21, 2020 at 10:32 AM Sam Ravnborg wrote:
>
> > > +description: |
> > > + The Kinetic Technologies KTD253 is a white LED backlight that is
> > > + controlled by a single GPIO line. If you just turn on the
On Tue, Jul 21, 2020 at 1:28 PM Daniel Thompson
wrote:
> I'm a bit sceptical of having a max-brightness in the DT and a driver
> defined lookup table in the driver itself. That doesn't make a whole lot
> of sense to me since the maximum brightness here is basically relies on
> knowing what scale
On Tue, Jul 21, 2020 at 10:32 AM Sam Ravnborg wrote:
> > +description: |
> > + The Kinetic Technologies KTD253 is a white LED backlight that is
> > + controlled by a single GPIO line. If you just turn on the backlight
> > + it goes to maximum backlight then you can set the level of backlight
On Mon, Jul 20, 2020 at 10:35:05PM +0200, Linus Walleij wrote:
> This adds device tree bindings for the Kinetic KTD253
> white LED backlight driver.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Linus Walleij
> ---
> .../leds/backlight/kinetic,ktd253.yaml| 48 +++
>
Hi Linus.
On Mon, Jul 20, 2020 at 10:35:05PM +0200, Linus Walleij wrote:
> This adds device tree bindings for the Kinetic KTD253
> white LED backlight driver.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Linus Walleij
See a few comments in the following.
Sam
> ---
>
