Re: [PATCH 1/7] drm/mediatek: fix atomic_state reference counting

2019-11-27 Thread Bibby Hsieh
On Wed, 2019-11-27 at 17:56 +0800, Daniel Vetter wrote: > On Wed, Nov 27, 2019 at 09:41:52AM +0800, Bibby Hsieh wrote: > > On Tue, 2019-11-26 at 09:49 +0100, Daniel Vetter wrote: > > > On Tue, Nov 26, 2019 at 02:29:26PM +0800, Bibby Hsieh wrote: > > > > The DRM core takes care of all atomic state

Re: [PATCH 1/7] drm/mediatek: fix atomic_state reference counting

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 09:41:52AM +0800, Bibby Hsieh wrote: > On Tue, 2019-11-26 at 09:49 +0100, Daniel Vetter wrote: > > On Tue, Nov 26, 2019 at 02:29:26PM +0800, Bibby Hsieh wrote: > > > The DRM core takes care of all atomic state refcounting. > > > However, mediatek drm defers some work that

Re: [PATCH 1/7] drm/mediatek: fix atomic_state reference counting

2019-11-26 Thread Bibby Hsieh
On Tue, 2019-11-26 at 09:49 +0100, Daniel Vetter wrote: > On Tue, Nov 26, 2019 at 02:29:26PM +0800, Bibby Hsieh wrote: > > The DRM core takes care of all atomic state refcounting. > > However, mediatek drm defers some work that accesses planes > > and plane_states in drm_atomic_state, and must

Re: [PATCH 1/7] drm/mediatek: fix atomic_state reference counting

2019-11-26 Thread Daniel Vetter
On Tue, Nov 26, 2019 at 02:29:26PM +0800, Bibby Hsieh wrote: > The DRM core takes care of all atomic state refcounting. > However, mediatek drm defers some work that accesses planes > and plane_states in drm_atomic_state, and must therefore > keep its own atomic state references until this work