Re: [PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-21 Thread Shawn Guo
On Thu, Jun 14, 2012 at 03:43:24PM +0200, Sascha Hauer wrote: +static const struct of_device_id imx_pd_dt_ids[] = { + { .compatible = fsl,imx-parallel-display, .data = NULL, }, Can we use particular soc name to define the compatible string? Also, the .data initialization seems not needed.

Re: [PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-21 Thread Shawn Guo
On Thu, Jun 21, 2012 at 01:35:56PM +0800, Shawn Guo wrote: On Thu, Jun 14, 2012 at 03:43:24PM +0200, Sascha Hauer wrote: +static const struct of_device_id imx_pd_dt_ids[] = { + { .compatible = fsl,imx-parallel-display, .data = NULL, }, Can we use particular soc name to define the

Re: [PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-21 Thread Sascha Hauer
On Thu, Jun 21, 2012 at 02:07:32PM +0800, Shawn Guo wrote: On Thu, Jun 21, 2012 at 01:35:56PM +0800, Shawn Guo wrote: On Thu, Jun 14, 2012 at 03:43:24PM +0200, Sascha Hauer wrote: +static const struct of_device_id imx_pd_dt_ids[] = { + { .compatible = fsl,imx-parallel-display, .data =

Re: [PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-21 Thread Shawn Guo
On Thu, Jun 14, 2012 at 03:43:24PM +0200, Sascha Hauer wrote: +static int __devinit imx_pd_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev-dev.of_node; + const u8 *edidp; + struct imx_parallel_display *imxpd; + int ret; + u32 crtcs[2]; It seems