Re: [PATCH 21/60] drm/panel: Add driver for the Sharp LS037V7DW01 panel

2019-08-08 Thread Laurent Pinchart
Hi Sam, On Mon, Jul 08, 2019 at 09:44:52PM +0200, Sam Ravnborg wrote: > Hi Laurent. > > Third panel driver in line for review. > Review comments that are duplicates from the first two will have only a > brief remark - if any. I'll address them the same way. Please consider all unanswered

Re: [PATCH 21/60] drm/panel: Add driver for the Sharp LS037V7DW01 panel

2019-07-08 Thread Sam Ravnborg
Hi Laurent. > > + > > +MODULE_DEVICE_TABLE(of, ls037v7dw01_of_match); > > + > > +static struct platform_driver ls037v7dw01_driver = { > > + .probe = ls037v7dw01_probe, > > + .remove = __exit_p(ls037v7dw01_remove), I hope _exit_p() is not needed. No other panel drivers use it

Re: [PATCH 21/60] drm/panel: Add driver for the Sharp LS037V7DW01 panel

2019-07-08 Thread Sam Ravnborg
Hi Laurent. Third panel driver in line for review. Review comments that are duplicates from the first two will have only a brief remark - if any. On Sun, Jul 07, 2019 at 09:18:58PM +0300, Laurent Pinchart wrote: > This panel is used on the SDP3430. Add a little more context and put it in Kconfig