Hi Laurent,
thanks for the review! Most of it seemed clear how to fix for the rest
i've put some questions below:
On Sat, Jul 27, 2019 at 05:47:00AM +0300, Laurent Pinchart wrote:
> Hello Guido,
>
> Thank you for the patch.
>
> On Wed, Jul 24, 2019 at 05:52:26PM +0200, Guido Günther wrote:
> >
On Wed, Jul 31, 2019 at 1:40 PM Jernej Škrabec wrote:
> > Yes, I understood the idea, but this would print:
> >
> > ensabling or dissabling :-)
>
> No, it wouldn't. That extra "s" is part of "%s", e.g. part of format
> specifier.
Ops, you are right. Sorry about that!
Hi,
On Wed, Jul 31, 2019 at 11:43:47AM -0300, Fabio Estevam wrote:
> Hi Guido,
>
> On Wed, Jul 31, 2019 at 11:35 AM Guido Günther wrote:
>
> > The idea is to have
> >
> > "%sabling platform clocks", enable ? "en" : "dis");
> >
> > depending whether clocks are enabled/disabled.
>
> Yes, I
Hi!
Dne sreda, 31. julij 2019 ob 16:43:47 CEST je Fabio Estevam napisal(a):
> Hi Guido,
>
> On Wed, Jul 31, 2019 at 11:35 AM Guido Günther wrote:
> > The idea is to have
> >
> > "%sabling platform clocks", enable ? "en" : "dis");
> >
> > depending whether clocks are enabled/disabled.
>
>
Hi Guido,
On Wed, Jul 31, 2019 at 11:35 AM Guido Günther wrote:
> The idea is to have
>
> "%sabling platform clocks", enable ? "en" : "dis");
>
> depending whether clocks are enabled/disabled.
Yes, I understood the idea, but this would print:
ensabling or dissabling :-)
> > Same here.
Hi,
On Sat, Jul 27, 2019 at 05:04:44AM +0300, Laurent Pinchart wrote:
> Hello,
>
> On Fri, Jul 26, 2019 at 05:01:52PM -0300, Fabio Estevam wrote:
> > Hi Guido,
> >
> > Thanks for your work on this driver!
> >
> > On Wed, Jul 24, 2019 at 12:52 PM Guido Günther wrote:
> >
> > > --- /dev/null
>
Hi Fabio,
thanks for having a look! I followed most of your comments, there's some
things i'm unsure, see below:
On Fri, Jul 26, 2019 at 05:01:52PM -0300, Fabio Estevam wrote:
> Hi Guido,
>
> Thanks for your work on this driver!
>
> On Wed, Jul 24, 2019 at 12:52 PM Guido Günther wrote:
>
> >
Hello Guido,
Thank you for the patch.
On Wed, Jul 24, 2019 at 05:52:26PM +0200, Guido Günther wrote:
> This adds initial support for the NWL MIPI DSI Host controller found on
> i.MX8 SoCs.
>
> It adds support for the i.MX8MQ but the same IP can be found on
> e.g. the i.MX8QXP.
>
> It has been
Hello,
On Fri, Jul 26, 2019 at 05:01:52PM -0300, Fabio Estevam wrote:
> Hi Guido,
>
> Thanks for your work on this driver!
>
> On Wed, Jul 24, 2019 at 12:52 PM Guido Günther wrote:
>
> > --- /dev/null
> > +++ b/drivers/gpu/drm/bridge/imx-nwl/Kconfig
> > @@ -0,0 +1,15 @@
> > +config
Hi Guido,
Thanks for your work on this driver!
On Wed, Jul 24, 2019 at 12:52 PM Guido Günther wrote:
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/imx-nwl/Kconfig
> @@ -0,0 +1,15 @@
> +config DRM_IMX_NWL_DSI
> + tristate "Support for Northwest Logic MIPI DSI Host controller"
> +
Hi Guido.
Following some trivial comments.
As for the overall design I already commented on that in the binding.
(bridge versus display controller)
That it can work on top of mxsfb is a good indication that it is a
bridge but I just do not see the full picture.
In general the code looked clean
11 matches
Mail list logo
