Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 23:59 +0300, Andy Shevchenko wrote: > ⚠ External Email > > On Tue, Oct 18, 2022 at 08:26:17PM +, Zack Rusin wrote: > > > On Oct 18, 2022, at 4:20 PM, Andy Shevchenko > > > wrote: > > > On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > > > > From: Zack Rusin

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Andy Shevchenko
On Tue, Oct 18, 2022 at 08:26:17PM +, Zack Rusin wrote: > > On Oct 18, 2022, at 4:20 PM, Andy Shevchenko > > wrote: > > On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > >> From: Zack Rusin > >> > >> v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > >>

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
> On Oct 18, 2022, at 4:20 PM, Andy Shevchenko > wrote: > > ⚠ External Email > > On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: >> From: Zack Rusin >> >> v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the >> info->apertures->ranges[0].base and Laurent

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Andy Shevchenko
On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > From: Zack Rusin > > v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > info->apertures->ranges[0].base and Laurent noticed a neat little cleanup > in the hisilicon driver as a result of the

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 19:28 +0300, Laurent Pinchart wrote: > > @@ -271,7 +260,8 @@ static int hibmc_load(struct drm_device *dev) > >    if (ret) > >    goto err; > > > > - ret = drmm_vram_helper_init(dev, pci_resource_start(pdev, 0), priv- > > >fb_size); > > + ret =

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Laurent Pinchart
Hi Zack, Thank you for the patch. On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > From: Zack Rusin > > v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > info->apertures->ranges[0].base and Laurent noticed a neat little cleanup > in the hisilicon driver as a