Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Laurent Pinchart
On Mon, May 02, 2022 at 09:28:45PM +0200, Javier Martinez Canillas wrote: > On 5/2/22 20:36, Laurent Pinchart wrote: > > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: > >> On 5/2/22 18:55, Javier Martinez Canillas wrote: > >> > >> [snip] > >> > drop the depth

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Javier Martinez Canillas
On 5/2/22 20:36, Laurent Pinchart wrote: > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: >> On 5/2/22 18:55, Javier Martinez Canillas wrote: >> >> [snip] >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME comment in

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Laurent Pinchart
On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: > On 5/2/22 18:55, Javier Martinez Canillas wrote: > > [snip] > > >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME > >> comment in drm_fbdev_generic_setup() that could be related. > > > > A FIXME

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Javier Martinez Canillas
On 5/2/22 18:55, Javier Martinez Canillas wrote: [snip] > >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME >> comment in drm_fbdev_generic_setup() that could be related. >> > > A FIXME makes sense, I'll add that to when posting a v3. There's actually a FIXME already in

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Javier Martinez Canillas
Hello Laurent, On 5/2/22 18:06, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:58PM +0200, Javier Martinez Canillas wrote: >> The drm_fbdev_generic_setup() function already sets the preferred bits per >> pixel for the device to

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Mon, May 02, 2022 at 05:38:58PM +0200, Javier Martinez Canillas wrote: > The drm_fbdev_generic_setup() function already sets the preferred bits per > pixel for the device to dev->mode_config.preferred_depth, if preferred_bpp > value is zero. > > Passing