Re: [EXT] Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
On Mi, 2019-06-19 at 10:28 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Tue, Jun 18, 2019 at 10:31 AM Robert Chiras > wrote: > > > > > +static const struct display_timing rad_default_timing = { > > +   .pixelclock = { 6600, 13200, 13200 }, > > +   

Re: [EXT] Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
Hi Sam, On Mi, 2019-06-19 at 15:25 +0200, Sam Ravnborg wrote: > On Tue, Jun 18, 2019 at 04:30:46PM +0300, Robert Chiras wrote: > > > > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > > protocol). > > > > Signed-off-by: Robert Chiras > Please include in the changelog a list of

Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-19 Thread Fabio Estevam
On Tue, Jun 18, 2019 at 10:31 AM Robert Chiras wrote: > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c > @@ -0,0 +1,709 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * i.MX drm driver - Raydium MIPI-DSI panel driver Please remove the "i.MX drm driver" as there is

Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-19 Thread Fabio Estevam
Hi Robert, On Tue, Jun 18, 2019 at 10:31 AM Robert Chiras wrote: > +static const struct display_timing rad_default_timing = { > + .pixelclock = { 6600, 13200, 13200 }, > + .hactive = { 1080, 1080, 1080 }, > + .hfront_porch = { 20, 20, 20 }, > + .hsync_len = {

Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-19 Thread Sam Ravnborg
On Tue, Jun 18, 2019 at 04:30:46PM +0300, Robert Chiras wrote: > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > protocol). > > Signed-off-by: Robert Chiras Please include in the changelog a list of what was updated - like this: v2: - added kconif symbol sorted (sam) - another