Re: [PATCH v2 2/3] drm/mediatek: support HDMI jack status reporting

2020-02-13 Thread Tzung-Bi Shih
On Thu, Feb 13, 2020 at 9:57 AM CK Hu wrote: > I'm not only consider the race condition of plugged_cb and codec_dev. I > also care about the atomic of mtk_cec_hpd_high() and hdmi->plugged_cb(). > If these two function is not an atomic operation, below is an example of > problem: > > > 1. Thread

Re: [PATCH v2 2/3] drm/mediatek: support HDMI jack status reporting

2020-02-12 Thread CK Hu
Hi, Tzung-Bi: On Wed, 2020-02-12 at 19:31 +0800, Tzung-Bi Shih wrote: > On Wed, Feb 12, 2020 at 4:19 PM CK Hu wrote: > > I think hdmi_conn_detect() and mtk_hdmi_audio_hook_plugged_cb() would be > > called in different thread. So it's necessary to use a mutex to protect > > this. > > Thanks for

Re: [PATCH v2 2/3] drm/mediatek: support HDMI jack status reporting

2020-02-12 Thread CK Hu
Hi, Tzung-Bi: On Thu, 2020-02-06 at 11:17 +0800, Tzung-Bi Shih wrote: > 1. > Provides a callback (i.e. mtk_hdmi_audio_hook_plugged_cb) to hdmi-codec. > When ASoC machine driver calls hdmi_codec_set_jack_detect(), the > callback will be invoked to save plugged_cb and codec_dev parameters. > >