Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-06-17 Thread Stefan Agner
On 2020-05-30 05:10, Laurent Pinchart wrote: > The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha > plane. Support it. > > Signed-off-by: Laurent Pinchart Looks good to me. Reviewed-by: Stefan Agner -- Stefan > --- > Changes since v1: > > - Split whitespace cleanup to

Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-06-05 Thread Emil Velikov
On Tue, 2 Jun 2020 at 23:43, Laurent Pinchart wrote: > > Hi Emil, > > On Sun, May 31, 2020 at 05:54:04PM +0100, Emil Velikov wrote: > > HI Laurent, > > > > From a quick glance the series looks really good and neat. > > Thank you :-) > > > Then again, I don't know much about the hardware to

Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-06-02 Thread Laurent Pinchart
Hi Emil, On Sun, May 31, 2020 at 05:54:04PM +0100, Emil Velikov wrote: > HI Laurent, > > From a quick glance the series looks really good and neat. Thank you :-) > Then again, I don't know much about the hardware to provide meaningful > review. > > A couple of small ideas below. > > On Sat,

Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-05-31 Thread Emil Velikov
HI Laurent, >From a quick glance the series looks really good and neat. Then again, I don't know much about the hardware to provide meaningful review. A couple of small ideas below. On Sat, 30 May 2020 at 04:11, Laurent Pinchart wrote: > +#define LCDC_AS_BUF0x220 >