On Thu, Oct 10, 2019 at 12:23:05PM -0400, Ilia Mirkin wrote:
> On Thu, Oct 10, 2019 at 12:01 PM Sean Paul wrote:
> > > > > +static int vop_crtc_atomic_check(struct drm_crtc *crtc,
> > > > > + struct drm_crtc_state *crtc_state)
> > > > > +{
> > > > > + struct vop
On Thu, Oct 10, 2019 at 12:01 PM Sean Paul wrote:
> > > > +static int vop_crtc_atomic_check(struct drm_crtc *crtc,
> > > > + struct drm_crtc_state *crtc_state)
> > > > +{
> > > > + struct vop *vop = to_vop(crtc);
> > > > +
> > > > + if (vop->lut_regs &&
/snip
> > > +static void vop_crtc_write_gamma_lut(struct vop *vop, struct drm_crtc
> > > *crtc)
> > > +{
> > > + struct drm_color_lut *lut = crtc->state->gamma_lut->data;
> > > + unsigned int i;
> > > +
> > > + for (i = 0; i < crtc->gamma_size; i++) {
> > > + u32 word;
>
Hello Sean,
Thanks for the thourough review.
On Wed, 9 Oct 2019 at 15:01, Sean Paul wrote:
>
> On Tue, Oct 08, 2019 at 08:00:37PM -0300, Ezequiel Garcia wrote:
> > Add an optional CRTC gamma LUT support, and enable it on RK3288.
> > This is currently enabled via a separate address resource,
> >
On Tue, Oct 08, 2019 at 08:00:37PM -0300, Ezequiel Garcia wrote:
> Add an optional CRTC gamma LUT support, and enable it on RK3288.
> This is currently enabled via a separate address resource,
> which needs to be specified in the devicetree.
>
> The address resource is required because on some
