Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2023 at 06:16:27AM +, Vaittinen, Matti wrote: > On 3/21/23 20:59, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2023-03-20 22:45:52) > >> On 3/20/23 21:23, Stephen Boyd wrote: > >>> Quoting Matti Vaittinen (2023-03-18 23:36:20) > >> Besides, I was not sure if you were

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-22 Thread Vaittinen, Matti
On 3/21/23 20:59, Stephen Boyd wrote: > Quoting Matti Vaittinen (2023-03-20 22:45:52) >> Morning Stephen, >> >> On 3/20/23 21:23, Stephen Boyd wrote: >>> Quoting Matti Vaittinen (2023-03-18 23:36:20) >> Besides, I was not sure if you were planning to add similar helper or >> just wrappers to

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-21 Thread Stephen Boyd
Quoting Matti Vaittinen (2023-03-20 22:45:52) > Morning Stephen, > > On 3/20/23 21:23, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2023-03-18 23:36:20) > >>> > >>> I think you would have an easier time if you just copied and renamed > >>> them into the kunit folder as an preparation series.

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-20 Thread Matti Vaittinen
Morning Stephen, On 3/20/23 21:23, Stephen Boyd wrote: Quoting Matti Vaittinen (2023-03-18 23:36:20) I think you would have an easier time if you just copied and renamed them into the kunit folder as an preparation series. Yes. That would simplify the syncing between the trees. It slightly

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-20 Thread Stephen Boyd
Quoting Matti Vaittinen (2023-03-18 23:36:20) > > > > I think you would have an easier time if you just copied and renamed > > them into the kunit folder as an preparation series. > > Yes. That would simplify the syncing between the trees. It slightly bugs > me to add dublicate code in

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-19 Thread Matti Vaittinen
Hi Maxime & All First of all - I am sorry. During the last minute rebase I accidentally dropped the header file from this series. Will fix that for v5. (Also the build bot pointed this mistake). On 3/17/23 17:09, Maxime Ripard wrote: Hi Matti, On Fri, Mar 17, 2023 at 04:42:25PM +0200,

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-17 Thread Maxime Ripard
Hi Matti, On Fri, Mar 17, 2023 at 04:42:25PM +0200, Matti Vaittinen wrote: > The creation of a dummy device in order to test managed interfaces is a > generally useful test feature. The drm test helpers > test_kunit_helper_alloc_device() and test_kunit_helper_free_device() > are doing exactly