Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

OK, I will update patches 1 and 2 and given your RBs push them since they fix some races. I will then update and test patch 3 on some basic scenarios and will send it for separate review where I might put a TODO comment in code with my objections regarding long jobs form our discussion so you

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

I see a few cleanups on Patch #3 which actually belong in patch #1: > +void drm_sched_stop(struct drm_gpu_scheduler *sched, struct > drm_sched_job *bad) The "bad" job parameter actually isn't used any more, isn't it? > +retry_wait: Not used any more. But apart from that at least patch #1 and

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Attached series is the first 2 patches we already discussed about ring mirror list handling racing with all your comments fixed (still not committed). The third patch is a prototype based on the first 2 patches and on our discussion. Please take a look. Andrey On 01/18/2019 01:32 PM,

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 18.01.19 um 18:34 schrieb Grodzovsky, Andrey: > > On 01/18/2019 12:10 PM, Koenig, Christian wrote: >> Am 18.01.19 um 16:21 schrieb Grodzovsky, Andrey: >>> On 01/18/2019 04:25 AM, Koenig, Christian wrote: [SNIP] Re-arming the timeout should probably have a much reduced value

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/18/2019 12:10 PM, Koenig, Christian wrote: > Am 18.01.19 um 16:21 schrieb Grodzovsky, Andrey: >> On 01/18/2019 04:25 AM, Koenig, Christian wrote: >>> [SNIP] >>> Re-arming the timeout should probably have a much reduced value >>> when the job hasn't changed. E.g. something like a

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 18.01.19 um 16:21 schrieb Grodzovsky, Andrey: > > On 01/18/2019 04:25 AM, Koenig, Christian wrote: >> [SNIP] >> Re-arming the timeout should probably have a much reduced value >> when the job hasn't changed. E.g. something like a few ms. >>> Now i got thinking about non hanged job in

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/18/2019 04:25 AM, Koenig, Christian wrote: > [SNIP] > Re-arming the timeout should probably have a much reduced value > when the job hasn't changed. E.g. something like a few ms. >> Now i got thinking about non hanged job in progress (job A) and let's >> say it's a long job , it

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

[SNIP] Re-arming the timeout should probably have a much reduced value when the job hasn't changed. E.g. something like a few ms. > > Now i got thinking about non hanged job in progress (job A) and let's > say it's a long job , it just started executing but due to time out of >

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/17/2019 10:29 AM, Koenig, Christian wrote: Am 17.01.19 um 16:22 schrieb Grodzovsky, Andrey: On 01/17/2019 02:45 AM, Christian König wrote: Am 16.01.19 um 18:17 schrieb Grodzovsky, Andrey: On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/17/2019 10:29 AM, Koenig, Christian wrote: Am 17.01.19 um 16:22 schrieb Grodzovsky, Andrey: On 01/17/2019 02:45 AM, Christian König wrote: Am 16.01.19 um 18:17 schrieb Grodzovsky, Andrey: On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 17.01.19 um 16:22 schrieb Grodzovsky, Andrey: On 01/17/2019 02:45 AM, Christian König wrote: Am 16.01.19 um 18:17 schrieb Grodzovsky, Andrey: On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/17/2019 02:45 AM, Christian König wrote: Am 16.01.19 um 18:17 schrieb Grodzovsky, Andrey: On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 16.01.19 um 18:17 schrieb Grodzovsky, Andrey: On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/16/2019 11:02 AM, Koenig, Christian wrote: Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 16.01.19 um 16:45 schrieb Grodzovsky, Andrey: On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote: Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/16/2019 02:46 AM, Christian König wrote: Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote: Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: On 01/11/2019 04:42 AM, Koenig, Christian

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote: Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: On 01/11/2019 04:42 AM, Koenig, Christian wrote: Am 10.01.19 um 16:56 schrieb Grodzovsky,

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: > > > On 01/11/2019 02:11 PM, Koenig, Christian wrote: >> Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: >>> On 01/11/2019 04:42 AM, Koenig, Christian wrote: Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: > [SNIP] But we will

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/11/2019 02:11 PM, Koenig, Christian wrote: > Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: >> On 01/11/2019 04:42 AM, Koenig, Christian wrote: >>> Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: [SNIP] >>> But we will not be adding the cb back in drm_sched_stop anymore, now we

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: > > On 01/11/2019 04:42 AM, Koenig, Christian wrote: >> Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: >>> [SNIP] >> But we will not be adding the cb back in drm_sched_stop anymore, now we >> are only going to add back the cb in

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/11/2019 04:42 AM, Koenig, Christian wrote: > Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: >> [SNIP] > But we will not be adding the cb back in drm_sched_stop anymore, now we > are only going to add back the cb in drm_sched_startr after rerunning > those jobs in

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: > [SNIP] But we will not be adding the cb back in drm_sched_stop anymore, now we are only going to add back the cb in drm_sched_startr after rerunning those jobs in drm_sched_resubmit_jobs and assign them a new parent there

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Just a ping. Andrey On 01/09/2019 10:18 AM, Andrey Grodzovsky wrote: > > > On 01/09/2019 05:22 AM, Christian König wrote: >> Am 07.01.19 um 20:47 schrieb Grodzovsky, Andrey: >>> >>> On 01/07/2019 09:13 AM, Christian König wrote: Am 03.01.19 um 18:42 schrieb Grodzovsky, Andrey: > On

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/09/2019 05:22 AM, Christian König wrote: > Am 07.01.19 um 20:47 schrieb Grodzovsky, Andrey: >> >> On 01/07/2019 09:13 AM, Christian König wrote: >>> Am 03.01.19 um 18:42 schrieb Grodzovsky, Andrey: On 01/03/2019 11:20 AM, Grodzovsky, Andrey wrote: > On 01/03/2019 03:54 AM, Koenig,

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 07.01.19 um 20:47 schrieb Grodzovsky, Andrey: On 01/07/2019 09:13 AM, Christian König wrote: Am 03.01.19 um 18:42 schrieb Grodzovsky, Andrey: On 01/03/2019 11:20 AM, Grodzovsky, Andrey wrote: On 01/03/2019 03:54 AM, Koenig, Christian wrote: Am 21.12.18 um 21:36 schrieb Grodzovsky,

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/07/2019 09:13 AM, Christian König wrote: > Am 03.01.19 um 18:42 schrieb Grodzovsky, Andrey: >> >> On 01/03/2019 11:20 AM, Grodzovsky, Andrey wrote: >>> On 01/03/2019 03:54 AM, Koenig, Christian wrote: Am 21.12.18 um 21:36 schrieb Grodzovsky, Andrey: > On 12/21/2018 01:37 PM,

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 03.01.19 um 18:42 schrieb Grodzovsky, Andrey: On 01/03/2019 11:20 AM, Grodzovsky, Andrey wrote: On 01/03/2019 03:54 AM, Koenig, Christian wrote: Am 21.12.18 um 21:36 schrieb Grodzovsky, Andrey: On 12/21/2018 01:37 PM, Christian König wrote: Am 20.12.18 um 20:23 schrieb Andrey Grodzovsky:

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/03/2019 11:20 AM, Grodzovsky, Andrey wrote: > > On 01/03/2019 03:54 AM, Koenig, Christian wrote: >> Am 21.12.18 um 21:36 schrieb Grodzovsky, Andrey: >>> On 12/21/2018 01:37 PM, Christian König wrote: Am 20.12.18 um 20:23 schrieb Andrey Grodzovsky: > Decauple sched threads stop and

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 01/03/2019 03:54 AM, Koenig, Christian wrote: > Am 21.12.18 um 21:36 schrieb Grodzovsky, Andrey: >> On 12/21/2018 01:37 PM, Christian König wrote: >>> Am 20.12.18 um 20:23 schrieb Andrey Grodzovsky: Decauple sched threads stop and start and ring mirror list handling from the policy

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 21.12.18 um 21:36 schrieb Grodzovsky, Andrey: > > On 12/21/2018 01:37 PM, Christian König wrote: >> Am 20.12.18 um 20:23 schrieb Andrey Grodzovsky: >>> Decauple sched threads stop and start and ring mirror >>> list handling from the policy of what to do about the >>> guilty jobs. >>> When

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

On 12/21/2018 01:37 PM, Christian König wrote: > Am 20.12.18 um 20:23 schrieb Andrey Grodzovsky: >> Decauple sched threads stop and start and ring mirror >> list handling from the policy of what to do about the >> guilty jobs. >> When stoppping the sched thread and detaching sched fences >> from

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Am 20.12.18 um 20:23 schrieb Andrey Grodzovsky: Decauple sched threads stop and start and ring mirror list handling from the policy of what to do about the guilty jobs. When stoppping the sched thread and detaching sched fences from non signaled HW fenes wait for all signaled HW fences to