Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-12 Thread Thomas Zimmermann
Am 11.07.2018 um 21:19 schrieb Steven Rostedt: > I just sent the patch. If the printk maintainers take it, then you can > update the fb driver to set the ignore_console_lock_warning when > lockless_fb_register is set. Thank you. > > -- Steve > ___ >

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-12 Thread Sergey Senozhatsky
Hi, On (07/11/18 16:46), Thomas Zimmermann wrote: > Am 28.06.2018 um 11:03 schrieb Hans de Goede: > > Replace comments about places where the console lock should be held with > > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. > > Debugging fbcon sometimes requires to not

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 21:19, Steven Rostedt wrote: On Wed, 11 Jul 2018 19:56:02 +0200 Daniel Vetter wrote: Have you seen Steven's suggestion which he send about the same time as your mail I'm replying to here ? I personally think that doing something like that makes sense (for as long as we have

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Steven Rostedt
On Wed, 11 Jul 2018 19:56:02 +0200 Daniel Vetter wrote: > > Have you seen Steven's suggestion which he send about the same time > > as your mail I'm replying to here ? I personally think that doing > > something like that makes sense (for as long as we have the need > > for the

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 7:35 PM, Hans de Goede wrote: > Hi, > > > On 11-07-18 17:42, Daniel Vetter wrote: >> >> On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> On 11-07-18 17:28, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 17:42, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede wrote: Hi, On 11-07-18 17:28, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote: Hi, On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede wrote: > Hi, > > On 11-07-18 17:28, Daniel Vetter wrote: >> >> On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb Steven

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Steven Rostedt
On Wed, 11 Jul 2018 17:35:10 +0200 Hans de Goede wrote: > OK, so if we don't remove it, we should probably make it so that it > can be used without triggering any WARN_ONs, which would require changing > the existing WARN_CONSOLE_UNLOCKED() so that the calls from > drivers/tty/vt/vt.c > also do

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 17:28, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote: Hi, On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb Steven Rostedt: What if you make lockless_register_fb visible to fbcon, and then we can have a macro:

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote: > Hi, > > On 11-07-18 17:07, Thomas Zimmermann wrote: >> >> Hi >> >> Am 11.07.2018 um 16:52 schrieb Steven Rostedt: >>> >>> >>> What if you make lockless_register_fb visible to fbcon, and then we can >>> have a macro: >> >> >> There are more

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb Steven Rostedt: What if you make lockless_register_fb visible to fbcon, and then we can have a macro: There are more of these macro invocations under drivers/tty/vt, which also mess up the log during

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 5:01 PM, Hans de Goede wrote: > Hi, > > On 11-07-18 16:52, Steven Rostedt wrote: >> >> On Wed, 11 Jul 2018 16:46:11 +0200 >> Thomas Zimmermann wrote: >> >>> Hi >>> >>> Am 28.06.2018 um 11:03 schrieb Hans de Goede: Replace comments about places where the console

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Thomas Zimmermann
Hi Am 11.07.2018 um 16:52 schrieb Steven Rostedt: > > What if you make lockless_register_fb visible to fbcon, and then we can > have a macro: There are more of these macro invocations under drivers/tty/vt, which also mess up the log during debugging. WARN_CONSOLE_UNLOCKED is already protected

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 16:52, Steven Rostedt wrote: On Wed, 11 Jul 2018 16:46:11 +0200 Thomas Zimmermann wrote: Hi Am 28.06.2018 um 11:03 schrieb Hans de Goede: Replace comments about places where the console lock should be held with calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Steven Rostedt
On Wed, 11 Jul 2018 16:46:11 +0200 Thomas Zimmermann wrote: > Hi > > Am 28.06.2018 um 11:03 schrieb Hans de Goede: > > Replace comments about places where the console lock should be held with > > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. > > Debugging fbcon

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Thomas Zimmermann
Hi Am 28.06.2018 um 11:03 schrieb Hans de Goede: > Replace comments about places where the console lock should be held with > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Debugging fbcon sometimes requires to not take the console lock. This patch breaks the debugging