Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-08 Thread Abhinav Kumar
Hi Doug and Dmitry On 4/8/2022 7:58 AM, Dmitry Baryshkov wrote: On Fri, 8 Apr 2022 at 16:43, Doug Anderson wrote: Hi, On Fri, Apr 8, 2022 at 5:20 AM Dmitry Baryshkov wrote: I guess my thought was that in DP you could still create the AUX bus at probe time. Then for DP you just return an

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-08 Thread Dmitry Baryshkov
On Fri, 8 Apr 2022 at 16:43, Doug Anderson wrote: > > Hi, > > On Fri, Apr 8, 2022 at 5:20 AM Dmitry Baryshkov > wrote: > > > > > I guess my thought was that in DP you could still create the AUX bus > > > at probe time. Then for DP you just return an instant "transfer > > > failed" from the AUX

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-08 Thread Dmitry Baryshkov
On Fri, 8 Apr 2022 at 16:56, Doug Anderson wrote: > > Hi, > > On Fri, Apr 8, 2022 at 5:13 AM Dmitry Baryshkov > wrote: > > > > On Fri, 8 Apr 2022 at 03:28, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Thu, Apr 7, 2022 at 4:36 PM Dmitry Baryshkov > > > wrote: > > > > > > > > The ps8640

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-08 Thread Doug Anderson
Hi, On Fri, Apr 8, 2022 at 5:13 AM Dmitry Baryshkov wrote: > > On Fri, 8 Apr 2022 at 03:28, Doug Anderson wrote: > > > > Hi, > > > > On Thu, Apr 7, 2022 at 4:36 PM Dmitry Baryshkov > > wrote: > > > > > > The ps8640 driver looks 'working by coincidence'. It calls > > > dp_aux_populate, then

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-08 Thread Doug Anderson
Hi, On Fri, Apr 8, 2022 at 5:20 AM Dmitry Baryshkov wrote: > > > I guess my thought was that in DP you could still create the AUX bus > > at probe time. Then for DP you just return an instant "transfer > > failed" from the AUX bus if HPD isn't asserted. For eDP (as discussed > > elsewhere) when

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-08 Thread Dmitry Baryshkov
On Fri, 8 Apr 2022 at 03:26, Doug Anderson wrote: > > Hi, > > On Thu, Apr 7, 2022 at 4:46 PM Dmitry Baryshkov > wrote: > > > > > The way I'm arguing it should work is that: > > > > > > 1. A whole bunch of the DP init code should move to the DP driver's > > > probe function. This includes parsing

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-08 Thread Dmitry Baryshkov
On Fri, 8 Apr 2022 at 03:28, Doug Anderson wrote: > > Hi, > > On Thu, Apr 7, 2022 at 4:36 PM Dmitry Baryshkov > wrote: > > > > The ps8640 driver looks 'working by coincidence'. It calls > > dp_aux_populate, then immediately after the function returns it checks > > for the panel. If panel-edp is

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Doug Anderson
Hi, On Thu, Apr 7, 2022 at 4:46 PM Dmitry Baryshkov wrote: > > > The way I'm arguing it should work is that: > > > > 1. A whole bunch of the DP init code should move to the DP driver's > > probe function. This includes parsing the DT, acquiring clocks, > > getting a handle to our PHY, and IO

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Doug Anderson
Hi, On Thu, Apr 7, 2022 at 4:36 PM Dmitry Baryshkov wrote: > > The ps8640 driver looks 'working by coincidence'. It calls > dp_aux_populate, then immediately after the function returns it checks > for the panel. If panel-edp is built as a module, the probe might fail > easily. > The anx7625

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Dmitry Baryshkov
On Fri, 8 Apr 2022 at 02:35, Doug Anderson wrote: > > Hi, > > On Thu, Apr 7, 2022 at 3:03 PM Abhinav Kumar > wrote: > > > > Hi Doug > > > > Thanks for the response, some comments below. > > > > Abhinav > > On 4/7/2022 1:47 PM, Doug Anderson wrote: > > > Hi, > > > > > > On Thu, Apr 7, 2022 at

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Dmitry Baryshkov
On Thu, 7 Apr 2022 at 23:11, Abhinav Kumar wrote: > > Hi Doug and Dmitry > > Sorry, but I caught up on this email just now. > > Some comments below. > > Thanks > > Abhinav > On 4/7/2022 10:07 AM, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC) > >

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Doug Anderson
Hi, On Thu, Apr 7, 2022 at 3:03 PM Abhinav Kumar wrote: > > Hi Doug > > Thanks for the response, some comments below. > > Abhinav > On 4/7/2022 1:47 PM, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar > > wrote: > >> > >> Hi Doug and Dmitry > >> > >> Sorry,

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Abhinav Kumar
Hi Doug Thanks for the response, some comments below. Abhinav On 4/7/2022 1:47 PM, Doug Anderson wrote: Hi, On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar wrote: Hi Doug and Dmitry Sorry, but I caught up on this email just now. Some comments below. Thanks Abhinav On 4/7/2022 10:07 AM,

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Doug Anderson
Hi, On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar wrote: > > Hi Doug and Dmitry > > Sorry, but I caught up on this email just now. > > Some comments below. > > Thanks > > Abhinav > On 4/7/2022 10:07 AM, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Abhinav Kumar
Hi Doug and Dmitry Sorry, but I caught up on this email just now. Some comments below. Thanks Abhinav On 4/7/2022 10:07 AM, Doug Anderson wrote: Hi, On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC) wrote: Hi Dmitry and Doug, Hi, On Tue, Apr 5, 2022 at 10:36 AM Dmitry

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Doug Anderson
Hi, On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC) wrote: > > Hi Dmitry and Doug, > > > Hi, > > > > On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov > > wrote: > > > > > > On 05/04/2022 20:02, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Tue, Apr 5, 2022 at 5:54 AM Dmitry

RE: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-07 Thread Sankeerth Billakanti (QUIC)
Hi Dmitry and Doug, > Hi, > > On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov > wrote: > > > > On 05/04/2022 20:02, Doug Anderson wrote: > > > Hi, > > > > > > On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov > > > wrote: > > >>> 3. For DP and eDP HPD means something a little different. > > >>>

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Doug Anderson
Hi, On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov wrote: > > On 05/04/2022 20:02, Doug Anderson wrote: > > Hi, > > > > On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov > > wrote: > >>> 3. For DP and eDP HPD means something a little different. Essentially > >>> there are two concepts: a) is a

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Dmitry Baryshkov
On 05/04/2022 20:02, Doug Anderson wrote: Hi, On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov wrote: 3. For DP and eDP HPD means something a little different. Essentially there are two concepts: a) is a display physically connected and b) is the display powered up and ready. For DP, the two

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Doug Anderson
Hi, On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov wrote: > > 3. For DP and eDP HPD means something a little different. Essentially > > there are two concepts: a) is a display physically connected and b) is > > the display powered up and ready. For DP, the two are really tied > > together. From

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 23:53, Doug Anderson wrote: > > Hi, > > On Sat, Apr 2, 2022 at 1:26 PM Dmitry Baryshkov > wrote: > > > > On Sat, 2 Apr 2022 at 20:06, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov > > > wrote: > > > > > > > > On

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-04 Thread Doug Anderson
Hi, On Sat, Apr 2, 2022 at 1:26 PM Dmitry Baryshkov wrote: > > On Sat, 2 Apr 2022 at 20:06, Doug Anderson wrote: > > > > Hi, > > > > On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov > > wrote: > > > > > > On 01/04/2022 02:22, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Wed, Mar 30, 2022

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-02 Thread Dmitry Baryshkov
On Sat, 2 Apr 2022 at 20:06, Doug Anderson wrote: > > Hi, > > On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov > wrote: > > > > On 01/04/2022 02:22, Doug Anderson wrote: > > > Hi, > > > > > > On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti > > > wrote: > > >> > > >> @@ -1547,6 +1593,10 @@

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-02 Thread Doug Anderson
Hi, On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov wrote: > > On 01/04/2022 02:22, Doug Anderson wrote: > > Hi, > > > > On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti > > wrote: > >> > >> @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, > >> struct drm_device

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-02 Thread Dmitry Baryshkov
On 01/04/2022 02:22, Doug Anderson wrote: Hi, On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti wrote: @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev, dp_display->encoder = encoder; + ret =

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-03-31 Thread Doug Anderson
Hi, On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti wrote: > > @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, > struct drm_device *dev, > > dp_display->encoder = encoder; > > + ret = dp_display_get_next_bridge(dp_display); > + if (ret) > +

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-03-30 Thread Doug Anderson
Hi, On Wed, Mar 30, 2022 at 4:19 PM Dmitry Baryshkov wrote: > > + bridge->ops = > > + DRM_BRIDGE_OP_DETECT | > > + DRM_BRIDGE_OP_HPD | > > + DRM_BRIDGE_OP_MODES; > > I think OP_MODES should be used for eDP, shouldn't it?

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-03-30 Thread Dmitry Baryshkov
On 30/03/2022 19:02, Sankeerth Billakanti wrote: This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel