Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-28 Thread Dmitry Osipenko
27.10.2020 23:22, Dmitry Osipenko пишет: ... >>> + >>> + *agg_avg += avg_bw; >>> + *agg_peak = max(*agg_peak, peak_bw); >> >> I'm not very familiar with ICC, but shouldn't the aggregated peak value >> be the sum of the current aggregated peak and the new peak bandwidth? >> Currently you're

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-28 Thread Dmitry Osipenko
27.10.2020 13:09, Krzysztof Kozlowski пишет: ... >> +err_msg: >> +dev_err(emc->dev, "failed to initialize ICC: %d\n", err); > > You will print such errors on all existing DTBs. Since it is not a > failure of probe (it is actually quite expected, normal situation when > booting with older

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-28 Thread Dmitry Osipenko
27.10.2020 17:11, Thierry Reding пишет: ... >> +static int emc_icc_set(struct icc_node *src, struct icc_node *dst) >> +{ >> +struct tegra_emc *emc = to_tegra_emc_provider(dst->provider); >> +unsigned long long peak_bw = icc_units_to_bps(dst->peak_bw); >> +unsigned long long avg_bw =

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-27 Thread Thierry Reding
On Mon, Oct 26, 2020 at 01:17:16AM +0300, Dmitry Osipenko wrote: > Now Internal and External Memory Controllers are memory interconnection > providers. This allows us to use interconnect API for tuning of memory > configuration. EMC driver now supports OPPs and DVFS. > > Signed-off-by: Dmitry

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-27 Thread Krzysztof Kozlowski
On Mon, Oct 26, 2020 at 01:17:16AM +0300, Dmitry Osipenko wrote: > Now Internal and External Memory Controllers are memory interconnection > providers. This allows us to use interconnect API for tuning of memory > configuration. EMC driver now supports OPPs and DVFS. > > Signed-off-by: Dmitry