Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-23 Thread Laurent Pinchart
Hello Esaki-san, Thank you for the patch. On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote: > The LINEAR modifier is advertised as default if a driver doesn't specify > modifiers. > > Signed-off-by: Tomohito Esaki > --- > drivers/gpu/drm/drm_plane.c | 15 --- >

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 11:35:22AM +0900, Esaki Tomohito wrote: > On 2022/01/18 18:53, Andy Shevchenko wrote: > > On Mon, Jan 17, 2022 at 02:15:48PM +0900, Esaki Tomohito wrote: > > > On 2022/01/14 23:16, Andy Shevchenko wrote: > > > > On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-18 Thread Esaki Tomohito
On 2022/01/18 18:53, Andy Shevchenko wrote: On Mon, Jan 17, 2022 at 02:15:48PM +0900, Esaki Tomohito wrote: On 2022/01/14 23:16, Andy Shevchenko wrote: On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote: The LINEAR modifier is advertised as default if a driver doesn't specify

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-18 Thread Andy Shevchenko
On Mon, Jan 17, 2022 at 02:15:48PM +0900, Esaki Tomohito wrote: > On 2022/01/14 23:16, Andy Shevchenko wrote: > > On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote: > > > The LINEAR modifier is advertised as default if a driver doesn't specify > > > modifiers. > > > > ... > > > > >

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-16 Thread Esaki Tomohito
Thank you for your reviews. On 2022/01/14 23:16, Andy Shevchenko wrote: On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote: The LINEAR modifier is advertised as default if a driver doesn't specify modifiers. ... + const uint64_t default_modifiers[] = { +

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-14 Thread Andy Shevchenko
On Fri, Jan 14, 2022 at 03:42:54PM +, Simon Ser wrote: > On Friday, January 14th, 2022 at 16:17, Andy Shevchenko > wrote: > > > On Fri, Jan 14, 2022 at 03:07:21PM +, Simon Ser wrote: > > > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko > > > wrote: > > > > > > > Why not enum?

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-14 Thread Simon Ser
On Friday, January 14th, 2022 at 16:17, Andy Shevchenko wrote: > On Fri, Jan 14, 2022 at 03:07:21PM +, Simon Ser wrote: > > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko > > wrote: > > > > > Why not enum? > > > > There is no enum for DRM format modifiers. > > I'm not sure how

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-14 Thread Andy Shevchenko
On Fri, Jan 14, 2022 at 03:07:21PM +, Simon Ser wrote: > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko > wrote: > > > Why not enum? > > There is no enum for DRM format modifiers. I'm not sure how this prevents to use enum in the code instead of const u64. Any specific reason for

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-14 Thread Simon Ser
On Friday, January 14th, 2022 at 15:16, Andy Shevchenko wrote: > Why not enum? There is no enum for DRM format modifiers.

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-14 Thread Andy Shevchenko
On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote: > The LINEAR modifier is advertised as default if a driver doesn't specify > modifiers. ... > + const uint64_t default_modifiers[] = { > + DRM_FORMAT_MOD_LINEAR, > + DRM_FORMAT_MOD_INVALID + Comma? > +