Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-26 Thread Knut Omang
On Mon, 2019-03-25 at 15:32 -0700, Brendan Higgins wrote: > On Fri, Mar 22, 2019 at 12:11 AM Knut Omang wrote: > > On Thu, 2019-03-21 at 18:41 -0700, Brendan Higgins wrote: > > > On Thu, Mar 21, 2019 at 6:10 PM Frank Rowand > > > wrote: > > > > On 2/27/19 11:42 PM, Brendan Higgins wrote: > > >

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-25 Thread Brendan Higgins
On Fri, Mar 22, 2019 at 12:11 AM Knut Omang wrote: > > On Thu, 2019-03-21 at 18:41 -0700, Brendan Higgins wrote: > > On Thu, Mar 21, 2019 at 6:10 PM Frank Rowand wrote: > > > On 2/27/19 11:42 PM, Brendan Higgins wrote: > > > > On Tue, Feb 19, 2019 at 10:44 PM Frank Rowand > > > > wrote: > > > >

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-24 Thread Knut Omang
On Thu, 2019-03-21 at 18:41 -0700, Brendan Higgins wrote: > On Thu, Mar 21, 2019 at 6:10 PM Frank Rowand wrote: > > On 2/27/19 11:42 PM, Brendan Higgins wrote: > > > On Tue, Feb 19, 2019 at 10:44 PM Frank Rowand > > > wrote: > > > > On 2/19/19 7:39 PM, Brendan Higgins wrote: > > > > > On Mon,

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-24 Thread Frank Rowand
On 2/27/19 11:42 PM, Brendan Higgins wrote: > On Tue, Feb 19, 2019 at 10:44 PM Frank Rowand wrote: >> >> On 2/19/19 7:39 PM, Brendan Higgins wrote: >>> On Mon, Feb 18, 2019 at 11:52 AM Frank Rowand >>> wrote: On 2/14/19 1:37 PM, Brendan Higgins wrote: > Add support for

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-21 Thread Brendan Higgins
On Thu, Mar 21, 2019 at 6:10 PM Frank Rowand wrote: > > On 2/27/19 11:42 PM, Brendan Higgins wrote: > > On Tue, Feb 19, 2019 at 10:44 PM Frank Rowand > > wrote: > >> > >> On 2/19/19 7:39 PM, Brendan Higgins wrote: > >>> On Mon, Feb 18, 2019 at 11:52 AM Frank Rowand > >>> wrote: > >

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-04 Thread Brendan Higgins
On Thu, Feb 28, 2019 at 10:02 AM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-02-28 01:03:24) > > On Tue, Feb 26, 2019 at 12:35 PM Stephen Boyd wrote: > > > > > > when they need to abort and then the test runner would detect that error > > > via the return value from the 'run test'

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-04 Thread Brendan Higgins
On Thu, Feb 28, 2019 at 5:55 AM Dan Carpenter wrote: > > On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote: > > you could do: > > > > if (IS_ERR_OR_NULL(ptr)) { > > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > > return; > > } > > It's best to not mix

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-28 Thread Stephen Boyd
Quoting Brendan Higgins (2019-02-28 01:03:24) > On Tue, Feb 26, 2019 at 12:35 PM Stephen Boyd wrote: > > > > when they need to abort and then the test runner would detect that error > > via the return value from the 'run test' function. That would be a more > > direct approach, but also more

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-28 Thread Dan Carpenter
On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote: > you could do: > > if (IS_ERR_OR_NULL(ptr)) { > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > return; > } It's best to not mix error pointers and NULL but when we do mix them, it means that NULL is a

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-28 Thread Brendan Higgins
On Tue, Feb 26, 2019 at 12:35 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-02-14 13:37:20) > > Add support for aborting/bailing out of test cases. Needed for > > implementing assertions. > > Can you add some more text here with the motivating reasons for > implementing assertions and

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-27 Thread Brendan Higgins
On Tue, Feb 19, 2019 at 10:44 PM Frank Rowand wrote: > > On 2/19/19 7:39 PM, Brendan Higgins wrote: > > On Mon, Feb 18, 2019 at 11:52 AM Frank Rowand > > wrote: > >> > >> On 2/14/19 1:37 PM, Brendan Higgins wrote: > >>> Add support for aborting/bailing out of test cases. Needed for > >>>

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-26 Thread Stephen Boyd
Quoting Brendan Higgins (2019-02-14 13:37:20) > Add support for aborting/bailing out of test cases. Needed for > implementing assertions. Can you add some more text here with the motivating reasons for implementing assertions and bailing out of test cases? For example, I wonder why unit tests

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-20 Thread Frank Rowand
On 2/19/19 7:39 PM, Brendan Higgins wrote: > On Mon, Feb 18, 2019 at 11:52 AM Frank Rowand wrote: >> >> On 2/14/19 1:37 PM, Brendan Higgins wrote: >>> Add support for aborting/bailing out of test cases. Needed for >>> implementing assertions. >>> >>> Signed-off-by: Brendan Higgins >>> --- >>>

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-19 Thread Brendan Higgins
On Mon, Feb 18, 2019 at 11:52 AM Frank Rowand wrote: > > On 2/14/19 1:37 PM, Brendan Higgins wrote: > > Add support for aborting/bailing out of test cases. Needed for > > implementing assertions. > > > > Signed-off-by: Brendan Higgins > > --- > > Changes Since Last Version > > - This patch is

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-19 Thread Frank Rowand
On 2/14/19 1:37 PM, Brendan Higgins wrote: > Add support for aborting/bailing out of test cases. Needed for > implementing assertions. > > Signed-off-by: Brendan Higgins > --- > Changes Since Last Version > - This patch is new introducing a new cross-architecture way to abort >out of a test