Re: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON

2018-03-09 Thread Ondřej Jirman
Hi Jernej, On Thu, Mar 08, 2018 at 11:57:40PM +0100, Jernej Škrabec wrote: > Hi, > > Dne četrtek, 08. marec 2018 ob 23:47:17 CET je Ondřej Jirman napisal(a): > > Hi, > > > > On Thu, Mar 01, 2018 at 10:34:32PM +0100, Jernej Skrabec wrote: > > > Currently exclusive TCON clock lock is never

Re: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON

2018-03-09 Thread Ondřej Jirman
Hi, On Fri, Mar 09, 2018 at 07:19:33AM +0100, Jernej Škrabec wrote: > Hi, > > Dne petek, 09. marec 2018 ob 01:44:55 CET je Ondřej Jirman napisal(a): > > Hi, > > > > I've debugged this further and it seems that the code has incorrect > > assumptions. See docs for mode_set_nofb. > > > >

Re: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON

2018-03-09 Thread Jernej Škrabec
Hi, Dne petek, 09. marec 2018 ob 01:44:55 CET je Ondřej Jirman napisal(a): > Hi, > > I've debugged this further and it seems that the code has incorrect > assumptions. See docs for mode_set_nofb. > > https://elixir.bootlin.com/linux/v4.16-rc4/source/include/drm/drm_modeset_he >

Re: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON

2018-03-09 Thread Ondřej Jirman
Hi, I've debugged this further and it seems that the code has incorrect assumptions. See docs for mode_set_nofb. https://elixir.bootlin.com/linux/v4.16-rc4/source/include/drm/drm_modeset_helper_vtables.h#L209 I've added traces to a few functions that call clk_.*exclusive.*() functions, and I

Re: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON

2018-03-09 Thread Ondřej Jirman
Hi, On Thu, Mar 01, 2018 at 10:34:32PM +0100, Jernej Skrabec wrote: > Currently exclusive TCON clock lock is never released, which, for > example, prevents changing resolution on HDMI. > > In order to fix that, release clock when disabling TCON. TCON is always > disabled first before new mode is

Re: [linux-sunxi] [PATCH v3 06/16] drm/sun4i: Release exclusive clock lock when disabling TCON

2018-03-09 Thread Jernej Škrabec
Hi, Dne četrtek, 08. marec 2018 ob 23:47:17 CET je Ondřej Jirman napisal(a): > Hi, > > On Thu, Mar 01, 2018 at 10:34:32PM +0100, Jernej Skrabec wrote: > > Currently exclusive TCON clock lock is never released, which, for > > example, prevents changing resolution on HDMI. > > > > In order to fix