Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-12 Thread Keith Zhao
On 2023/12/11 20:13, Andy Yan wrote: > Hi Keith: > > 在 2023-12-11 18:24:35,"Keith Zhao" 写道: >>hi Maxime: >>hi Andy: >> >>On 2023/12/8 17:14, Maxime Ripard wrote: >>> Hi, >>> >>> On Fri, Dec 08, 2023 at 11:23:37AM +0800, Andy Yan wrote: 在 2023-12-08 11:00:31,"Keith Zhao" 写道: >

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-11 Thread Rob Herring
On Mon, Dec 4, 2023 at 6:33 AM Keith Zhao wrote: > > add hdmi driver as encoder and connect > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Kconfig | 8 + > drivers/gpu/drm/verisilicon/Makefile| 1 + > drivers/gpu/drm/verisilicon/starfive_hdmi.c | 849

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-11 Thread Keith Zhao
hi Maxime: hi Andy: On 2023/12/8 17:14, Maxime Ripard wrote: > Hi, > > On Fri, Dec 08, 2023 at 11:23:37AM +0800, Andy Yan wrote: >> 在 2023-12-08 11:00:31,"Keith Zhao" 写道: >> > >> > >> >On 2023/12/8 8:37, Andy Yan wrote: >> >> Hi Keth: >> >> >> >> >> >> >> >> >> >> >> >> >> >> 在 2023-12-07

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-08 Thread Maxime Ripard
Hi, On Fri, Dec 08, 2023 at 11:23:37AM +0800, Andy Yan wrote: > 在 2023-12-08 11:00:31,"Keith Zhao" 写道: > > > > > >On 2023/12/8 8:37, Andy Yan wrote: > >> Hi Keth: > >> > >> > >> > >> > >> > >> > >> 在 2023-12-07 18:48:13,"Keith Zhao" 写道: > >>> > >>> > >>>On 2023/12/7 17:02, Andy Yan wrote:

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-07 Thread Keith Zhao
On 2023/12/8 8:37, Andy Yan wrote: > Hi Keth: > > > > > > > 在 2023-12-07 18:48:13,"Keith Zhao" 写道: >> >> >>On 2023/12/7 17:02, Andy Yan wrote: >>> >>> >>> >>> >>> Hi Keith: >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> At 2023-12-06 22:11:33, "Keith Zhao" wrote:

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-07 Thread Keith Zhao
On 2023/12/7 17:02, Andy Yan wrote: > > > > > Hi Keith: > > > > > > > > > > > > At 2023-12-06 22:11:33, "Keith Zhao" wrote: >> >> >>On 2023/12/6 20:56, Maxime Ripard wrote: >>> On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >> +static const struct of_device_id

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Keith Zhao
On 2023/12/6 20:56, Maxime Ripard wrote: > On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >> >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { >> >> + { .compatible = "starfive,jh7110-inno-hdmi",}, >> > >> > So it's inno hdmi, just like Rockchip then? >> > >> > This

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Maxime Ripard
On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: > >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { > >> + { .compatible = "starfive,jh7110-inno-hdmi",}, > > > > So it's inno hdmi, just like Rockchip then? > > > > This should be a common driver. > > Rockchip has a inno

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Keith Zhao
On 2023/12/6 17:04, Maxime Ripard wrote: > On Mon, Dec 04, 2023 at 08:33:14PM +0800, Keith Zhao wrote: >> add hdmi driver as encoder and connect >> >> Signed-off-by: Keith Zhao >> --- >> drivers/gpu/drm/verisilicon/Kconfig | 8 + >> drivers/gpu/drm/verisilicon/Makefile| 1

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Maxime Ripard
On Mon, Dec 04, 2023 at 08:33:14PM +0800, Keith Zhao wrote: > add hdmi driver as encoder and connect > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Kconfig | 8 + > drivers/gpu/drm/verisilicon/Makefile| 1 + > drivers/gpu/drm/verisilicon/starfive_hdmi.c |

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-05 Thread Dmitry Baryshkov
On Mon, 4 Dec 2023 at 14:33, Keith Zhao wrote: > > add hdmi driver as encoder and connect > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Kconfig | 8 + > drivers/gpu/drm/verisilicon/Makefile| 1 + > drivers/gpu/drm/verisilicon/starfive_hdmi.c | 849