Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-31 Thread Marek Szyprowski
Hi Alex, On 2020-03-31 16:10, Alex Deucher wrote: > On Tue, Mar 31, 2020 at 1:25 AM Marek Szyprowski > wrote: >> Hi Alex, >> >> On 2020-03-30 15:23, Alex Deucher wrote: >>> On Mon, Mar 30, 2020 at 4:18 AM Marek Szyprowski >>> wrote: Hi On 2020-03-27 10:10, Marek Szyprowski wrote:

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-31 Thread Alex Deucher
On Tue, Mar 31, 2020 at 1:25 AM Marek Szyprowski wrote: > > Hi Alex, > > On 2020-03-30 15:23, Alex Deucher wrote: > > On Mon, Mar 30, 2020 at 4:18 AM Marek Szyprowski > > wrote: > >> Hi > >> > >> On 2020-03-27 10:10, Marek Szyprowski wrote: > >>> Hi Christian, > >>> > >>> On 2020-03-27 09:11,

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-30 Thread Marek Szyprowski
Hi Alex, On 2020-03-30 15:23, Alex Deucher wrote: > On Mon, Mar 30, 2020 at 4:18 AM Marek Szyprowski > wrote: >> Hi >> >> On 2020-03-27 10:10, Marek Szyprowski wrote: >>> Hi Christian, >>> >>> On 2020-03-27 09:11, Christian König wrote: Am 27.03.20 um 08:54 schrieb Marek Szyprowski: >

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-30 Thread Alex Deucher
On Mon, Mar 30, 2020 at 4:18 AM Marek Szyprowski wrote: > > Hi > > On 2020-03-27 10:10, Marek Szyprowski wrote: > > Hi Christian, > > > > On 2020-03-27 09:11, Christian König wrote: > >> Am 27.03.20 um 08:54 schrieb Marek Szyprowski: > >>> On 2020-03-25 10:07, Shane Francis wrote: > As

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-30 Thread Shane Francis
On Mon, Mar 30, 2020 at 9:18 AM Marek Szyprowski wrote: > Today I've noticed that this patch went to final v5.6 without even a day > of testing in linux-next, so v5.6 is broken on Exynos and probably a few > other ARM archs, which rely on the drm_prime_sg_to_page_addr_arrays > function. > > Best

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-30 Thread Shane Francis
On Mon, Mar 30, 2020 at 9:18 AM Marek Szyprowski wrote: > Today I've noticed that this patch went to final v5.6 without even a day > of testing in linux-next, so v5.6 is broken on Exynos and probably a few > other ARM archs, which rely on the drm_prime_sg_to_page_addr_arrays > function. > > Best

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-30 Thread Shane Francis
On Mon, Mar 30, 2020 at 9:18 AM Marek Szyprowski wrote: > Today I've noticed that this patch went to final v5.6 without even a day > of testing in linux-next, so v5.6 is broken on Exynos and probably a few > other ARM archs, which rely on the drm_prime_sg_to_page_addr_arrays > function. > > Best

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-30 Thread Marek Szyprowski
Hi On 2020-03-27 10:10, Marek Szyprowski wrote: > Hi Christian, > > On 2020-03-27 09:11, Christian König wrote: >> Am 27.03.20 um 08:54 schrieb Marek Szyprowski: >>> On 2020-03-25 10:07, Shane Francis wrote: As dma_map_sg can reorganize scatter-gather lists in a way that can cause some

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-27 Thread Marek Szyprowski
Hi Christian, On 2020-03-27 09:11, Christian König wrote: > Am 27.03.20 um 08:54 schrieb Marek Szyprowski: >> On 2020-03-25 10:07, Shane Francis wrote: >>> As dma_map_sg can reorganize scatter-gather lists in a >>> way that can cause some later segments to be empty we should >>> always use the

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-27 Thread Marek Szyprowski
On 2020-03-27 08:54, Marek Szyprowski wrote: > On 2020-03-25 10:07, Shane Francis wrote: >> As dma_map_sg can reorganize scatter-gather lists in a >> way that can cause some later segments to be empty we should >> always use the sg_dma_len macro to fetch the actual length. >> >> This could now be

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-27 Thread Christian König
Am 27.03.20 um 08:54 schrieb Marek Szyprowski: Hi All, On 2020-03-25 10:07, Shane Francis wrote: As dma_map_sg can reorganize scatter-gather lists in a way that can cause some later segments to be empty we should always use the sg_dma_len macro to fetch the actual length. This could now be 0

Re: [v4,1/3] drm/prime: use dma length macro when mapping sg

2020-03-27 Thread Marek Szyprowski
Hi All, On 2020-03-25 10:07, Shane Francis wrote: > As dma_map_sg can reorganize scatter-gather lists in a > way that can cause some later segments to be empty we should > always use the sg_dma_len macro to fetch the actual length. > > This could now be 0 and not need to be mapped to a page or >