Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread John Hubbard
On 8/28/25 12:31 PM, Miguel Ojeda wrote: > On Thu, Aug 28, 2025 at 9:24 PM Danilo Krummrich wrote: >> >> Maybe I spoke too soon, it's actually pretty painful to keep 32-bit >> compatibility, even though it would be nice for testing purposes. >> >> I'll paste the diff to fix it below, I think that

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Danilo Krummrich
On 8/28/25 11:45 PM, John Hubbard wrote: So Nova should definitely depend upon 64-bit configs. Yeah, I fully agree. But I think it would have been good to have a consumer for the generic APIs that has to deal with it, which I think was also Miguel's point. I will send a patch for Nova to depe

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Danilo Krummrich
On Thu Aug 28, 2025 at 9:58 PM CEST, Danilo Krummrich wrote: > On Thu Aug 28, 2025 at 9:36 PM CEST, Miguel Ojeda wrote: >> On Thu, Aug 28, 2025 at 9:31 PM Miguel Ojeda >> wrote: >>> >>> and a `DmaAddress` >>> newtype, not just a typedef, could perhaps be nice anyway? >> >> The one from your linked

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Danilo Krummrich
On Thu Aug 28, 2025 at 9:36 PM CEST, Miguel Ojeda wrote: > On Thu, Aug 28, 2025 at 9:31 PM Miguel Ojeda > wrote: >> >> and a `DmaAddress` >> newtype, not just a typedef, could perhaps be nice anyway? > > The one from your linked patch is not a newtype though, so I guess > there is a reason for tha

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Danilo Krummrich
On Thu Aug 28, 2025 at 9:31 PM CEST, Miguel Ojeda wrote: > On Thu, Aug 28, 2025 at 9:24 PM Danilo Krummrich wrote: >> >> Maybe I spoke too soon, it's actually pretty painful to keep 32-bit >> compatibility, even though it would be nice for testing purposes. >> >> I'll paste the diff to fix it belo

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Miguel Ojeda
On Thu, Aug 28, 2025 at 9:31 PM Miguel Ojeda wrote: > > and a `DmaAddress` > newtype, not just a typedef, could perhaps be nice anyway? The one from your linked patch is not a newtype though, so I guess there is a reason for that. Cheers, Miguel

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Miguel Ojeda
On Thu, Aug 28, 2025 at 9:24 PM Danilo Krummrich wrote: > > Maybe I spoke too soon, it's actually pretty painful to keep 32-bit > compatibility, even though it would be nice for testing purposes. > > I'll paste the diff to fix it below, I think that makes it obvious why I say > that. > > Instead,

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Danilo Krummrich
On Thu Aug 28, 2025 at 7:54 PM CEST, Danilo Krummrich wrote: > On 8/28/25 6:02 PM, Miguel Ojeda wrote: >> Similar to another one I sent, I hope it helps -- it may be useful to make it >> build in 32-bit as a test for those kinds of platforms. > > Agreed. Maybe I spoke too soon, it's actually prett

Re: gpu: nova-core: arm32 build errors

2025-08-28 Thread Danilo Krummrich
Hi Miguel, Thanks for reporting! On 8/28/25 6:02 PM, Miguel Ojeda wrote: Hi Danilo et al., In Linus' tree and -next, for an arm32 LLVM defconfig plus Rust build, I see: error[E0308]: mismatched types --> drivers/gpu/nova-core/fb.rs:49:59 | 49 | hal::fb_hal(chi