Re: broken nouveau dependency on power supply

2012-05-05 Thread Anton Vorontsov
Hello Benjamin, Sorry, it took me some time to get to it. On Mon, Apr 02, 2012 at 01:53:23PM +1000, Benjamin Herrenschmidt wrote: [...] With CONFIG_POWER_SUPPLY=m nouveau built-in we get a build failure: drivers/built-in.o: In function `.nouveau_pm_trigger': (.text+0xa56e8): undefined

broken nouveau dependency on power supply

2012-05-04 Thread Anton Vorontsov
Hello Benjamin, Sorry, it took me some time to get to it. On Mon, Apr 02, 2012 at 01:53:23PM +1000, Benjamin Herrenschmidt wrote: [...] > > With CONFIG_POWER_SUPPLY=m & nouveau built-in we get a build failure: > > > > drivers/built-in.o: In function `.nouveau_pm_trigger': > > (.text+0xa56e8):

broken nouveau dependency on power supply

2012-04-02 Thread Benjamin Herrenschmidt
On Mon, 2012-04-02 at 05:00 -0400, David Airlie wrote: > > - Better: Just make the bloody thing a bool :-) The power supply > > framework itself is small enough, just make it a boolean option and > > avoid the problem entirely. The actual power supply sub drivers can > > remain modular of course.

broken nouveau dependency on power supply

2012-04-02 Thread Benjamin Herrenschmidt
On Mon, 2012-04-02 at 11:06 +1000, Benjamin Herrenschmidt wrote: > Hi folks ! > > With CONFIG_POWER_SUPPLY=m & nouveau built-in we get a build failure: > > drivers/built-in.o: In function `.nouveau_pm_trigger': > (.text+0xa56e8): undefined reference to `.power_supply_is_system_supplied' > >

broken nouveau dependency on power supply

2012-04-02 Thread Benjamin Herrenschmidt
Hi folks ! With CONFIG_POWER_SUPPLY=m & nouveau built-in we get a build failure: drivers/built-in.o: In function `.nouveau_pm_trigger': (.text+0xa56e8): undefined reference to `.power_supply_is_system_supplied' nouveau probably needs to depends on CONFIG_POWER_SUPPLY to force a module build

broken nouveau dependency on power supply

2012-04-02 Thread David Airlie
> > Ok, not that trivial... > > The problem is more like POWER_SUPPLY should be a bool, not a > tristate. > > If you think about it: you don't want things like nouveau to depend > on a > random subsystem like that, people will never get it. In fact, > POWER_SUPPLY provides empty inline stubs

Re: broken nouveau dependency on power supply

2012-04-02 Thread David Airlie
Ok, not that trivial... The problem is more like POWER_SUPPLY should be a bool, not a tristate. If you think about it: you don't want things like nouveau to depend on a random subsystem like that, people will never get it. In fact, POWER_SUPPLY provides empty inline stubs when not

Re: broken nouveau dependency on power supply

2012-04-02 Thread Benjamin Herrenschmidt
On Mon, 2012-04-02 at 05:00 -0400, David Airlie wrote: - Better: Just make the bloody thing a bool :-) The power supply framework itself is small enough, just make it a boolean option and avoid the problem entirely. The actual power supply sub drivers can remain modular of course. We

broken nouveau dependency on power supply

2012-04-01 Thread Benjamin Herrenschmidt
Hi folks ! With CONFIG_POWER_SUPPLY=m nouveau built-in we get a build failure: drivers/built-in.o: In function `.nouveau_pm_trigger': (.text+0xa56e8): undefined reference to `.power_supply_is_system_supplied' nouveau probably needs to depends on CONFIG_POWER_SUPPLY to force a module build with

Re: broken nouveau dependency on power supply

2012-04-01 Thread Benjamin Herrenschmidt
On Mon, 2012-04-02 at 11:06 +1000, Benjamin Herrenschmidt wrote: Hi folks ! With CONFIG_POWER_SUPPLY=m nouveau built-in we get a build failure: drivers/built-in.o: In function `.nouveau_pm_trigger': (.text+0xa56e8): undefined reference to `.power_supply_is_system_supplied' nouveau