drm/exynos: fimd: vrefresh is zero

2016-05-05 Thread Tobias Jakobi
Hello Andrzej, Andrzej Hajda wrote: > On 05/05/2016 11:12 AM, Andrzej Hajda wrote: >> >> Regarding the initial question, mode->vrefresh is set in >> drm_helper_probe_single_connector_modes. I guess division by zero could >> be caused by lack of clock in timings provided by dts timing node. >> As

drm/exynos: fimd: vrefresh is zero

2016-05-05 Thread Andrzej Hajda
On 05/05/2016 11:12 AM, Andrzej Hajda wrote: > > Regarding the initial question, mode->vrefresh is set in > drm_helper_probe_single_connector_modes. I guess division by zero could > be caused by lack of clock in timings provided by dts timing node. > As I remember in the past dts timings were

drm/exynos: fimd: vrefresh is zero

2016-05-05 Thread Andrzej Hajda
Hi Tobias, Daniel, Little late, but maybe helpful anyway... On 05/02/2016 11:00 PM, Daniel Vetter wrote: > On Mon, May 2, 2016 at 10:30 PM, Tobias Jakobi > wrote: >>> drm_mode_set_crtcinfo() is meant to be used to fill in all the derived >>> values. We might or might not want to have a default

drm/exynos: fimd: vrefresh is zero

2016-05-03 Thread Daniel Vetter
On Mon, May 2, 2016 at 10:30 PM, Tobias Jakobi wrote: >> drm_mode_set_crtcinfo() is meant to be used to fill in all the derived >> values. We might or might not want to have a default call for that in >> atomic helpers actually (before we call down into any of the driver's >> check functions for

drm/exynos: fimd: vrefresh is zero

2016-05-02 Thread Tobias Jakobi
Hey Daniel, Daniel Vetter wrote: > On Mon, May 02, 2016 at 04:30:37PM +0200, Tobias Jakobi wrote: >> Hello Alex, >> >> >> Alex Deucher wrote: >>> On Sat, Apr 30, 2016 at 5:37 PM, Tobias Jakobi >>> wrote: Hello, while playing around with FIMD enabled, I noticed that when first

drm/exynos: fimd: vrefresh is zero

2016-05-02 Thread Daniel Vetter
On Mon, May 02, 2016 at 04:30:37PM +0200, Tobias Jakobi wrote: > Hello Alex, > > > Alex Deucher wrote: > > On Sat, Apr 30, 2016 at 5:37 PM, Tobias Jakobi > > wrote: > >> Hello, > >> > >> while playing around with FIMD enabled, I noticed that when first using > >> the device a zero division was

drm/exynos: fimd: vrefresh is zero

2016-05-02 Thread Tobias Jakobi
Hello Alex, Alex Deucher wrote: > On Sat, Apr 30, 2016 at 5:37 PM, Tobias Jakobi > wrote: >> Hello, >> >> while playing around with FIMD enabled, I noticed that when first using >> the device a zero division was triggered in fimd_calc_clkdiv(). I >> remembered that I had a similar issue some

drm/exynos: fimd: vrefresh is zero

2016-05-02 Thread Alex Deucher
On Sat, Apr 30, 2016 at 5:37 PM, Tobias Jakobi wrote: > Hello, > > while playing around with FIMD enabled, I noticed that when first using > the device a zero division was triggered in fimd_calc_clkdiv(). I > remembered that I had a similar issue some time ago. > > I added a stub

drm/exynos: fimd: vrefresh is zero

2016-05-01 Thread Tobias Jakobi
Hello, while playing around with FIMD enabled, I noticed that when first using the device a zero division was triggered in fimd_calc_clkdiv(). I remembered that I had a similar issue some time ago. I added a stub fimd_atomic_check() which shows that vrefresh is zero when fimd_calc_clkdiv() is