Re: [PATCH v3] drm: document uAPI page-flip flags

2022-09-30 Thread Pekka Paalanen
On Thu, 29 Sep 2022 18:10:28 + Simon Ser wrote: > On Wednesday, September 28th, 2022 at 12:06, Pekka Paalanen > wrote: > > > > +/** > > > + * DRM_MODE_PAGE_FLIP_FLAGS > > > + * > > > + * Bitmask of flags suitable for _mode_crtc_page_flip_target.flags. > > > > Should this mention also

Re: [PATCH v3] drm: document uAPI page-flip flags

2022-09-29 Thread Sebastian Wick
On Thu, Sep 29, 2022 at 8:11 PM Simon Ser wrote: > > On Wednesday, September 28th, 2022 at 12:06, Pekka Paalanen > wrote: > > > > +/** > > > + * DRM_MODE_PAGE_FLIP_FLAGS > > > + * > > > + * Bitmask of flags suitable for _mode_crtc_page_flip_target.flags. > > > > Should this mention also

Re: [PATCH v3] drm: document uAPI page-flip flags

2022-09-29 Thread Simon Ser
On Wednesday, September 28th, 2022 at 12:06, Pekka Paalanen wrote: > > +/** > > + * DRM_MODE_PAGE_FLIP_FLAGS > > + * > > + * Bitmask of flags suitable for _mode_crtc_page_flip_target.flags. > > Should this mention also drm_mode_crtc_page_flip.flags? > > UAPI header defines both structs.

Re: [PATCH v3] drm: document uAPI page-flip flags

2022-09-28 Thread Pekka Paalanen
On Wed, 28 Sep 2022 09:41:57 + Simon Ser wrote: > Document flags accepted by the page-flip and atomic IOCTLs. > > v2 (Pekka): > - Mention DRM_EVENT_FLIP_COMPLETE in DRM_MODE_PAGE_FLIP_EVENT docs. > - Expand DRM_MODE_ATOMIC_NONBLOCK and DRM_MODE_ATOMIC_ALLOW_MODESET > description. > v3: >

[PATCH v3] drm: document uAPI page-flip flags

2022-09-28 Thread Simon Ser
Document flags accepted by the page-flip and atomic IOCTLs. v2 (Pekka): - Mention DRM_EVENT_FLIP_COMPLETE in DRM_MODE_PAGE_FLIP_EVENT docs. - Expand DRM_MODE_ATOMIC_NONBLOCK and DRM_MODE_ATOMIC_ALLOW_MODESET description. v3: - Fix struct field ref syntax (Daniel) - Clarify when artifacts are no

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Simon Ser
On Tuesday, August 30th, 2022 at 10:31, Michel Dänzer wrote: > > For the atomic uAPI, we need to pick on of these two approaches: > > > > 1. Let the kernel fall back to a sync flip if async isn't possible. This > >simplifies user-space, but then user-space has no reliable way to figure > >

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 12:00:50PM +0300, Pekka Paalanen wrote: > On Tue, 30 Aug 2022 11:41:39 +0300 > Ville Syrjälä wrote: > > > On Tue, Aug 30, 2022 at 11:16:26AM +0300, Pekka Paalanen wrote: > > > > Hence, "has been displayed" is not it because the flip-done event is > > > emitted before the

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Pekka Paalanen
On Tue, 30 Aug 2022 11:41:39 +0300 Ville Syrjälä wrote: > On Tue, Aug 30, 2022 at 11:16:26AM +0300, Pekka Paalanen wrote: > > Hence, "has been displayed" is not it because the flip-done event is > > emitted before the new FB contents have been scanned out. That scanout > > cycle is only

Re: [PATCH v2] drm: document uAPI page-flip flags

2022-08-30 Thread Pekka Paalanen
On Mon, 29 Aug 2022 15:40:01 + Simon Ser wrote: > Document flags accepted by the page-flip and atomic IOCTLs. > > v2 (Pekka): > - Mention DRM_EVENT_FLIP_COMPLETE in DRM_MODE_PAGE_FLIP_EVENT docs. > - Expand DRM_MODE_ATOMIC_NONBLOCK and DRM_MODE_ATOMIC_ALLOW_MODESET > description. > >

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 11:16:26AM +0300, Pekka Paalanen wrote: > On Mon, 29 Aug 2022 15:37:52 + > Simon Ser wrote: > > > CC Ville for the ASYNC bits, see below. > > > > On Friday, August 26th, 2022 at 10:53, Pekka Paalanen > > wrote: > > > > > > +/** > > > > + * DRM_MODE_PAGE_FLIP_EVENT

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Michel Dänzer
On 2022-08-30 10:16, Pekka Paalanen wrote: > On Mon, 29 Aug 2022 15:37:52 + > Simon Ser wrote: >> On Friday, August 26th, 2022 at 10:53, Pekka Paalanen >> wrote: >> +/** + * DRM_MODE_PAGE_FLIP_ASYNC + * + * Request that the page-flip is performed as soon as possible, ie.

Re: drm: document uAPI page-flip flags

2022-08-30 Thread Pekka Paalanen
On Mon, 29 Aug 2022 15:37:52 + Simon Ser wrote: > CC Ville for the ASYNC bits, see below. > > On Friday, August 26th, 2022 at 10:53, Pekka Paalanen > wrote: > > > > +/** > > > + * DRM_MODE_PAGE_FLIP_EVENT > > > + * > > > + * Request that the kernel sends back a vblank event (see > > > +

[PATCH v2] drm: document uAPI page-flip flags

2022-08-29 Thread Simon Ser
Document flags accepted by the page-flip and atomic IOCTLs. v2 (Pekka): - Mention DRM_EVENT_FLIP_COMPLETE in DRM_MODE_PAGE_FLIP_EVENT docs. - Expand DRM_MODE_ATOMIC_NONBLOCK and DRM_MODE_ATOMIC_ALLOW_MODESET description. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen Cc:

Re: drm: document uAPI page-flip flags

2022-08-29 Thread Simon Ser
CC Ville for the ASYNC bits, see below. On Friday, August 26th, 2022 at 10:53, Pekka Paalanen wrote: > > +/** > > + * DRM_MODE_PAGE_FLIP_EVENT > > + * > > + * Request that the kernel sends back a vblank event (see > > + * struct drm_event_vblank) when the page-flip is done. > > ...with type =

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Pekka Paalanen
On Fri, 26 Aug 2022 13:17:09 + Simon Ser wrote: > On Friday, August 26th, 2022 at 15:10, Sebastian Wick > wrote: > > > On Fri, Aug 26, 2022 at 2:17 PM Simon Ser cont...@emersion.fr wrote: > > > > > On Friday, August 26th, 2022 at 11:49, Sebastian Wick > > > sebastian.w...@redhat.com

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Simon Ser
On Friday, August 26th, 2022 at 15:10, Sebastian Wick wrote: > On Fri, Aug 26, 2022 at 2:17 PM Simon Ser cont...@emersion.fr wrote: > > > On Friday, August 26th, 2022 at 11:49, Sebastian Wick > > sebastian.w...@redhat.com wrote: > > > > > > > +/* > > > > > + * DRM_MODE_ATOMIC_ALLOW_MODESET >

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Sebastian Wick
On Fri, Aug 26, 2022 at 2:17 PM Simon Ser wrote: > > On Friday, August 26th, 2022 at 11:49, Sebastian Wick > wrote: > > > > > +/* > > > > + * DRM_MODE_ATOMIC_ALLOW_MODESET > > > > + * > > > > + * Allow the update to result in visible artifacts such as a black > > > > screen. > > > > > > Maybe

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Simon Ser
On Friday, August 26th, 2022 at 11:49, Sebastian Wick wrote: > > > +/* > > > + * DRM_MODE_ATOMIC_ALLOW_MODESET > > > + * > > > + * Allow the update to result in visible artifacts such as a black > > > screen. > > > > Maybe add: > > > > ...temporary or transient visible artifacts while the

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Sebastian Wick
On Fri, Aug 26, 2022 at 10:58 AM Pekka Paalanen wrote: > > On Wed, 24 Aug 2022 17:45:06 + > Simon Ser wrote: > > > Document flags accepted by the page-flip and atomic IOCTLs. > > > > Signed-off-by: Simon Ser > > Cc: Daniel Vetter > > --- > > include/uapi/drm/drm_mode.h | 44

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Pekka Paalanen
On Wed, 24 Aug 2022 17:45:06 + Simon Ser wrote: > Document flags accepted by the page-flip and atomic IOCTLs. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > --- > include/uapi/drm/drm_mode.h | 44 - > 1 file changed, 43 insertions(+), 1 deletion(-)

[PATCH] drm: document uAPI page-flip flags

2022-08-25 Thread Simon Ser
Document flags accepted by the page-flip and atomic IOCTLs. Signed-off-by: Simon Ser Cc: Daniel Vetter --- include/uapi/drm/drm_mode.h | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_mode.h