Re: drm_panel_get_modes() should take the connector as an argument [Was: drm/bridge: panel: Implement bridge ...]

2019-08-08 Thread Laurent Pinchart
Hi Sam, On Thu, Aug 08, 2019 at 06:52:53PM +0200, Sam Ravnborg wrote: > Hi Laurent. > > As I said in another mail, you have managed to keep me busy... > > > > I took a look at this - it seems simple: > > > - Update drm_panel.get_modes() to take drm_connector as argument, and fix > > > all

Re: drm_panel_get_modes() should take the connector as an argument [Was: drm/bridge: panel: Implement bridge ...]

2019-08-08 Thread Sam Ravnborg
Hi Laurent. As I said in another mail, you have managed to keep me busy... > > I took a look at this - it seems simple: > > - Update drm_panel.get_modes() to take drm_connector as argument, and fix > > all callers. All callers already have connector available. > > - Drop drm_panel_attach(),

Re: drm_panel_get_modes() should take the connector as an argument [Was: drm/bridge: panel: Implement bridge ...]

2019-08-08 Thread Laurent Pinchart
Hi Sam, On Tue, Jul 16, 2019 at 01:08:27PM +0200, Sam Ravnborg wrote: > Hi Laurent et all. > > > +static int panel_bridge_get_modes(struct drm_bridge *bridge, > > + struct drm_connector *connector) > > +{ > > + struct panel_bridge *panel_bridge =

drm_panel_get_modes() should take the connector as an argument [Was: drm/bridge: panel: Implement bridge ...]

2019-07-16 Thread Sam Ravnborg
Hi Laurent et all. > +static int panel_bridge_get_modes(struct drm_bridge *bridge, > + struct drm_connector *connector) > +{ > + struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge); > + > + /* > + * FIXME: drm_panel_get_modes() should