i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-05 Thread Melchior FRANZ
* Takashi Iwai -- Thursday 05 May 2011: > Try the fixed patch below. > --- > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 456f404..4c6e187 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -332,6 +332,7 @@ typedef

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-05 Thread Melchior FRANZ
* Takashi Iwai -- Thursday 05 May 2011: Try the fixed patch below. --- diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 456f404..4c6e187 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -332,6 +332,7 @@ typedef struct

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-04 Thread Joey Lee
Hi Melchior, ? ??2011-05-02 ? 14:08 +0200?Takashi Iwai ??? > At Sat, 30 Apr 2011 13:34:51 +0200, > Melchior FRANZ wrote: > > > > Dropping Linus from the CC. > > > > > > * Takashi Iwai -- Saturday 30 April 2011: > > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > > Yes,

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-04 Thread Joey Lee
Hi Melchior, 於 一,2011-05-02 於 14:08 +0200,Takashi Iwai 提到: At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: Dropping Linus from the CC. * Takashi Iwai -- Saturday 30 April 2011: * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: Yes, backlight adjustment

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Melchior FRANZ
* Takashi Iwai -- Monday 02 May 2011: * > At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Saturday 30 April 2011: > > > acpi_osi quirk should be better added statically, then. > > > > No, I guess the problem here is that acer_wmi doesn't support this > > machine

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Takashi Iwai
At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: > > Dropping Linus from the CC. > > > * Takashi Iwai -- Saturday 30 April 2011: > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > Yes, backlight adjustment generally works on this notebook, but only > > > with

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Takashi Iwai
At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: Dropping Linus from the CC. * Takashi Iwai -- Saturday 30 April 2011: * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: Yes, backlight adjustment generally works on this notebook, but only with acpi_osi=Linux on

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Melchior FRANZ
* Takashi Iwai -- Monday 02 May 2011: * At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: * Takashi Iwai -- Saturday 30 April 2011: acpi_osi quirk should be better added statically, then. No, I guess the problem here is that acer_wmi doesn't support this machine yet. Hm, but

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-01 Thread Joey Lee
Hi Melchior, 於 六,2011-04-30 於 13:34 +0200,Melchior FRANZ 提到: Dropping Linus from the CC. * Takashi Iwai -- Saturday 30 April 2011: * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: Yes, backlight adjustment generally works on this notebook, but only with acpi_osi=Linux

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
Dropping Linus from the CC. * Takashi Iwai -- Saturday 30 April 2011: * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > Yes, backlight adjustment generally works on this notebook, but only > > with "acpi_osi=Linux" on the command line. > > acpi_osi quirk should be better added

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Saturday 30 April 2011: > > I remember vaguely that the value zero could be interpreted as the max. > > > Also, with the patch, does the backlight level can be adjusted > > correctly to different values? I wonder

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
* Takashi Iwai -- Saturday 30 April 2011: > I remember vaguely that the value zero could be interpreted as the max. > Also, with the patch, does the backlight level can be adjusted > correctly to different values? I wonder whether LBPC adjustment > really works or not on your machine. > +

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Fri, 29 Apr 2011 22:09:54 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Friday 29 April 2011: > [https://bugzilla.kernel.org/show_bug.cgi?id=31522] > > Looking at bugzilla, the problem seems like the case lbpc=0. > > What about the patch below instead? > > > - val *=

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Joey Lee
Hi Melchior, ? ??2011-04-30 ? 13:34 +0200?Melchior FRANZ ??? > Dropping Linus from the CC. > > > * Takashi Iwai -- Saturday 30 April 2011: > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > Yes, backlight adjustment generally works on this notebook, but only > > > with

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Fri, 29 Apr 2011 22:09:54 +0200, Melchior FRANZ wrote: * Takashi Iwai -- Friday 29 April 2011: [https://bugzilla.kernel.org/show_bug.cgi?id=31522] Looking at bugzilla, the problem seems like the case lbpc=0. What about the patch below instead? - val *= lbpc; +

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
* Takashi Iwai -- Saturday 30 April 2011: I remember vaguely that the value zero could be interpreted as the max. Also, with the patch, does the backlight level can be adjusted correctly to different values? I wonder whether LBPC adjustment really works or not on your machine. +

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: * Takashi Iwai -- Saturday 30 April 2011: I remember vaguely that the value zero could be interpreted as the max. Also, with the patch, does the backlight level can be adjusted correctly to different values? I wonder whether

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
Dropping Linus from the CC. * Takashi Iwai -- Saturday 30 April 2011: * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: Yes, backlight adjustment generally works on this notebook, but only with acpi_osi=Linux on the command line. acpi_osi quirk should be better added

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: [https://bugzilla.kernel.org/show_bug.cgi?id=31522] > Looking at bugzilla, the problem seems like the case lbpc=0. > What about the patch below instead? > - val *= lbpc; > + if (lbpc) > +

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Takashi Iwai
At Fri, 29 Apr 2011 19:41:53 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Friday 29 April 2011: > > Melchior FRANZ wrote: > > > The bug was introduced with commit > > > ba3820ade317ee36e496b9b40d2ec3987dd4aef0 > > > [...] when using KMS my notebook's[2] screen remains dark, because the > >

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: > Melchior FRANZ wrote: > > The bug was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0 > > [...] when using KMS my notebook's[2] screen remains dark, because the > > backlight isn't turned on. > Could you check whether the patch below

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: Melchior FRANZ wrote: The bug was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0 [...] when using KMS my notebook's[2] screen remains dark, because the backlight isn't turned on. Could you check whether the patch below changes the

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Takashi Iwai
At Fri, 29 Apr 2011 19:41:53 +0200, Melchior FRANZ wrote: * Takashi Iwai -- Friday 29 April 2011: Melchior FRANZ wrote: The bug was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0 [...] when using KMS my notebook's[2] screen remains dark, because the backlight

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: [https://bugzilla.kernel.org/show_bug.cgi?id=31522] Looking at bugzilla, the problem seems like the case lbpc=0. What about the patch below instead? - val *= lbpc; + if (lbpc) + val *=