of_find_i2c_adapter_by_node() call requires quite often missing
put_device(), and i2c_put_adapter() releases a device locked by
i2c_get_adapter() only.
Below is a common error reproduction scenario as a result of the
misusage described above (this is run on iMX6 platform with
HDMI and I2C bus
This change is needed to properly lock I2C bus driver, which serves DDC.
The change fixes an overflow over zero of I2C bus driver user counter:
root at mx6q:~# lsmod | grep i2c
i2c_imx15348 0
root at mx6q:~# lsmod | grep dw_hdmi_imx
dw_hdmi_imx 3567
This change is needed to properly lock I2C bus driver, which serves DDC.
Prior to this change i2c_put_adapter() is misused, which may lead
to an overflow over zero of I2C bus driver user counter.
Signed-off-by: Vladimir Zapolskiy
---
Changes from v1 to v2:
- none
This change is needed to properly lock I2C bus driver, which serves DDC.
On release of_get_i2c_adapter_by_node() requires i2c_put_adapter() call.
Note, that prior to the change put_device() coupled with
of_find_i2c_adapter_by_node() was missing on error path of
tegra_output_probe().
On Sun, Aug 23, 2015 at 3:57 AM, Grazvydas Ignotas wrote:
> These patches try to reduce CPU usage of register command checker
> without affecting functionality.
> For me this gives 3-4% perf improvement in glxgears and ~1% CPU usage
> reduction
> in "The Talos Principle" CS thread.
>
> Grazvydas
Dear Emil,
On Wed, 02 Sep 2015 01:43:41 +0100
Emil Velikov wrote:
> On 26 August 2015 at 07:21, Hyungwon Hwang
> wrote:
> > This patch adds support for atomic page flip. User can specify -V
> > option with the plane id for testing atomic page flipping.
> > ---
> > tests/modetest/modetest.c |
Modetest gets the property name from user to set it. So the name must be
converted to its id. Until now, this is done in the set_property(). But to
support atomic modeset in modetest, this logic should be separated from the
fuction, because atomic modeset and legacy modeset use different IOCTLs.
This patch adds support for atomic modeset. Using -a option, user can
make modeset to use DRM_IOCTL_MODE_ATOMIC instead of legacy IOCTLs.
Also, by using -w option, user can set the property as before.
Signed-off-by: Hyungwon Hwang
---
tests/modetest/modetest.c | 273
This patch adds support for atomic page flip. User can specify -V option
with the plane id for testing atomic page flipping.
Signed-off-by: Hyungwon Hwang
---
tests/modetest/modetest.c | 195 --
1 file changed, 187 insertions(+), 8 deletions(-)
diff
Hi all,
After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/gpu/drm/drm_crtc.c: In function 'drm_fb_release':
drivers/gpu/drm/drm_crtc.c:3494:21: warning: unused variable 'dev'
[-Wunused-variable]
struct drm_device *dev =
Hi Andrew,
Today's linux-next merge of the akpm tree got a conflict in:
drivers/gpu/drm/drm_irq.c
between commit:
4e32087d8341 ("drm: Use vblank timestamps to guesstimate how many vblanks
were missed")
from the drm-misc tree and patch:
"Remove abs64()"
from the akpm tree.
I fixed
https://bugzilla.kernel.org/show_bug.cgi?id=104881
Bug ID: 104881
Summary: AMDGPU FIJI doesn't support higher resolutions past
1920x1080
Product: Drivers
Version: 2.5
Kernel Version: 4.3.0-rc2-1.g2b75354-desktop
https://bugzilla.kernel.org/show_bug.cgi?id=104881
--- Comment #1 from Jeff Nelson ---
Created attachment 188121
--> https://bugzilla.kernel.org/attachment.cgi?id=188121=edit
Xorg.0.log
--
You are receiving this mail because:
You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=104881
--- Comment #2 from Jeff Nelson ---
Created attachment 188131
--> https://bugzilla.kernel.org/attachment.cgi?id=188131=edit
dmesg
--
You are receiving this mail because:
You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=104881
Jeff Nelson changed:
What|Removed |Added
Hardware|Other |x86-64
--
You are receiving this mail
On 23 September 2015 at 09:03, Grazvydas Ignotas wrote:
> On Sun, Aug 23, 2015 at 3:57 AM, Grazvydas Ignotas
> wrote:
>> These patches try to reduce CPU usage of register command checker
>> without affecting functionality.
>> For me this gives 3-4% perf improvement in glxgears and ~1% CPU usage
On Thu, Aug 27, 2015 at 04:43:43PM +0200, Lukas Wunner wrote:
> The active attribute in struct vga_switcheroo_client denotes whether
> the outputs are currently switched to this client. The attribute is
> only meaningful for vga clients. It is never used for audio clients.
>
> The function
Adding Jairo to track this regression.
-Daniel
On Wed, Sep 23, 2015 at 08:23:04AM +0200, Sedat Dilek wrote:
> On Sun, Sep 13, 2015 at 9:06 AM, Sedat Dilek wrote:
> > On Wed, Sep 9, 2015 at 4:42 AM, Sedat Dilek
> > wrote:
> >> [ TO INTEL DRM DRIVERS maintainers ]
> >>
> >> Hi,
> >>
> >> out of
On Tue, Sep 22, 2015 at 04:54:54PM -0400, Alex Deucher wrote:
> On Tue, Sep 22, 2015 at 4:21 PM, Borislav Petkov wrote:
> > Hi Alex,
> >
> > On Tue, Sep 22, 2015 at 03:58:03PM -0400, Alex Deucher wrote:
> >> What system is this?
> >
> > my workstation - an
> >
> > "To be filled by O.E.M. To be
Hi Matt, Daniel
Addressing the review comments from both of you here.
Regards
Shashank
On 9/22/2015 6:32 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 10:51:31AM -0700, Matt Roper wrote:
>> On Wed, Sep 16, 2015 at 11:06:59PM +0530, Shashank Sharma wrote:
>>> From: Kausal Malladi
>>>
>>>
Regards
Shashank
On 9/22/2015 6:38 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> This patch adds new structures in DRM layer for Palette color
>> correction.These structures will be used by user space agents
>> to
Regards
Shashank
On 9/22/2015 6:38 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:02PM +0530, Shashank Sharma wrote:
>> From: Kausal Malladi
>>
>> Color Manager framework defines a color correction property for color
>> space transformation and Gamut mapping. This property is called
-devel/attachments/20150923/84dca1de/attachment-0001.html>
Regards
Shashank
On 9/22/2015 6:45 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote:
>> I915 driver registers gamma correction as palette correction
>> property with DRM layer. This patch adds set_property() and get_property()
>> handlers for pipe level
Regards
Shashank
On 9/22/2015 6:54 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:07:06PM +0530, Shashank Sharma wrote:
>> DRM color manager contains these color properties:
>>
>> 1. "crtc_palette_capabilities_property": to allow a
>> core driver to load and showcase its color correction
Regards
Shashank
On 9/22/2015 6:57 PM, Daniel Vetter wrote:
> On Wed, Sep 16, 2015 at 11:06:57PM +0530, Shashank Sharma wrote:
>> This patch set adds Color Manager implementation in DRM layer. Color Manager
>> is an extension in DRM framework to support color correction/enhancement.
>>
>> Various
Sure Matt,
We are planning to add documentation for color properties, as suggested by you
and Daniel.
Regards
Shashank
-Original Message-
From: Roper, Matthew D
Sent: Wednesday, September 16, 2015 11:21 PM
To: Sharma, Shashank
Cc: Bish, Jim; Bradford, Robert; Smith, Gary K; dri-devel
On Wed, Sep 23, 2015 at 09:25:23AM +0200, Daniel Vetter wrote:
> Strange thing is that I've tested this on a radeon over here and I don't
> see this backtrace ... wut. Below diff should appease the backtraces at
> least.
Doesn't look like it.
This is what it says when suspending:
[
:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150923/f3ec4b71/attachment.html>
>
> The size calculation can overflow. I don't know if this leads to
> memory corruption, but it causes a static checker warning.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: I don't know think the size is capped anywhere. In my first version
> of this patch, I introduced a divide by zero
The amdgpu_cs_parser_init() function doesn't clean up after itself but
instead the caller uses a free everything function amdgpu_cs_parser_fini()
on failure. This style of error handling is often buggy. In this
example, we call "drm_free_large(parser->chunks[i].kdata);" when it is
an
The "alloc_size" calculation can overflow leading to memory corruption.
Reported-by: Ilja Van Sprundel
Signed-off-by: Dan Carpenter
---
The amdgpu_asic_read_register() functions seem likely to be slow. They
iterate through all the registers to find the correct register to read.
diff --git
There is no limit on args->data.data_size_bytes so we could read beyond
the end of the args->data.data[] array.
Reported-by: Ilja Van Sprundel
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 5839fab..dac14de
args->size is a u64. arg->pitch and args->height are u32. The
multiplication will overflow instead of using the high 32 bits as
intended.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index dac14de..2023055 100644
On Wed, Sep 23, 2015 at 10:10:31AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> __u64 should be used instead of u64.
>
> Feature originally added in:
>
> commit e3eb3250d84ef97b766312345774367b6a310db8
> Author: Rob Clark
> Date: Thu Feb 5 14:41:52 2015 +
>
> drm: add
This would be an interface/design change, to change from one blob of correction
property, to split into multiple query properties for palette_before_blob and
palette_after_blob.
Please let me know if this is really required ?
Regards
Shashank
-Original Message-
From: Smith, Gary K
HI!
I suspended T40p by mistake, and I got some lovely backtraces as a
result:
Any ideas?
Pavel
[0.00] Initializing cgroup subsys cpu
[0.00] Linux version 4.3.0-rc2+ (pavel at hobit) (gcc version 4.9.2
(Debian
On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote:
> Regards
> Shashank
>
> On 9/22/2015 6:38 PM, Daniel Vetter wrote:
> >On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote:
> >>From: Kausal Malladi
> >>
> >>This patch adds new structures in DRM layer for Palette
On Wed, Sep 23, 2015 at 02:05:25PM +0530, Sharma, Shashank wrote:
> Regards
> Shashank
>
> On 9/22/2015 6:54 PM, Daniel Vetter wrote:
> >On Wed, Sep 16, 2015 at 11:07:06PM +0530, Shashank Sharma wrote:
> >>DRM color manager contains these color properties:
> >>
> >>1.
Regards
Shashank
On 9/23/2015 6:19 PM, Daniel Vetter wrote:
> On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote:
>> Regards
>> Shashank
>>
>> On 9/22/2015 6:38 PM, Daniel Vetter wrote:
>>> On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote:
From: Kausal Malladi
On Wed, Sep 23, 2015 at 01:52:21PM +0530, Sharma, Shashank wrote:
> Regards
> Shashank
>
> On 9/22/2015 6:45 PM, Daniel Vetter wrote:
> >On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote:
> >>I915 driver registers gamma correction as palette correction
> >>property with DRM layer.
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20150923/f786fc03/attachment.html>
On Wed, Sep 23, 2015 at 11:57:58AM +, Sharma, Shashank wrote:
> This would be an interface/design change, to change from one blob of
> correction property, to split into multiple query properties for
> palette_before_blob and palette_after_blob. Please let me know if this
> is really required
On Wed, Sep 23, 2015 at 06:29:31PM +0530, Sharma, Shashank wrote:
> Regards
> Shashank
>
> On 9/23/2015 6:19 PM, Daniel Vetter wrote:
> >On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote:
> >>Regards
> >>Shashank
> >>
> >>On 9/22/2015 6:38 PM, Daniel Vetter wrote:
> >>>On Wed, Sep
The variable dev was not used anywhere.
Signed-off-by: Sudip Mukherjee
---
drivers/gpu/drm/drm_crtc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 9d55c0c..e600a5f 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++
art --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150923/89edf304/attachment.html>
||
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150923/96413d48/attachment.html>
art --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150923/a5a90c60/attachment.html>
art --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150923/e1b1c506/attachment.html>
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20150923/fdfcb68c/attachment-0001.html>
On Wed, Sep 23, 2015 at 10:59:51AM +0200, Borislav Petkov wrote:
> On Wed, Sep 23, 2015 at 09:25:23AM +0200, Daniel Vetter wrote:
> > Strange thing is that I've tested this on a radeon over here and I don't
> > see this backtrace ... wut. Below diff should appease the backtraces at
> > least.
>
>
On 23.09.2015 12:59, Dan Carpenter wrote:
> The amdgpu_cs_parser_init() function doesn't clean up after itself but
> instead the caller uses a free everything function amdgpu_cs_parser_fini()
> on failure. This style of error handling is often buggy. In this
> example, we call
On Wed, Sep 23, 2015 at 7:51 AM, Pavel Machek wrote:
> HI!
>
>
> I suspended T40p by mistake, and I got some lovely backtraces as a
> result:
>
> Any ideas?
Please see this thread:
https://lkml.org/lkml/2015/9/23/361
Alex
>
>
https://bugzilla.kernel.org/show_bug.cgi?id=102401
--- Comment #12 from Alex Deucher ---
I don't see what this patch changes.
--
You are receiving this mail because:
You are watching the assignee of the bug.
On Wed, Sep 23, 2015 at 04:44:50PM +0200, Daniel Vetter wrote:
> sorry I sprinkled the locking stuff in the wrong places. Still confused
> why the resume side doesn't blow up anywhere
But it does:
[ 69.394204] BUG: unable to handle kernel NULL pointer dereference at
0034
[
On Wed, Sep 23, 2015 at 06:06:21PM +0200, Borislav Petkov wrote:
> On Wed, Sep 23, 2015 at 04:44:50PM +0200, Daniel Vetter wrote:
> > sorry I sprinkled the locking stuff in the wrong places. Still confused
> > why the resume side doesn't blow up anywhere
>
> But it does:
>
> [ 69.394204] BUG:
This patch set implements support for i2s audio and new AMD GPUs.
The i2s codec is fed by a DMA engine on the GPU. To handle this
we create mfd cells which we hang the i2s codec and DMA engine on.
Because of this, this patch set covers two subsystems: drm and alsa.
The drm patches add support for
This patch set implements support for i2s audio and new AMD GPUs.
The i2s codec is fed by a DMA engine on the GPU. To handle this
we create mfd cells which we hang the i2s codec and DMA engine on.
Because of this, this patch set covers two subsystems: drm and alsa.
The drm patches add support for
From: Maruthi Srinivas Bayyavarapu
dw i2s controller can work in slave mode, codec being master.
Added a device caps (DW_I2S_SLAVE) to support slave mode operation.
This can be added to platform data to support slave mode.
Signed-off-by: Maruthi Bayyavarapu
---
From: Maruthi Srinivas Bayyavarapu
Vendor specific quirk was added to:
1. Support AMD platform which has two dwc controllers with different
base address for playback and capture. Also, I2S_COMP_PARAM_*
registers offsets differed.
2. Resume audio which was
From: Maruthi Bayyavarapu
This adds the ACP (Audio CoProcessor) IP driver and wires
it up to the amdgpu driver. The ACP block provides the DMA
engine for i2s based ALSA driver. This is required for audio
on APUs that utilize an i2s codec.
Reviewed-by: Jammy Zhou
From: Maruthi Srinivas Bayyavarapu
ACP IP block consists of dedicated DMA and I2S blocks. The PCM driver
provides the platform DMA component to ALSA core.
Signed-off-by: Maruthi Bayyavarapu
Reviewed-by: Alex Deucher
Reviewed-by: Murali Krishna Vemuri
---
v2:
On Wed, Sep 23, 2015 at 10:16 AM, Christian König
wrote:
> On 23.09.2015 12:59, Dan Carpenter wrote:
>>
>> The amdgpu_cs_parser_init() function doesn't clean up after itself but
>> instead the caller uses a free everything function amdgpu_cs_parser_fini()
>> on failure. This style of error
In
commit 7a3f3d6667f5f9ffd1517f6b21d64bbf5312042c
Author: Daniel Vetter
Date: Thu Jul 9 23:44:28 2015 +0200
drm: Check locking in drm_for_each_connector
I added locking checks to drm_for_each_connector but failed that
through drm_helper_connector_dpms -> drm_helper_choose_encoder_dpms
Only briefly skimmed over the patches, but the approach sounds sane to me.
So the set is Acked-by: Christian König
Regards,
Christian.
On 23.09.2015 19:02, Alex Deucher wrote:
> This patch set implements support for i2s audio and new AMD GPUs.
> The i2s codec is fed by a DMA engine on the
I've been reading up on the device model and studying kernel sources for the
last couple of days, but I can't figure out how to get a pointer to the
radeon_device struct for a specific card, or the parent drm_device from an
external device driver.
I imagine I somehow need to take a reference
Hi Dave,
radeon and amdgpu fixes for 4.3. It's a bit bigger than usual since
it's 3 weeks worth of fixes since I was on vacation, then at XDC.
- lots of stability fixes
- suspend and resume fixes
- GPU scheduler fixes
- Misc other fixes
The following changes since commit
On Sat, Sep 5, 2015 at 5:17 AM, Lukas Wunner wrote:
> Currently everyone and their dog has their own favourite spelling
> for vga_switcheroo. This makes it hard to grep dmesg for log entries
> relating to vga_switcheroo. It also makes it hard to find related
> source files in the tree.
>
>
On Wed, Sep 23, 2015 at 2:59 AM, Dave Airlie wrote:
> On 23 September 2015 at 09:03, Grazvydas Ignotas wrote:
>> On Sun, Aug 23, 2015 at 3:57 AM, Grazvydas Ignotas
>> wrote:
>>> These patches try to reduce CPU usage of register command checker
>>> without affecting functionality.
>>> For me
From: Tvrtko Ursulin
__u64 should be used instead of u64.
Feature originally added in:
commit e3eb3250d84ef97b766312345774367b6a310db8
Author: Rob Clark
Date: Thu Feb 5 14:41:52 2015 +
drm: add support for tiled/compressed/etc modifier in addfb2
Hey,
Dave Jones schreef op di 22-09-2015 om 21:49 [-0400]:
> On Tue, Sep 22, 2015 at 09:15:58AM -0700, Matt Roper wrote:
> > On Tue, Sep 22, 2015 at 05:13:55PM +0200, Daniel Vetter wrote:
> > > On Tue, Sep 22, 2015 at 08:00:17AM -0700, Jesse Barnes wrote:
> > > > Cc'ing Maarten and Matt; I'm
On Sun, Sep 13, 2015 at 9:06 AM, Sedat Dilek wrote:
> On Wed, Sep 9, 2015 at 4:42 AM, Sedat Dilek wrote:
>> [ TO INTEL DRM DRIVERS maintainers ]
>>
>> Hi,
>>
>> out of curiosity and to play with the new bindeb-pkg make-target I
>> built pre-v4.3-rc1 (git-describe says v4.2-10463-g9a9952bbd76a)
Given that its only one word of info per LUT, I'm OK with it being two separate
properties.
I believe it was much more complex previously with a lot more info per LUT,
which is probably why I preferred a blob.
Thanks
Gary
-Original Message-
From: Sharma, Shashank
Sent: Wednesday,
From: Tvrtko Ursulin
__u64 should be used instead of u64.
Kernel headers originally pulled in:
commit 8983fe5497e89a3ffaba3ad1ee06a30a1c7e6daf
Author: Tvrtko Ursulin
Date: Mon Aug 3 10:48:03 2015 +0100
libdrm: Add framebuffer modifiers uapi
Signed-off-by:
74 matches
Mail list logo