[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #16 from Richard Thier --- Btw I now have no problems at all... This is weird... all I did was to remove my printfs so that code is actually stock mesa and I both see the speed gain and there is no problems whatsoever... But I

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #15 from Richard Thier --- (In reply to cosiekvfj from comment #14) > Created attachment 144524 [details] > bigger glxgears window > > >Is HyperZ just good without any changes to stock mesa? > yes, mesa is from manjaro repo, and I

Re: [PATCH v2 2/2] drm/komeda: Adds komeda_kms_drop_master

2019-06-13 Thread Liviu Dudau
On Thu, Jun 13, 2019 at 10:17:27AM +0200, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 02:26:24AM +, james qian wang (Arm Technology > China) wrote: > > On Tue, Jun 11, 2019 at 02:30:38PM +0200, Daniel Vetter wrote: > > > On Tue, Jun 11, 2019 at 11:13:45AM +, Lowry Li (Arm Technology

Re: [GIT,PULL] mediatek drm fixes for 5.2

2019-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2019 at 02:31:18PM +0800, CK Hu wrote: > Hi, Daniel: > > On Wed, 2019-06-12 at 18:25 +0200, Daniel Vetter wrote: > > On Wed, Jun 12, 2019 at 03:51:08PM +0800, CK Hu wrote: > > > Hi Dave, Daniel: > > > > > > This include unbind error fix, clock control flow refinement, and PRIME >

Re: [PATCH] drm/amd/display: fix compilation error

2019-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2019 at 08:18:54AM +0530, Hariprasad Kelam wrote: > On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > > wrote: > > > > > > this patch fixes below compilation error > > > > > >

[Bug 110907] Xorg 1.19.6 segfaults at address 0x6d with mesa 19.1

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110907 --- Comment #1 from Michel Dänzer --- [ 4.187] (EE) 3: /opt/mesa-latest/x86_64/radeonsi_dri.so (0x7f5f52ac+0x1b9335) [0x7f5f52c79335] [ 4.187] (EE) 4: /usr/lib/x86_64-linux-gnu/dri/radeonsi_dri.so (0x7f5f4528c000+0x264dce)

Re: [RESEND PATCH V3] drm/drm_vblank: Change EINVAL by the correct errno

2019-06-13 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 11:10:54PM -0300, Rodrigo Siqueira wrote: > For historical reason, the function drm_wait_vblank_ioctl always return > -EINVAL if something gets wrong. This scenario limits the flexibility > for the userspace make detailed verification of the problem and take > some action.

[Bug 110907] Xorg 1.19.6 segfaults at address 0x6d with mesa 19.1

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110907 Michel Dänzer changed: What|Removed |Added Attachment #144525|text/x-log |text/plain mime type|

Re: [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave

2019-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2019 at 08:45:49AM +0200, Thomas Zimmermann wrote: > Acked-by: Thomas Zimmermann Thanks for taking a look, pushed to drm-misc-next. -Daniel > > Am 12.06.19 um 11:12 schrieb Daniel Vetter: > > ast doesn't implement the mode_set_base_atomic hook this would need, > > so this is

Re: [PATCH v2 2/2] drm/komeda: Adds komeda_kms_drop_master

2019-06-13 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 02:26:24AM +, james qian wang (Arm Technology China) wrote: > On Tue, Jun 11, 2019 at 02:30:38PM +0200, Daniel Vetter wrote: > > On Tue, Jun 11, 2019 at 11:13:45AM +, Lowry Li (Arm Technology China) > > wrote: > > > From: "Lowry Li (Arm Technology China)" > > > >

[Bug 110795] Unable to install on latest Ubuntu (19.04)

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110795 Andre Klapper changed: What|Removed |Added Resolution|WONTFIX |INVALID --- Comment #17 from Andre

Re: [PATCH v10 02/11] drm/sun4i: dsi: Update start value in video start delay

2019-06-13 Thread Jagan Teki
On Fri, May 31, 2019 at 12:23 AM Maxime Ripard wrote: > > On Fri, May 24, 2019 at 03:55:42PM +0530, Jagan Teki wrote: > > On Fri, May 24, 2019 at 2:07 AM Maxime Ripard > > wrote: > > > > > > On Mon, May 20, 2019 at 02:33:09PM +0530, Jagan Teki wrote: > > > > start value in video start delay

Re: [PATCH 09/10] drm/vkms: totally reworked crc data tracking

2019-06-13 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 10:46:28AM -0300, Rodrigo Siqueira wrote: > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > The crc computation worker needs to be able to get at some data > > structures and framebuffer mappings, while potentially more atomic > > updates are going on. The

Re: [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2019 at 09:53:55AM +0200, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 10:42:42AM -0300, Rodrigo Siqueira wrote: > > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > > > Currently we flush pending crc workers very late in the commit flow, > > > when we destry all the

Re: [PATCH v10 09/11] drm/sun4i: sun6i_mipi_dsi: Add VCC-DSI regulator support

2019-06-13 Thread Jagan Teki
On Mon, Jun 3, 2019 at 7:19 PM Maxime Ripard wrote: > > On Mon, May 20, 2019 at 02:33:16PM +0530, Jagan Teki wrote: > > Allwinner MIPI DSI controllers are supplied with SoC > > DSI power rails via VCC-DSI pin. > > > > Add support for this supply pin by adding voltage > > regulator handling code

Re: [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-13 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 10:42:42AM -0300, Rodrigo Siqueira wrote: > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > Currently we flush pending crc workers very late in the commit flow, > > when we destry all the old crtc states. Unfortunately at that point > > destry -> destroy > >

Re: [PATCH v5] drm/vc4: fix fb references in async update

2019-06-13 Thread Greg KH
On Mon, Jun 10, 2019 at 10:18:59AM -0300, Helen Koike wrote: > commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream. > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which

Re: [PATCH] drm: don't block fb changes for async plane updates

2019-06-13 Thread Greg KH
On Mon, Jun 10, 2019 at 10:36:27AM -0300, Helen Koike wrote: > commit 89a4aac0ab0e6f5eea10d7bf4869dd15c3de2cd4 upstream. > > In the case of a normal sync update, the preparation of framebuffers (be > it calling drm_atomic_helper_prepare_planes() or doing setups with > drm_framebuffer_get()) are

Re: [PATCH 03/10] drm/vkms: Rename vkms_output.state_lock to crc_lock

2019-06-13 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 10:38:23AM -0300, Rodrigo Siqueira wrote: > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > Plus add a comment about what it actually protects. It's very little. > > > > Signed-off-by: Daniel Vetter > > Cc: Rodrigo Siqueira > > Cc: Haneen Mohammed > > Cc:

Re: [PATCH v3, 09/27] drm/mediatek: add mutex sof register offset into ddp private data

2019-06-13 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-06-05 at 19:42 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > mutex sof register offset will be private data of ddp > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 13 ++--- > 1 file changed, 10

[Bug 110822] [Bisected]Booting with kernel version 5.1.0 or higher on RX 580 hangs

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110822 --- Comment #20 from Gobinda Joy --- (In reply to Alex Deucher from comment #19) > (In reply to Gobinda Joy from comment #18) > > > > What I don't get is why they are using 2 calls to get the bandwidth reading. > > Since both function walking

[Bug 203879] hard freeze on high single threaded load when Xorg is active (AMD Ryzen 7 2700X CPU, AMD Radeon RX 580 GPU)

2019-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203879 --- Comment #2 from Michel Dänzer (mic...@daenzer.net) --- That sounds like a general CPU related stability issue, not directly related to the amdgpu driver. -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 110906] [Regression 5.2-rc4] Frozen screen with `Memory manager not clean during takedown.`

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110906 Michel Dänzer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

[Bug 110783] Mesa 19.1 rc crashing MPV with VAAPI

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110783 --- Comment #12 from Gert Wollny --- I might add that the DIV is lowered in glsl to RCP+MUL before it is translated to TGSI, so no need for it there. When I look at the bicubic shader with the offending opcodes, I have to say that using DIV

[Bug 110883] [Regression linux 5.2-rc4][bisected] hang on boot

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110883 --- Comment #8 from Michel Dänzer --- *** Bug 110906 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing

[Bug 99970] DRI3 steam login window is empty

2019-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99970 --- Comment #8 from Michel Dänzer --- (In reply to cosiekvfj from comment #7) > Is is worth to try to fix DRI3 and EXA for this driver or is it better to > stick to DRI2? I'd say the latter. -- You are receiving this mail because: You are the

[PATCH v3 5/9] drm/ast: Pin framebuffer BO during dirty update

2019-06-13 Thread Thomas Zimmermann
Another explicit lock operation of a GEM VRAM BO is located in AST's framebuffer update code. Instead of locking the BO, we pin it to wherever it is. v2: * update with pin flag of 0 Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_fb.c | 33 -

[PATCH v3 3/9] drm/ast: Remove obsolete or unused cursor state

2019-06-13 Thread Thomas Zimmermann
The ast driver's data structures store unused or uncecessary cursor state. Most of the cursor state is already stored elsewhere and can be retrieved when necessary. Remove the obsolete fields and adapt users accordingly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 7

[PATCH v3 4/9] drm/ast: Pin and map cursor source BO during update

2019-06-13 Thread Thomas Zimmermann
The ast driver used to lock the cursor source BO during updates. Locking should be done internally by the BO's implementation, so we pin it instead to system memory. The mapping information is also stored in the BO. No need to have an extra argument to the kmap function. v2: * pin cursor

[PATCH v3 9/9] drm: Remove functions with kmap-object argument from GEM VRAM helpers

2019-06-13 Thread Thomas Zimmermann
The GEM VRAM functions with kmap-object argument are not requried any longer. Remove them. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 50 +-- include/drm/drm_gem_vram_helper.h | 4 --- 2 files changed, 8 insertions(+), 46

[PATCH v3 1/9] drm/gem-vram: Support pinning buffers to current location

2019-06-13 Thread Thomas Zimmermann
Pinning a buffer prevents it from being moved to a different memory location. For some operations, such as buffer updates, it is not important where the buffer is located. Setting the pin function's pl_flag argument to 0 will pin the buffer to whereever it is stored. v2: * document pin

Re: [PATCH v17 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-06-13 Thread Catalin Marinas
On Wed, Jun 12, 2019 at 01:30:36PM +0100, Szabolcs Nagy wrote: > On 12/06/2019 12:43, Andrey Konovalov wrote: > > --- /dev/null > > +++ b/tools/testing/selftests/arm64/tags_lib.c > > @@ -0,0 +1,62 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include > > +#include > > + > > +#define

[PATCH v5 01/15] drm/bridge: tc358767: Simplify tc_poll_timeout()

2019-06-13 Thread Andrey Smirnov
Implementation of tc_poll_timeout() is almost a 100% copy-and-paste of the code for regmap_read_poll_timeout(). Replace copied code with a call to the original. While at it change tc_poll_timeout to accept "struct tc_data *" instead of "struct regmap *" for brevity. No functional change intended.

[PATCH v3 8/9] drm: Remove lock interfaces from GEM VRAM helpers

2019-06-13 Thread Thomas Zimmermann
The lock functions and the locked-pin/unpin functions of GEM VRAM are not requried any longer. Remove them. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 109 -- include/drm/drm_gem_vram_helper.h | 5 -- 2 files changed, 114

[PATCH v3 0/9] Remove explicit locking and kmap arguments from GEM VRAM interface

2019-06-13 Thread Thomas Zimmermann
Drivers should not have to care about internal locking of GEM VRAM objects and their memory-mapping structures. This patch set removes both from the GEM VRAM interface. This affects the ast and mgag200 drivers. In places where GEM objects are being locked by the driver, the patch converts the

Re: [PATCH v4 18/28] docs: convert docs to ReST and rename to *.rst

2019-06-13 Thread Srivatsa S. Bhat
On 6/12/19 10:52 AM, Mauro Carvalho Chehab wrote: > Convert the PM documents to ReST, in order to allow them to > build with Sphinx. > > The conversion is actually: > - add blank lines and identation in order to identify paragraphs; > - fix tables markups; > - add some lists markups; > -

[PATCH v3 2/9] drm/ast: Unpin cursor BO during cleanup

2019-06-13 Thread Thomas Zimmermann
The unpin operation was missing from ast_cursor_fini(). Fixed now. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index fb700d620b64..41741cd6cd15 100644 ---

[PATCH v3 7/9] drm/mgag200: Rewrite cursor handling

2019-06-13 Thread Thomas Zimmermann
The cursor handling in mgag200 is complicated to understand. It touches a number of different BOs, but doesn't really use all of them. Rewriting the cursor update reduces the amount of cursor state. There are two BOs for double-buffered HW updates. The source BO updates the one that is currently

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > From: Catalin Marinas > > It is not desirable to relax the ABI to allow tagged user addresses into > the kernel indiscriminately. This patch introduces a prctl() interface > for enabling or disabling the tagged ABI with a global sysctl control > for

[PATCH v3 6/9] drm/mgag200: Pin framebuffer BO during dirty update

2019-06-13 Thread Thomas Zimmermann
Another explicit lock operation of a GEM VRAM BO is located in mgag200's framebuffer update code. Instead of locking the BO, we pin it to wherever it is. v2: * update with pin flag of 0 Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_fb.c | 27

[PATCH v17 13/15] tee/shm, arm64: untag user pointers in tee_shm_register

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. tee_shm_register()->optee_shm_unregister()->check_mem_type() uses provided user pointers for vma lookups (via

Re: [PATCH v17 06/15] mm, arm64: untag user pointers in get_vaddr_frames

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > get_vaddr_frames uses provided user pointers for vma lookups,

Re: [PATCH 12/13] drm/i2c: tda998x: add bridge timing information

2019-06-13 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 7:04 AM Russell King wrote: > > Add bridge timing information so that bridge users can figure out the > timing parameters that are necessary for TDA998x. > > Signed-off-by: Russell King > --- +static const struct drm_bridge_timings tda9989_timings = { +

[PATCH v17 05/15] mm, arm64: untag user pointers in mm/gup.c

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. mm/gup.c provides a kernel interface that accepts user addresses and manipulates user pages directly (for example

Re: [PATCH v17 07/15] fs, arm64: untag user pointers in copy_mount_options

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > In copy_mount_options a user address is being subtracted from

Re: [PATCH 04/13] drm/i2c: tda998x: derive CTS_N value from aclk sample rate ratio

2019-06-13 Thread Sven Van Asbroeck
On Wed, Jun 12, 2019 at 12:42 PM Russell King - ARM Linux admin wrote: > > I think you're confusing tda998x_derive_cts_n() and tda998x_get_adiv(). > tda998x_derive_cts_n() only returns 0 or -EINVAL. > True. Apologies for the confusion. ___ dri-devel

[PATCH v4 0/3] Improve the dma-buf tracking

2019-06-13 Thread Chenbo Feng
Currently, all dma-bufs share the same anonymous inode. While we can count how many dma-buf fds or mappings a process has, we can't get the size of the backing buffers or tell if two entries point to the same dma-buf. And in debugfs, we can get a per-buffer breakdown of size and reference count,

Re: [PATCH v17 05/15] mm, arm64: untag user pointers in mm/gup.c

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > mm/gup.c provides a kernel interface that accepts user

Re: [PATCH 03/13] drm/i2c: tda998x: improve programming of audio divisor

2019-06-13 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 7:02 AM Russell King wrote: > > Improve the selection of the audio clock divisor so that more modes > and sample rates work. > > Signed-off-by: Russell King > --- +static u8 tda998x_get_adiv(struct tda998x_priv *priv, unsigned int fs) +{ + unsigned long

Re: [PATCH 00/13] tda998x updates

2019-06-13 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 7:01 AM Russell King - ARM Linux admin wrote: > > This series represents development work collected over the last six > months to improve the TDA998x driver, particularly for the audio > side. These patches can be found in my "drm-tda998x-devel" branch > at

Re: [PATCH v17 02/15] lib, arm64: untag user pointers in strn*_user

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > strncpy_from_user and strnlen_user accept user addresses as

Re: [PATCH v2 hmm 02/11] mm/hmm: Use hmm_mirror not mm as an argument for hmm_range_register

2019-06-13 Thread Jason Gunthorpe
On Wed, Jun 12, 2019 at 12:12:34AM -0700, Christoph Hellwig wrote: > On Tue, Jun 11, 2019 at 04:44:31PM -0300, Jason Gunthorpe wrote: > > On Sat, Jun 08, 2019 at 01:54:25AM -0700, Christoph Hellwig wrote: > > > FYI, I very much disagree with the direction this is moving. > > > > > > struct

[PATCH v17 08/15] userfaultfd, arm64: untag user pointers

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. userfaultfd code use provided user pointers for vma lookups, which can only by done with untagged pointers. Untag

Re: [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

2019-06-13 Thread Andrey Konovalov
On Tue, Jun 11, 2019 at 7:39 PM Catalin Marinas wrote: > > On Tue, Jun 11, 2019 at 07:09:46PM +0200, Andrey Konovalov wrote: > > On Tue, Jun 11, 2019 at 4:57 PM Catalin Marinas > > wrote: > > > > > > On Mon, Jun 10, 2019 at 06:53:27PM +0100, Catalin Marinas wrote: > > > > On Mon, Jun 03, 2019

Re: [PATCH 08/13] drm/i2c: tda998x: move audio routing configuration

2019-06-13 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 7:02 AM Russell King wrote: > > Move the mux and clocking selection out of tda998x_configure_audio() > into the parent functions, so we can validate this when parameters > are set outside of the audio mutex. > > Signed-off-by: Russell King > --- +/* Configure the TDA998x

Re: [PATCH 09/13] drm/i2c: tda998x: clean up tda998x_configure_audio()

2019-06-13 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 7:02 AM Russell King wrote: > > tda998x_configure_audio() is called via some paths where an error > return is meaningless, and as a result of moving the audio routing > code, this function no longer returns any errors, so let's make it > void. We can also make

[PATCH v17 11/15] IB/mlx4, arm64: untag user pointers in mlx4_get_umem_mr

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. mlx4_get_umem_mr() uses provided user pointers for vma lookups, which can only by done with untagged pointers.

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Catalin Marinas
On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > From: Catalin Marinas > > It is not desirable to relax the ABI to allow tagged user addresses into > the kernel indiscriminately. This patch introduces a prctl() interface > for enabling or disabling the tagged ABI with a global

Re: [PATCH v17 04/15] mm, arm64: untag user pointers passed to memory syscalls

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > This patch allows tagged pointers to be passed to the

[PATCH v17 12/15] media/v4l2-core, arm64: untag user pointers in videobuf_dma_contig_user_get

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. videobuf_dma_contig_user_get() uses provided user pointers for vma lookups, which can only by done with untagged

[PATCH] drm/amd/display: fix compilation error

2019-06-13 Thread Hariprasad Kelam
this patch fixes below compilation error drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function ‘dcn10_apply_ctx_for_surface’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function ‘udelay’

[PATCH v4 3/3] dma-buf: add show_fdinfo handler

2019-06-13 Thread Chenbo Feng
From: Greg Hackmann The show_fdinfo handler exports the same information available through debugfs on a per-buffer basis. Signed-off-by: Greg Hackmann Signed-off-by: Chenbo Feng --- drivers/dma-buf/dma-buf.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH v17 07/15] fs, arm64: untag user pointers in copy_mount_options

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In copy_mount_options a user address is being subtracted from TASK_SIZE. If the address is lower than TASK_SIZE, the

[PATCH v17 09/15] drm/amdgpu, arm64: untag user pointers

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In amdgpu_gem_userptr_ioctl() and amdgpu_amdkfd_gpuvm.c/init_user_pages() an MMU notifier is set up with a (tagged)

[PATCH v17 01/15] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. copy_from_user (and a few other similar functions) are used to copy data from user memory into the kernel memory or

[PATCH v17 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. This patch adds a simple test, that calls the uname syscall with a tagged user pointer as an argument. Without the

Re: [PATCH 01/13] drm/i2c: tda998x: introduce tda998x_audio_settings

2019-06-13 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 7:01 AM Russell King wrote: > > Introduce a structure to hold the register values to be programmed while > programming the TDA998x audio settings. This is currently a stub > structure, which will be populated in subsequent commits. > > When we initialise this from the

Re: [PATCH v17 08/15] userfaultfd, arm64: untag user pointers

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > userfaultfd code use provided user pointers for vma lookups,

[PATCH v17 02/15] lib, arm64: untag user pointers in strn*_user

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. strncpy_from_user and strnlen_user accept user addresses as arguments, and do not go through the same path as

Re: [PATCH v17 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-06-13 Thread Szabolcs Nagy
On 12/06/2019 12:43, Andrey Konovalov wrote: > --- /dev/null > +++ b/tools/testing/selftests/arm64/tags_lib.c > @@ -0,0 +1,62 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include > +#include > + > +#define TAG_SHIFT(56) > +#define TAG_MASK (0xffUL << TAG_SHIFT) > + > +#define

Re: [PATCH v16 04/16] mm: untag user pointers in do_pages_move

2019-06-13 Thread Andrey Konovalov
On Tue, Jun 11, 2019 at 10:18 PM Khalid Aziz wrote: > > On 6/3/19 10:55 AM, Andrey Konovalov wrote: > > This patch is a part of a series that extends arm64 kernel ABI to allow to > > pass tagged user pointers (with the top byte set to something else other > > than 0x00) as syscall arguments. > >

Re: [PATCH v16 08/16] fs, arm64: untag user pointers in copy_mount_options

2019-06-13 Thread Andrey Konovalov
On Tue, Jun 11, 2019 at 4:38 PM Andrey Konovalov wrote: > > On Sat, Jun 8, 2019 at 6:02 AM Kees Cook wrote: > > > > On Mon, Jun 03, 2019 at 06:55:10PM +0200, Andrey Konovalov wrote: > > > This patch is a part of a series that extends arm64 kernel ABI to allow to > > > pass tagged user pointers

Re: [PATCH v17 01/15] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > copy_from_user (and a few other similar functions) are used

Re: [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

2019-06-13 Thread Vincenzo Frascino
Hi Catalin, On 12/06/2019 10:32, Catalin Marinas wrote: > Hi Vincenzo, > > On Tue, Jun 11, 2019 at 06:09:10PM +0100, Vincenzo Frascino wrote: >>> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c >>> index 3767fb21a5b8..69d0be1fc708 100644 >>> ---

Re: [PATCH] drm/amd/display: fix compilation error

2019-06-13 Thread Hariprasad Kelam
On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > wrote: > > > > this patch fixes below compilation error > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In > > function ‘dcn10_apply_ctx_for_surface’: >

[PATCH v17 06/15] mm, arm64: untag user pointers in get_vaddr_frames

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. get_vaddr_frames uses provided user pointers for vma lookups, which can only by done with untagged pointers. Instead

Re: [PATCH][next] video: fbdev: atmel_lcdfb: remove redundant initialization to variable ret

2019-06-13 Thread Nicolas.Ferre
On 11/06/2019 at 19:09, Colin King wrote: > External E-Mail > > > From: Colin Ian King > > Currently variable ret is being initialized with -ENOENT however that > value is never read and ret is being re-assigned later on. Hence this > assignment is redundant and can be removed. > >

[PATCH v17 10/15] drm/radeon, arm64: untag user pointers in radeon_gem_userptr_ioctl

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In radeon_gem_userptr_ioctl() an MMU notifier is set up with a (tagged) userspace pointer. The untagged address

[PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Andrey Konovalov
From: Catalin Marinas It is not desirable to relax the ABI to allow tagged user addresses into the kernel indiscriminately. This patch introduces a prctl() interface for enabling or disabling the tagged ABI with a global sysctl control for preventing applications from enabling the relaxed ABI

[PATCH v17 14/15] vfio/type1, arm64: untag user pointers in vaddr_get_pfn

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. vaddr_get_pfn() uses provided user pointers for vma lookups, which can only by done with untagged pointers. Untag

Re: [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

2019-06-13 Thread Catalin Marinas
On Wed, Jun 12, 2019 at 01:03:10PM +0200, Andrey Konovalov wrote: > On Tue, Jun 11, 2019 at 7:39 PM Catalin Marinas > wrote: > > On Tue, Jun 11, 2019 at 07:09:46PM +0200, Andrey Konovalov wrote: > > > Should I drop access_ok() change from my patch, since yours just reverts > > > it? > > > > Not

Re: [PATCH v5 1/2] dt-bindings: Add doc for the Ingenic JZ47xx LCD controller driver

2019-06-13 Thread Paul Cercueil
Le mar. 11 juin 2019 à 23:55, Rob Herring a écrit : On Mon, 3 Jun 2019 17:23:30 +0200, Paul Cercueil wrote: Add documentation for the devicetree bindings of the LCD controller present in the JZ47xx family of SoCs from Ingenic. Signed-off-by: Paul Cercueil Tested-by: Artur Rojek ---

Re: [PATCH 04/13] drm/i2c: tda998x: derive CTS_N value from aclk sample rate ratio

2019-06-13 Thread Sven Van Asbroeck
On Wed, Jun 12, 2019 at 12:28 PM Russell King - ARM Linux admin wrote: > > The platform data path has never supported the HDMI codec way of doing > things, so that really isn't a concern here. The platform data way > was sufficient to allow SPDIF streams to work with a static setup of > the

Re: [PATCH v16 12/16] IB, arm64: untag user pointers in ib_uverbs_(re)reg_mr()

2019-06-13 Thread Catalin Marinas
On Tue, Jun 04, 2019 at 03:09:26PM +0200, Andrey Konovalov wrote: > On Tue, Jun 4, 2019 at 3:02 PM Jason Gunthorpe wrote: > > On Tue, Jun 04, 2019 at 02:45:32PM +0200, Andrey Konovalov wrote: > > > On Tue, Jun 4, 2019 at 2:27 PM Jason Gunthorpe wrote: > > > > On Tue, Jun 04, 2019 at 02:18:19PM

Re: [PATCH v17 14/15] vfio/type1, arm64: untag user pointers in vaddr_get_pfn

2019-06-13 Thread Vincenzo Frascino
On 12/06/2019 12:43, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > vaddr_get_pfn() uses provided user pointers for vma lookups,

[PATCH v17 00/15] arm64: untag user pointers passed to the kernel

2019-06-13 Thread Andrey Konovalov
=== Overview arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [1]) might use this feature and pass tagged user pointers to the kernel through syscalls or other interfaces.

Re: [PATCH v16 05/16] arm64: untag user pointers passed to memory syscalls

2019-06-13 Thread Andrey Konovalov
On Tue, Jun 11, 2019 at 7:45 PM Catalin Marinas wrote: > > On Tue, Jun 11, 2019 at 05:35:31PM +0200, Andrey Konovalov wrote: > > On Mon, Jun 10, 2019 at 4:28 PM Catalin Marinas > > wrote: > > > On Mon, Jun 03, 2019 at 06:55:07PM +0200, Andrey Konovalov wrote: > > > > This patch is a part of a

[PATCH v4 1/3] dma-buf: give each buffer a full-fledged inode

2019-06-13 Thread Chenbo Feng
From: Greg Hackmann By traversing /proc/*/fd and /proc/*/map_files, processes with CAP_ADMIN can get a lot of fine-grained data about how shmem buffers are shared among processes. stat(2) on each entry gives the caller a unique ID (st_ino), the buffer's size (st_size), and even the number of

[PATCH v4 2/3] dma-buf: add DMA_BUF_SET_NAME ioctls

2019-06-13 Thread Chenbo Feng
From: Greg Hackmann This patch adds complimentary DMA_BUF_SET_NAME ioctls, which lets userspace processes attach a free-form name to each buffer. This information can be extremely helpful for tracking and accounting shared buffers. For example, on Android, we know what each buffer will be

Re: [PATCH 04/13] drm/i2c: tda998x: derive CTS_N value from aclk sample rate ratio

2019-06-13 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 7:02 AM Russell King wrote: > > The TDA998x derives the CTS value using the supplied I2S bit clock > (ACLK, in TDA998x parlence) rather than 128·fs. TDA998x uses two > constants named m and k in the CTS generator such that we have this > relationship between the I2S

Re: [PATCH v16 09/16] fs, arm64: untag user pointers in fs/userfaultfd.c

2019-06-13 Thread Catalin Marinas
On Mon, Jun 03, 2019 at 06:55:11PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > userfaultfd code use provided user

Re: [PATCH v16 16/16] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-06-13 Thread Andrey Konovalov
On Tue, Jun 11, 2019 at 7:50 PM Catalin Marinas wrote: > > On Tue, Jun 11, 2019 at 07:18:04PM +0200, Andrey Konovalov wrote: > > On Tue, Jun 11, 2019 at 5:01 PM Catalin Marinas > > wrote: > > > static void *tag_ptr(void *ptr) > > > { > > > static int tagged_addr_err = 1; > > >

Re: [PATCH v16 15/16] vfio/type1, arm64: untag user pointers in vaddr_get_pfn

2019-06-13 Thread Catalin Marinas
On Mon, Jun 03, 2019 at 06:55:17PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > vaddr_get_pfn() uses provided user

[PATCH v17 04/15] mm, arm64: untag user pointers passed to memory syscalls

2019-06-13 Thread Andrey Konovalov
This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. This patch allows tagged pointers to be passed to the following memory syscalls: get_mempolicy, madvise, mbind,

Re: [RESEND PATCH v3 2/3] dma-buf: add DMA_BUF_{GET,SET}_NAME ioctls

2019-06-13 Thread Chenbo Feng
On Wed, Jun 12, 2019 at 7:43 AM Sumit Semwal wrote: > > Hello Chenbo, > > Thanks very much for your patches. Other than a couple tiny nits > below, I think these look good, and I will merge them before the end > of this week. > On Tue, 11 Jun 2019 at 05:32, Chenbo Feng wrote: > > > > From: Greg

Re: [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

2019-06-13 Thread Catalin Marinas
Hi Vincenzo, On Tue, Jun 11, 2019 at 06:09:10PM +0100, Vincenzo Frascino wrote: > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > index 3767fb21a5b8..69d0be1fc708 100644 > > --- a/arch/arm64/kernel/process.c > > +++ b/arch/arm64/kernel/process.c > > @@ -30,6 +30,7 @@

Re: [PATCH v5 5/9] drm/ttm: TTM fault handler helpers

2019-06-13 Thread Hillf Danton
Hello Thomas On Wed, 12 Jun 2019 08:42:39 +0200 Thomas Hellstrom wrote: > From: Thomas Hellstrom > > With the vmwgfx dirty tracking, the default TTM fault handler is not > completely sufficient (vmwgfx need to modify the vma->vm_flags member, > and also needs to restrict the number of

Re: [PATCH 12/13] drm/virtio: drop DRM_AUTH usage from the driver

2019-06-13 Thread Gerd Hoffmann
On Thu, Jun 06, 2019 at 11:59:15AM +0100, Emil Velikov wrote: > On Mon, 27 May 2019 at 09:19, Emil Velikov wrote: > > > > From: Emil Velikov > > > > The authentication can be circumvented, by design, by using the render > > node. > > > > From the driver POV there is no distinction between

Re: [PATCH v2 4/4] drm/virtio: Add memory barriers for capset cache.

2019-06-13 Thread Gerd Hoffmann
On Mon, Jun 10, 2019 at 02:18:10PM -0700, davidri...@chromium.org wrote: > From: David Riley > > After data is copied to the cache entry, atomic_set is used indicate > that the data is the entry is valid without appropriate memory barriers. > Similarly the read side was missing the corresponding

Re: [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave

2019-06-13 Thread Thomas Zimmermann
Acked-by: Thomas Zimmermann Am 12.06.19 um 11:12 schrieb Daniel Vetter: > ast doesn't implement the mode_set_base_atomic hook this would need, > so this is dead code. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Daniel Vetter > Cc: Gerd Hoffmann > Cc: Thomas Zimmermann > Cc:

<    1   2   3   4   >