Re: [PATCH 0/3] drm/vram: Provide GEM VRAM vmap()/vunmap/()

2019-09-11 Thread Thomas Zimmermann
FYI this is actually version 3 of the patch set posted at [1] and [2] [1] https://lists.freedesktop.org/archives/dri-devel/2019-July/227823.html [2] https://lists.freedesktop.org/archives/dri-devel/2019-July/228074.html Am 11.09.19 um 14:03 schrieb Thomas Zimmermann: > The ast and mgag200

[Bug 108917] gamma adjustments cause stuttering with amdgpu.dc=1, especially problematic with RedShift etc.

2019-09-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108917 --- Comment #15 from tempel.jul...@gmail.com --- To clarify: There is no connection to any compositor. You can also reproduce the issue with any desktop environment where you can disable the compositor. Instead of using a compositor then, simply

[PATCH 13/14] drm/amdgpu: modify the method to use mem under buffer object for amdgpu_ttm_tt_pte_flags

2019-09-11 Thread Huang, Ray
amdgpu_ttm_tt_pte_flags will be used for updating tmz bits while the bo is secure, so we need pass the ttm_mem_reg under a buffer object. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 18 ++ 1 file changed, 10 insertions(+), 8

[PATCH 14/14] drm/amdgpu: set TMZ bits in PTEs for secure bo (v2)

2019-09-11 Thread Huang, Ray
From: Alex Deucher If one bo is secure (created with AMDGPU_GEM_CREATE_ENCRYPTED), the TMZ bits of PTEs that belongs that bo should be set. Then psp is able to protect the pages of this bo to avoid the access from an "untrust" domain such as CPU. v1: design and draft the skeletion of tmz bits

[PATCH 12/14] drm/amdgpu: set trusted mode while the job is under secure context (v2)

2019-09-11 Thread Huang, Ray
While user mode submit a command with secure context, we should set the command buffer with trusted mode. v2: fix the null job pointer while in vmid 0 submission. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 +

[PATCH 11/14] drm/amdgpu: expand the context control interface with trust flag

2019-09-11 Thread Huang, Ray
This patch expands the context control function to support trusted flag while we want to set command buffer in trusted mode. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 5 +++--

[PATCH 01/14] drm/amdgpu: add UAPI for creating encrypted buffers

2019-09-11 Thread Huang, Ray
From: Alex Deucher Add a flag to the GEM_CREATE ioctl to create encrypted buffers. Buffers with this flag set will be created with the TMZ bit set in the PTEs or engines accessing them. This is required in order to properly access the data from the engines. Signed-off-by: Alex Deucher

[PATCH 02/14] drm/amdgpu: add UAPI for creating secure contexts (v2)

2019-09-11 Thread Huang, Ray
From: Alex Deucher Add a flag for when allocating a context to flag it as secure. The kernel driver will use this flag to determine whether a rendering context is secure or not so that the engine can be transitioned between secure or unsecure or the work can be submitted to a secure queue

[PATCH 08/14] drm/amdgpu: revise the function to allocate secure context (v2)

2019-09-11 Thread Huang, Ray
The is_secure flag will indicate the current conext is protected or not. v2: while user mode asks to create a context, but if tmz is disabled, it should return failure. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 19 +++

[PATCH 03/14] drm/amdgpu: define the TMZ bit for the PTE

2019-09-11 Thread Huang, Ray
From: Alex Deucher Define the TMZ (encryption) bit in the page table entry (PTE) for Raven and newer asics. Signed-off-by: Alex Deucher Reviewed-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 04/14] drm/amdgpu: add tmz feature parameter (v2)

2019-09-11 Thread Huang, Ray
This patch adds tmz parameter to enable/disable the feature in the amdgpu kernel module. Nomally, by default, it should be auto (rely on the hardware capability). But right now, it need to set "off" to avoid breaking other developers' work because it's not totally completed. Will set "auto" till

[PATCH 09/14] drm/amdgpu: add tmz bit in frame control packet

2019-09-11 Thread Huang, Ray
This patch adds tmz bit in frame control pm4 packet, and it will used in future. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nvd.h| 1 + drivers/gpu/drm/amd/amdgpu/soc15d.h | 1 + 2 files changed, 2 insertions(+) diff --git

[PATCH 10/14] drm/amdgpu: expand the emit tmz interface with trusted flag

2019-09-11 Thread Huang, Ray
This patch expands the emit_tmz function to support trusted flag while we want to set command buffer in trusted mode. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--

[PATCH 2/3] drm/ast: Use drm_gem_vram_{vmap, vunmap}() to map cursor source BO

2019-09-11 Thread Thomas Zimmermann
The VRAM helper's vmap interfaces provide pinning and mapping of BO memory. This patch replaces the respective code in ast cursor handling. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff

[PATCH 1/3] drm/vram: Provide vmap and vunmap operations for GEM VRAM objects

2019-09-11 Thread Thomas Zimmermann
The implementation of vmap and vunmap for GEM VRAM helpers is already in PRIME helpers. The patch moves the operations to separate functions and exports them for general use. v3: * remove v2's obsolete note on ref-counting v2: * fix documentation * add cross references to

[PATCH 0/3] drm/vram: Provide GEM VRAM vmap()/vunmap/()

2019-09-11 Thread Thomas Zimmermann
The ast and mgag200 drivers pin() and kmap() cursor buffers; essentially reimplementing vmap(). We can share some code by using the respective functionality from GEM VRAM buffer objects. Thomas Zimmermann (3): drm/vram: Provide vmap and vunmap operations for GEM VRAM objects drm/ast: Use

Re: [PATCH] drm: fix warnings in DSC

2019-09-11 Thread Harry Wentland
On 2019-09-11 4:47 a.m., Benjamin Gaignard wrote: > Remove always false comparisons due to limited range of nfl_bpg_offset > and scale_increment_interval fields. > Warnings detected when compiling with W=1. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Harry Wentland Harry > --- >

[Bug 111659] Kernel panic when waking up after screens go to dpms sleep

2019-09-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111659 --- Comment #2 from Brad Campbell --- Created attachment 145334 --> https://bugs.freedesktop.org/attachment.cgi?id=145334=edit Xorg log -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 00/14] drm/amdgpu: introduce secure buffer object support (trusted memory zone)

2019-09-11 Thread Koenig, Christian
Patches #1-#4, #8, #9 are Reviewed-by: Christian König Patches #10, #11 are Acked-by: Christian König Patches #7 and the resulting workaround in patch #13 are a clear NAK. The ttm_mem_reg can't be used like this to get back to the ttm_bo object. Going to reply separately on patch #14

Re: [PATCH 14/14] drm/amdgpu: set TMZ bits in PTEs for secure bo (v2)

2019-09-11 Thread Koenig, Christian
Am 11.09.19 um 13:50 schrieb Huang, Ray: > From: Alex Deucher > > If one bo is secure (created with AMDGPU_GEM_CREATE_ENCRYPTED), the TMZ bits > of > PTEs that belongs that bo should be set. Then psp is able to protect the pages > of this bo to avoid the access from an "untrust" domain such as

Re: [BACKPORT 4.14.y 04/18] usb: dwc3: Allow disabling of metastability workaround

2019-09-11 Thread Mathieu Poirier
On Tue, 10 Sep 2019 at 08:36, Greg KH wrote: > > On Thu, Sep 05, 2019 at 10:17:45AM -0600, Mathieu Poirier wrote: > > From: Roger Quadros > > > > commit 42bf02ec6e420e541af9a47437d0bdf961ca2972 upstream > > > > Some platforms (e.g. TI's DRA7 USB2 instance) have more trouble > > with the

Re: TTM huge page-faults WAS: Re: [RFC PATCH 1/2] x86: Don't let pgprot_modify() change the page encryption bit

2019-09-11 Thread Koenig, Christian
Am 11.09.19 um 12:10 schrieb Thomas Hellström (VMware): [SNIP] >>> The problem seen in TTM is that we want to be able to change the >>> vm_page_prot from the fault handler, but it's problematic since we >>> have the mmap_sem typically only in read mode. Hence the fake vma >>> hack. From what I can

[Bug 111659] Kernel panic when waking up after screens go to dpms sleep

2019-09-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111659 Michel Dänzer changed: What|Removed |Added Attachment #145334|text/x-log |text/plain mime type|

Re: TTM huge page-faults WAS: Re: [RFC PATCH 1/2] x86: Don't let pgprot_modify() change the page encryption bit

2019-09-11 Thread VMware
On 9/11/19 4:06 PM, Koenig, Christian wrote: Am 11.09.19 um 12:10 schrieb Thomas Hellström (VMware): [SNIP] The problem seen in TTM is that we want to be able to change the vm_page_prot from the fault handler, but it's problematic since we have the mmap_sem typically only in read mode. Hence

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-11 Thread Thomas Zimmermann
Hi Am 10.09.19 um 16:01 schrieb Ville Syrjälä: > On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: >> Support for vblank requires VSYNC to signal an interrupt, which is broken >> on Matrox chipsets. > > I don't remember there being anything wrong with the vsync interrupt. > What

[PULL] drm-intel-fixes

2019-09-11 Thread Jani Nikula
Hi Dave & Daniel - A couple more fixes for v5.3, both cc: stable. drm-intel-fixes-2019-09-11: Final drm/i915 fixes for v5.3: - Fox DP MST high color depth regression - Fix GPU hangs on Vulkan compute workloads BR, Jani. The following changes since commit

Re: [PATCH v3] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-11 Thread Jernej Škrabec
Dne sreda, 11. september 2019 ob 18:23:59 CEST je Neil Armstrong napisal(a): > On 11/09/2019 10:26, Cheng-Yi Chiang wrote: > > From: Yakir Yang > > > > When transmitting IEC60985 linear PCM audio, we configure the > > Aduio Sample Channel Status information in the IEC60958 frame. > > The status

Re: [PATCH v3] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-11 Thread Cheng-yi Chiang
On Thu, Sep 12, 2019 at 12:54 AM Jernej Škrabec wrote: > > Dne sreda, 11. september 2019 ob 18:23:59 CEST je Neil Armstrong napisal(a): > > On 11/09/2019 10:26, Cheng-Yi Chiang wrote: > > > From: Yakir Yang > > > > > > When transmitting IEC60985 linear PCM audio, we configure the > > > Aduio

Re: [PATCH v2] drm/qxl: get vga ioports

2019-09-11 Thread Frediano Ziglio
> > qxl has two modes: "native" (used by the drm driver) and "vga" (vga > compatibility mode, typically used for boot display and firmware > framebuffers). > > Accessing any vga ioport will switch the qxl device into vga mode. > The qxl driver never does that, but other drivers accessing vga

Re: [PATCH v4 3/9] drm: rcar-du: Add support for CMM

2019-09-11 Thread Kieran Bingham
Hi Jacopo, On 06/09/2019 14:43, Jacopo Mondi wrote: > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > to perform image enhancement and color correction. > > Add support for CMM through a driver that

Re: [PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property

2019-09-11 Thread Kieran Bingham
Hi Jacopo, On 06/09/2019 14:54, Jacopo Mondi wrote: > Document the newly added 'cmms' property which accepts a list of phandle > and channel index pairs that point to the CMM units available for each > Display Unit output video channel. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Laurent

Re: [PATCH v3] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-11 Thread Neil Armstrong
On 11/09/2019 10:26, Cheng-Yi Chiang wrote: > From: Yakir Yang > > When transmitting IEC60985 linear PCM audio, we configure the > Aduio Sample Channel Status information in the IEC60958 frame. > The status bit is already available in iec.status of hdmi_codec_params. > > This fix the issue that

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-11 Thread Ville Syrjälä
On Wed, Sep 11, 2019 at 05:08:45PM +0200, Thomas Zimmermann wrote: > Hi > > Am 10.09.19 um 16:01 schrieb Ville Syrjälä: > > On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: > >> Support for vblank requires VSYNC to signal an interrupt, which is broken > >> on Matrox chipsets. >

RE: [PATCH] drm/radeon: Bail earlier when radeon.cik_/si_support=0 is passed

2019-09-11 Thread Deucher, Alexander
> -Original Message- > From: Hans de Goede > Sent: Tuesday, September 10, 2019 5:36 AM > To: Michel Dänzer ; Deucher, Alexander > ; Koenig, Christian > ; Zhou, David(ChunMing) > > Cc: David Airlie ; dri-devel@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; Daniel Vetter >

Re: [PATCH v2 3/3] drm/mgag200: Map fbdev framebuffer while it's being displayed

2019-09-11 Thread Deucher, Alexander
Please use C style comments rather than C++. Alex From: Thomas Zimmermann Sent: Wednesday, September 4, 2019 7:56 AM To: dan...@ffwll.ch ; nor...@tronnes.org ; airl...@linux.ie ; rong.a.c...@intel.com ; feng.t...@intel.com ; ying.hu...@intel.com ;

<    1   2