On Wed, Mar 11, 2020 at 11:23:27AM +0100, Pascal Roeleven wrote:
> On 2020-03-10 19:54, Sam Ravnborg wrote:
> > A few things to improve.
> >
> > The binding should be a separate patch.
> > subject - shall start with dt-bindings:
> > Shall be sent to deveicetree mailing list.
>
> Hi Sam,
>
>
On 2020-03-09 20:51, Laurent Pinchart wrote:
> Replace the manual connector implementation based on drm_panel with the
> drm_panel_bridge helper. This simplifies the mxsfb driver by removing
> connector-related code, and standardizing all pipeline control
> operations on bridges.
>
> A hack is
On 2020-03-09 20:51, Laurent Pinchart wrote:
> Using BIT() is preferred over manual shifts as it's more readable,
> handles the 1 << 31 case properly, and avoids other mistakes as shown by
> the DEBUG0_HSYNC and DEBUG0_VSYNC bits (that are currently unused). Use
> it.
>
> Signed-off-by: Laurent
The fbdev framework doesn't care to call the .set_power callback only on
changes. So the driver has to care for itself that the regulator doesn't
get disabled more often than enabled.
This fixes the regulator warning
unbalanced disables for lcd supply
which can be triggered by doing
On 2020-03-09 20:51, Laurent Pinchart wrote:
> mxsfb_regs.h defines macros related to register bits. Some of them are
> not used and don't clearly map to any particular register, so their
> purpose isn't known. Remove them.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
>
On Mon, Mar 23, 2020 at 4:52 PM Shane Francis wrote:
>
> Calls to dma_map_sg may return segments / entries than requested
> if they fall on page bounderies. The old implementation did not
> support this use case.
>
> Signed-off-by: Shane Francis
Fixes: be62dbf554c5 ("iommu/amd: Convert AMD
Hi Stefan.
On Mon, Mar 23, 2020 at 10:27:21PM +0100, Stefan Agner wrote:
> On 2020-03-09 20:51, Laurent Pinchart wrote:
> > Replace the manual connector implementation based on drm_panel with the
> > drm_panel_bridge helper. This simplifies the mxsfb driver by removing
> > connector-related code,
On 2020-03-09 20:52, Laurent Pinchart wrote:
> Replace the convoluted way to set the format and bus width through
> difficult to read macros with more explicit ones. Also remove the
> outdated comment related to the limitations on bus width setting as it
Nice catch.
> doesn't apply anymore (the
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb_reset_block() function isn't special, pass it the
> mxsfb_drm_private pointer instead of a pointer to the base address.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The LCDC_CTRL register is located at address 0x. Some of the
> accesses to the register simply use the mxsfb->base address. Reference
> the LCDC_CTRL register explicitly instead to clarify the code.
>
> Signed-off-by: Laurent Pinchart
On 2020-03-09 20:52, Laurent Pinchart wrote:
> mxsfb_crtc.c defines several macros related to register addresses and
> bit, which duplicates macros from mxsfb_regs.h. Use the macros from
> mxsfb_regs.h instead and remove them.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
>
On 2020-03-09 20:52, Laurent Pinchart wrote:
> A fair number of includes are not needed. Drop them, and add a couple of
> required includes that were included indirectly.
>
> Signed-off-by: Laurent Pinchart
Out of curiosity, do you have some kind of tool helping with this?
Reviewed-by: Stefan
On Wed, Mar 11, 2020 at 03:40:29PM +0800, Jitao Shi wrote:
> Add a property to control mipi tx drive current:
> "drive-strength-microamp"
>
> Signed-off-by: Jitao Shi
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4
> 1 file changed, 4 insertions(+)
>
> diff
On Wed, Mar 11, 2020 at 01:51:33PM +0100, Phong LE wrote:
> Add the ITE bridge HDMI it66121 bindings.
>
> Signed-off-by: Phong LE
> ---
> .../bindings/display/bridge/ite,it66121.yaml | 98 +++
> 1 file changed, 98 insertions(+)
> create mode 100644
>
On 2020-03-09 20:52, Laurent Pinchart wrote:
> Extend the Kconfig option description by listing the i.MX7 SoCs, as they
> are supported by the same driver.
Can you also add "i.MX8M" to the list since the bindings for this driver
are also used in arch/arm64/boot/dts/freescale/imx8mq.dtsi.
--
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb_set_pixel_fmt() function returns an error when the selected
> pixel format is unsupported. This can never happen, as such errors are
> caught by the DRM core. Remove the error check.
>
> Signed-off-by: Laurent Pinchart
I see, we specify
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt() functions both deal
> with format configuration, are always called in a row from
> mxsfb_crtc_mode_set_nofb(), and set fields from the LCDC_CTRL register.
> This requires a read-modify-update cycle in
On 2020-03-23 22:38, Sam Ravnborg wrote:
> Hi Stefan.
>
> On Mon, Mar 23, 2020 at 10:27:21PM +0100, Stefan Agner wrote:
>> On 2020-03-09 20:51, Laurent Pinchart wrote:
>> > Replace the manual connector implementation based on drm_panel with the
>> > drm_panel_bridge helper. This simplifies the
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb_crtc.c file doesn't handle just the CRTC, but also the other
> KMS objects. Rename it accordingly.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/Makefile | 2 +-
>
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The DRM simple display pipeline helper only supports a single plane. In
> order to prepare for support of the alpha plane on i.MX6SX and i.MX7,
> move away from the helper. No new feature is added.
>
> Signed-off-by: Laurent Pinchart
I actually
From: Deepak Rawat
Add a new param for user-space to determine if kernel module is SM5
capable.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 3 +++
From: Deepak Rawat
Surface define v4 added new member buffer_byte_stride. With this patch
add buffer_byte_stride in surface metadata and create surface using new
command if support is available.
Also with this patch replace device specific data types with kernel
types.
Signed-off-by: Deepak
From: Deepak Rawat
Virtual device now supports new shader types, allow them as valid shader
type in command buffer. Also add per shader bind info in binding manager
state for new shader type.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
From: Deepak Rawat
A new enum to represent new SM5 graphics context capability in vmwgfx.
v2: use new correct cap bits (merged several later commits into it).
Signed-off-by: Deepak Rawat
Signed-off-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland
From: Deepak Rawat
With SM5 capability a new version of streamoutput is supported by device
which need backing mob and a new field. With this change the new command
is supported in command buffer.
v2: Also track streamoutput context binding in binding manager.
v3: Track only one streamoutput
From: Deepak Rawat
Virtual device now support new commands to manage unordered access
views. Allow them as part of user-space command buffer. This involves
adding UA view cotable, binding tracker info, new view type and command
verifier functions.
v2: fix comment typo
v3: style fixes (don't use
From: Deepak Rawat
Create a new structure vmw_surface_metadata representing the metadata
used for creating surface. With this can make the surface_define_priv
a bit cleaner.
Signed-off-by: Deepak Rawat
Reviewed-by: Brian Paul
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland
From: Deepak Rawat
Instead of having different bool in device private to represent
incremental graphics context capabilities, add a new sm type enum.
v2: Use enum instead of bit flag.
v3: Incorporated review comments.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
From: "Roland Scheidegger (VMware)"
This series updates vmwgfx to support newer vmware svga device protocol
and expose new commands to userspace..
This is required for supporting newer GL4 features in the guest.
This syncs up the device headers, adds support for the new commands,
and also
From: Deepak Rawat
In favor of SM4.1 multisampling capability, virtual device deprecated
old multisampling device capability. Mark legacy multisampling device
capability as dead. Rename the function that masks legacy multisample
capability to reflect that now it is masking a deprecated feature.
From: Deepak Rawat
Validate indirect and dispatch commands in command buffer.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 70 +
1
From: Thomas Hellström (VMware)
Signed-off-by: Thomas Hellström (VMware)
Reviewed-by: Charmaine Lee
Reviewed-by: Brian Paul
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
___
v2: Use 2.18 instead of 2.17
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +-
1 file changed, 1
From: Deepak Rawat
Virtual device added new register for suggested GB memory, read the new
register when available.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |
From: Deepak Rawat
Previous name vmw_ctx_bindinfo_so is misleading because it actually
represent so target and stream output is a new resource type that needs
tracking for SM5 capable device. Also rename binding type enum and
internal functions to reflect these belongs to so targets.
From: Deepak Rawat
Makes surface_define cleaner by sending vmw_surface_metadata instead of
all the arguments individually.
v2: fix uninitialized return value, error message
Signed-off-by: Deepak Rawat
Reviewed-by: Brian Paul
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland
Dave, Daniel,
vmwgfx pull for for 5.7. Needed for GL4 functionality.
Sync up device headers, add support for new commands, code
refactoring around surface definition.
Preliminary mesa userspace code using these new vmwgfx features
can be found at: https://gitlab.freedesktop.org/bhenden/mesa
v2:
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The driver attempts agressive power management by enabling and disabling
> the AXI clock around register accesses. This results in attempts to
> enable and disable the clock in the IRQ handler, which is a no-go as
> preparing or unpreparing the clock
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The debug0 and ipversion fields of the mxsfb_devdata structure are
> unused. Remove them.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4
> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb driver is only used by OF platforms. Drop non-OF support.
Nice cleanup. Actually only supported of anyways due to the
pdev->dev.of_node check.
Reviewed-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Laurent Pinchart
> ---
>
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha
> plane. Support it.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +
> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 16 ++--
>
Am 23.03.20 um 19:43 schrieb Roland Scheidegger:
> Am 23.03.20 um 01:36 schrieb Dave Airlie:
>> On Sat, 21 Mar 2020 at 08:57, Roland Scheidegger (VMware)
>> wrote:
>>>
>>> Dave, Daniel,
>>>
>>> vmwgfx pull for for 5.7. Needed for GL4 functionality.
>>> Sync up device headers, add support for new
> I think the other call to drm_prime_sg_to_page_addr_arrays in amdgpu
> needs a similar fix.
>
> Alex
Looking at the other call in amdgpu tmm it does not seem to undergo the
segment
remapping that happens in dma_map_sg, so should be safe.
I will port the changes to drm/radeon as that seems to
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The vblank event is armed in the plane .atomic_update(). This works fine
> as we have a single plane, but will break as soon as multiple planes are
> supported (not to mention it's logically the wrong place to perform the
> operation). Move it to CRTC
From: Deepak Rawat
Instead of having different bool in device private to represent
incremental graphics context capabilities, add a new sm type enum.
v2: Use enum instead of bit flag.
v3: Incorporated review comments.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
From: Deepak Rawat
Virtual device now supports new shader types, allow them as valid shader
type in command buffer. Also add per shader bind info in binding manager
state for new shader type.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
From: Deepak Rawat
A new enum to represent new SM5 graphics context capability in vmwgfx.
v2: use new correct cap bits (merged several later commits into it).
Signed-off-by: Deepak Rawat
Signed-off-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland
From: Deepak Rawat
Virtual device consider SVGA_CAP_DX and SVGA3D_DEVCAP_DXCONTEXT
independent of each other. Some of the commands in cmd_buf depends on
SVGA_CAP_DX, so better to check for that as well.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland
From: Deepak Rawat
Add a new param for user-space to determine if kernel module is SM5
capable.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 3 +++
From: Deepak Rawat
In favor of SM4.1 multisampling capability, virtual device deprecated
old multisampling device capability. Mark legacy multisampling device
capability as dead. Rename the function that masks legacy multisample
capability to reflect that now it is masking a deprecated feature.
From: Deepak Rawat
Previous name vmw_ctx_bindinfo_so is misleading because it actually
represent so target and stream output is a new resource type that needs
tracking for SM5 capable device. Also rename binding type enum and
internal functions to reflect these belongs to so targets.
From: Deepak Rawat
Create a new structure vmw_surface_metadata representing the metadata
used for creating surface. With this can make the surface_define_priv
a bit cleaner.
Signed-off-by: Deepak Rawat
Reviewed-by: Brian Paul
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland
From: Deepak Rawat
Makes surface_define cleaner by sending vmw_surface_metadata instead of
all the arguments individually.
v2: fix uninitialized return value, error message
Signed-off-by: Deepak Rawat
Reviewed-by: Brian Paul
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland
From: Deepak Rawat
Virtual device now support new commands to manage unordered access
views. Allow them as part of user-space command buffer. This involves
adding UA view cotable, binding tracker info, new view type and command
verifier functions.
v2: fix comment typo
v3: style fixes (don't use
From: Deepak Rawat
Logic ops commands are marked as deprecated by virtual device and were
never used by vmwgfx.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
From: Thomas Hellström (VMware)
Signed-off-by: Thomas Hellström (VMware)
Reviewed-by: Charmaine Lee
Reviewed-by: Brian Paul
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
___
v2: Use 2.18 instead of 2.17
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +-
1 file changed, 1
From: Deepak Rawat
With SM5 capability a new version of streamoutput is supported by device
which need backing mob and a new field. With this change the new command
is supported in command buffer.
v2: Also track streamoutput context binding in binding manager.
v3: Track only one streamoutput
From: Deepak Rawat
Validate indirect and dispatch commands in command buffer.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 70 +
1
From: Deepak Rawat
Virtual device added new register for suggested GB memory, read the new
register when available.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |
This series updates vmwgfx to support newer vmware svga device protocol
and expose new commands to userspace..
This is required for supporting newer GL4 features in the guest.
This syncs up the device headers, adds support for the new commands,
and also refactors some code (in particular around
From: Deepak Rawat
Surface define v4 added new member buffer_byte_stride. With this patch
add buffer_byte_stride in surface metadata and create surface using new
command if support is available.
Also with this patch replace device specific data types with kernel
types.
Signed-off-by: Deepak
Calls to dma_map_sg may return segments / entries than requested
if they fall on page bounderies. The old implementation did not
support this use case.
Signed-off-by: Shane Francis
---
drivers/gpu/drm/radeon/radeon_ttm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Previously drm_prime_sg_to_page_addr_arrays did not allow for
scatter-gather tables where the length had been reduced in a
dma_map.
This commit enables this via drm_prime_dma_sg_to_page_addr_arrays
while still keeping the original logic in place for tables that
that have not been through dma
This patch set is to fix a bug in amdgpu / radeon drm that results in
a crash when dma_map_sg combines segments. There are 2 shortfalls
in the current kernel.
1) AMDGPU / RADEON assumes that the requested and created segments
from dma_map_sg are equal
2) drm_prime does not allow for setting
Calls to dma_map_sg may return segments / entries than requested
if they fall on page bounderies. The old implementation did not
support this use case.
Signed-off-by: Shane Francis
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff
On Wed, 11 Mar 2020 15:40:30 +0800, Jitao Shi wrote:
> Add properties to get get mipitx calibration data.
>
> Signed-off-by: Jitao Shi
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dsi.txt| 5 +
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Rob Herring
On Wed, Mar 11, 2020 at 01:51:32PM +0100, Phong LE wrote:
> Add ITE Tech Inc. prefix "ite" in vendor-prefixes. More information on:
> http://www.ite.com.tw/
>
> Signed-off-by: Phong LE
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
On 2020-03-09 20:52, Laurent Pinchart wrote:
> Enable vblank handling when the CRTC is turned on and disable it when it
> is turned off. This requires moving vblank init after the KMS pipeline
> initialisation, otherwise drm_vblank_init() gets called with 0 CRTCs.
>
> Signed-off-by: Laurent
From: Deepak Rawat
Virtual device consider SVGA_CAP_DX and SVGA3D_DEVCAP_DXCONTEXT
independent of each other. Some of the commands in cmd_buf depends on
SVGA_CAP_DX, so better to check for that as well.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland
From: Deepak Rawat
Logic ops commands are marked as deprecated by virtual device and were
never used by vmwgfx.
Signed-off-by: Deepak Rawat
Reviewed-by: Thomas Hellström (VMware)
Reviewed-by: Roland Scheidegger
Signed-off-by: Roland Scheidegger
---
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The LCDIF present in the i.MX6SX has extra features compared to
> the i.MX28. It has however lost its IP version register, so no official
> version number is known. Bump the version to MXSFB_V6 following the i.MX
> version, in preparation for support
101 - 170 of 170 matches
Mail list logo
