Re: [PATCH 1/5] dt-bindings: display: panel-dpi: Add bits-per-color property

2020-07-21 Thread Chen-Yu Tsai
On Tue, Jul 21, 2020 at 5:23 PM Maxime Ripard wrote: > > On Mon, Jul 20, 2020 at 08:10:26PM -0600, Rob Herring wrote: > > On Tue, Jul 14, 2020 at 03:13:01PM +0800, Chen-Yu Tsai wrote: > > > From: Chen-Yu Tsai > > > > > > Some LCD panels do not support 24-bit true color, or 8bits per channel > >

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Intel
On 7/21/20 10:55 AM, Christian König wrote: Am 21.07.20 um 10:47 schrieb Thomas Hellström (Intel): On 7/21/20 9:45 AM, Christian König wrote: Am 21.07.20 um 09:41 schrieb Daniel Vetter: On Mon, Jul 20, 2020 at 01:15:17PM +0200, Thomas Hellström (Intel) wrote: Hi, On 7/9/20 2:33 PM, Daniel

Re: [PATCH 11/11] drm/ttm: remove TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:45AM +0200, Christian König wrote: > Not used any more. And it is bad design to use a TTM flag > to do a check inside a driver. > > Signed-off-by: Christian König > --- > include/drm/ttm/ttm_bo_driver.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 09/11] drm/nouveau: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:43AM +0200, Christian König wrote: > The driver doesn't expose any not-mapable memory resources. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 13 + > 1 file changed, 5 insertions(+), 8

Re: [PATCH 10/11] drm/qxl: stop using TTM_MEMTYPE_FLAG_MAPPABLE v2

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:44AM +0200, Christian König wrote: > The driver doesn't expose any not-mapable memory resources. > > v2: remove unused man variable as well > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_ttm.c | 9 +++-- > 1

Re: [PATCH 08/11] drm/amdgpu: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:42AM +0200, Christian König wrote: > The driver does support some not-mapable resources, but > those are already handled correctly in the switch/case > statement in the code. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11

Re: [PATCH 07/11] drm/vmwgfx: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:41AM +0200, Christian König wrote: > The driver doesn't expose any not-mapable memory resources. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 ++--- > 1 file changed, 2 insertions(+), 7

Re: [PATCH 06/11] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:40AM +0200, Christian König wrote: > The driver doesn't expose any not-mapable memory resources. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/radeon/radeon_ttm.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 11:16 AM Daniel Vetter wrote: > > On Tue, Jul 21, 2020 at 10:55 AM Christian König > wrote: > > > > Am 21.07.20 um 10:47 schrieb Thomas Hellström (Intel): > > > > > > On 7/21/20 9:45 AM, Christian König wrote: > > >> Am 21.07.20 um 09:41 schrieb Daniel Vetter: > > >>> On

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 10:55 AM Christian König wrote: > > Am 21.07.20 um 10:47 schrieb Thomas Hellström (Intel): > > > > On 7/21/20 9:45 AM, Christian König wrote: > >> Am 21.07.20 um 09:41 schrieb Daniel Vetter: > >>> On Mon, Jul 20, 2020 at 01:15:17PM +0200, Thomas Hellström (Intel) > >>>

RE: [PATCH 01/11] drm: remove optional dummy function from drivers using TTM

2020-07-21 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: Christian König Sent: Tuesday, July 21, 2020 1:03 PM To: dri-devel@lists.freedesktop.org Cc: Chauhan, Madhav ; tzimmerm...@suse.de; michael.j.r...@intel.com Subject: [PATCH 01/11] drm: remove optional dummy function from drivers using TTM

Re: [PATCH 05/11] drm/ttm: remove TTM_MEMTYPE_FLAG_CMA

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:39AM +0200, Christian König wrote: > The original intention was to avoid CPU page table unmaps > when BOs move between the GTT and SYSTEM domain. > > The problem is that this never correctly handled changes > in the caching attributes or backing pages. > > Just drop

Re: [PATCH 04/11] drm/ttm: cleanup coding style and implementation.

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:38AM +0200, Christian König wrote: > Only functional change is to always keep io_reserved_count up to date > for debugging even when it is not used otherwise. Functional change in a cleanup patch. Tsk. It looks correct though ... Reviewed-by: Daniel Vetter > >

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Christian König
Am 21.07.20 um 10:47 schrieb Thomas Hellström (Intel): On 7/21/20 9:45 AM, Christian König wrote: Am 21.07.20 um 09:41 schrieb Daniel Vetter: On Mon, Jul 20, 2020 at 01:15:17PM +0200, Thomas Hellström (Intel) wrote: Hi, On 7/9/20 2:33 PM, Daniel Vetter wrote: Comes up every few years, gets

Re: [PATCH 03/11] drm/ttm: remove io_reserve_fastpath flag

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:37AM +0200, Christian König wrote: > Just use the use_io_reserve_lru flag. It doesn't make much > sense to have two flags. > > Signed-off-by: Christian König Yeah looks entirely redundant. Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/nouveau/nouveau_bo.c

Re: [PATCH 02/11] drm/ttm: cleanup io_mem interface with nouveau

2020-07-21 Thread daniel
On Tue, Jul 21, 2020 at 09:32:36AM +0200, Christian König wrote: > Nouveau is the only user of this functionality and evicting io space > on -EAGAIN is really a misuse of the return code. > > Instead switch to using -ENOSPC here which makes much more sense and > simplifies the code. > >

Re: [PATCH 2/2 v1] backlight: Add Kinetic KTD253 backlight driver

2020-07-21 Thread Sam Ravnborg
Hi Linus. On Mon, Jul 20, 2020 at 10:35:06PM +0200, Linus Walleij wrote: > The Kinetic KTD253 backlight driver is controlled with a > single GPIO line, but still supports a range of brightness > settings by sending fast pulses on the line. > > This is based off the source code release for the

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Intel
On 7/21/20 9:45 AM, Christian König wrote: Am 21.07.20 um 09:41 schrieb Daniel Vetter: On Mon, Jul 20, 2020 at 01:15:17PM +0200, Thomas Hellström (Intel) wrote: Hi, On 7/9/20 2:33 PM, Daniel Vetter wrote: Comes up every few years, gets somewhat tedious to discuss, let's write this down once

Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-07-21 Thread Sam Ravnborg
Hi Linus. On Mon, Jul 20, 2020 at 10:35:05PM +0200, Linus Walleij wrote: > This adds device tree bindings for the Kinetic KTD253 > white LED backlight driver. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Linus Walleij See a few comments in the following. Sam > --- >

[PATCH v2] drm/virtio: fixed memory leak in virtio_gpu_execbuffer_ioctl()

2020-07-21 Thread hexin
commit 2cd7b6f08bc4 ("drm/virtio: add in/out fence support for explicit synchronization") deleted dma_fence_put(), which will cause the memory leak. To balance the reference count initialized when allocating fence, dma_fence_put() should not be deleted. Fixes: 2cd7b6f08bc4 ("drm/virtio: add

Re: [PATCH v3] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-07-21 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-30 12:51:51) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 31b9217bb5bf..271d55db62ab 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2440,6 +2447,44 @@

Re: [PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-21 Thread Viresh Kumar
On 20-07-20, 08:03, Rob Clark wrote: > On Mon, Jul 20, 2020 at 3:01 AM Viresh Kumar wrote: > > > > On 15-07-20, 08:36, Rob Clark wrote: > > > I can take the first two into msm-next, the 3rd will need to wait > > > until dev_pm_opp_set_bw() lands > > > > You can base that on a8351c12c6c7 in

Re: [PATCH] drm/msm: dsi: dev_pm_opp_put_clkname() only when an opp_table exists

2020-07-21 Thread Sai Prakash Ranjan
On 2020-07-20 17:31, Rajendra Nayak wrote: Its possible for msm_dsi_host_init() to fail early, before dev_pm_opp_set_clkname() is called. In such cases, unconditionally calling dev_pm_opp_put_clkname() in msm_dsi_host_destroy() results in a crash. Put an additional check so that

Re: [v3] arm64: dts: sc7180: add nodes for idp display

2020-07-21 Thread Stephen Boyd
Quoting harig...@codeaurora.org (2020-06-29 06:50:09) > On 2020-06-25 06:37, Stephen Boyd wrote: > > Quoting Harigovindan P (2020-02-17 00:58:42) > >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> index 388f50ad4fde..349db8fe78a5 100644 >

[PATCH 2/3] backlight: pwm_bl: Artificially add 0% during interpolation

2020-07-21 Thread Alexandru Stan
Some displays need the low end of the curve cropped in order to make them happy. In that case we still want to have the 0% point, even though anything between 0% and 5%(example) would be skipped. Signed-off-by: Alexandru Stan --- drivers/video/backlight/pwm_bl.c | 8 1 file changed, 8

Re: [PATCH v2] drm/virtio: Fix memory leak in virtio_gpu_execbuffer_ioctl()

2020-07-21 Thread Markus Elfring
> … To balance the reference > count initialized when allocating fence, dma_fence_put() > should not be deleted. * Would an imperative wording be more appropriate for the change description? * Is the information “hexin” sufficient for a real name? Regards, Markus

Re: [PATCH 2/5] drm: rockchip: add missing registers for RK3188【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-07-21 Thread Andy Yan
Hi Alex: On 7/19/20 4:03 AM, Alex Bee wrote: This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap registers to enable their respective functionality for RK3188's VOP. Signed-off-by: Alex Bee --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 1 file changed, 4

[Resend][PATCH] drm/msm: use kthread_create_worker instead of kthread_run

2020-07-21 Thread Bernard
Use kthread_create_worker to simplify the code and optimise the manager struct: msm_drm_thread. With this change, we could remove struct element (struct task_struct *thread & struct kthread_worker worker), instead, use one point (struct kthread_worker *worker). Signed-off-by: Bernard Zhao ---

Re: [bug report] drm/ingenic: Add support for the IPU

2020-07-21 Thread Paul Cercueil
Hi Dan, Le lun. 20 juil. 2020 à 10:22, dan.carpen...@oracle.com a écrit : Hello Paul Cercueil, The patch fc1acf317b01: "drm/ingenic: Add support for the IPU" from Jul 16, 2020, leads to the following static checker warning: drivers/gpu/drm/ingenic/ingenic-drm-drv.c:232

Re: [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-21 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-07-07 11:41:25) > add event thread to execute events serially from event queue. Also > timeout mode is supported which allow an event be deferred to be > executed at later time. Both link and phy compliant tests had been > done successfully. > > This change depends-on

Re: [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-21 Thread khsieh
On 2020-07-20 13:18, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-07-07 11:41:25) add event thread to execute events serially from event queue. Also timeout mode is supported which allow an event be deferred to be executed at later time. Both link and phy compliant tests had been done

Re: [PATCH] drm/msm/dpu: dev_pm_opp_put_clkname() only when an opp_table exists

2020-07-21 Thread Sai Prakash Ranjan
On 2020-07-20 17:47, Rajendra Nayak wrote: Its possible that dpu_bind() fails early enough before dev_pm_opp_set_clkname() is called. In such cases, unconditionally calling dev_pm_opp_put_clkname() in dpu_unbind() can result in a crash. Put an additional check so that dev_pm_opp_put_clkname() is

KASAN: stack-out-of-bounds Write in sys_imageblit

2020-07-21 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4fa640dc Merge tag 'vfio-v5.8-rc7' of git://github.com/awi.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17ec2d5890 kernel config: https://syzkaller.appspot.com/x/.config?x=575b381064b1cba2

Re: [PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-21 Thread Viresh Kumar
On 15-07-20, 08:36, Rob Clark wrote: > I can take the first two into msm-next, the 3rd will need to wait > until dev_pm_opp_set_bw() lands You can base that on a8351c12c6c7 in linux-next, I will make sure not to rebase it anymore. -- viresh ___

Re: [Freedreno] [PATCH] drm/msm/dpu: fix/enable 6bpc dither with split-lm

2020-07-21 Thread kalyan_t
On 2020-07-16 03:49, Rob Clark wrote: From: Rob Clark If split-lm is used (for ex, on sdm845), we can have multiple ping- pongs, but only a single phys encoder. We need to configure dithering on each of them. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 22

[PATCH V2] drm: hold gem reference until object is no longer accessed

2020-07-21 Thread Steve Cohen
A use-after-free in drm_gem_open_ioctl can happen if the GEM object handle is closed between the idr lookup and retrieving the size from said object since a local reference is not being held at that point. Hold the local reference while the object can still be accessed to fix this and plug the

[PATCH 0/3] PWM backlight interpolation adjustments

2020-07-21 Thread Alexandru Stan
I was trying to adjust the brightness for a new chromebook: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2291209 Like a lot of panels, the low end needs to be cropped, and now that we have the interpolation stuff I wanted to make use of it and bake in even the curve.

Re: [Mesa-dev] [XDC 2020] Virtual conference + Call for Proposals extended 2 weeks more

2020-07-21 Thread Samuel Iglesias Gonsálvez
On 7/3/20 4:41 PM, Samuel Iglesias Gonsálvez wrote: > Hi, > > In the last meeting, X.Org Foundation board has decided that XDC 2020 > will be a virtual conference, given the uncertain COVID-19 situation in > Europe by September, including the possibility of a second wave, > outbreaks and travel

Re: [PATCH v8 00/12] PCI: brcmstb: enable PCIe for STB chips

2020-07-21 Thread Florian Fainelli
On 7/15/20 7:35 AM, Jim Quinlan wrote: > Patchset Summary: > Enhance a PCIe host controller driver. Because of its unusual design > we are foced to change dev->dma_pfn_offset into a more general role > allowing multiple offsets. See the 'v1' notes below for more info. Christoph, Robin,

Re: [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-21 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2020-07-20 15:48:13) > On 2020-07-20 13:18, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2020-07-07 11:41:25) > >> drivers/gpu/drm/msm/dp/dp_power.c | 32 +- > >> drivers/gpu/drm/msm/dp/dp_power.h | 1 + > >> drivers/gpu/drm/msm/dp/dp_reg.h

Re: [PATCH] drm/virtio: Fix memory leak in virtio_gpu_execbuffer_ioctl()

2020-07-21 Thread Markus Elfring
* I suggest to add a change description. * Is “hexin.op” a real name? Regards, Markus ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/5] drm: rockchip: add missing registers for RK3188【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-07-21 Thread Andy Yan
Hi Alex: On 7/20/20 10:46 PM, Alex Bee wrote: Hi Andy, Am 20.07.20 um 10:22 schrieb Andy Yan: Hi Alex: On 7/19/20 4:03 AM, Alex Bee wrote: This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap registers to enable their respective functionality for RK3188's VOP. Signed-off-by:

Re: [PATCH 2/5] drm: rockchip: add missing registers for RK3188【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-07-21 Thread Alex Bee
Hi Andy, Am 21.07.20 um 03:17 schrieb Andy Yan: Hi Alex: On 7/20/20 10:46 PM, Alex Bee wrote: Hi Andy, Am 20.07.20 um 10:22 schrieb Andy Yan: Hi Alex: On 7/19/20 4:03 AM, Alex Bee wrote: This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap registers to enable their

Re: [PATCH] drm/i915: Don't force IOSF_MBI

2020-07-21 Thread Jisheng Zhang
On Fri, 17 Jul 2020 20:32:44 +0100 Chris Wilson wrote: > > > Quoting Jisheng Zhang (2020-07-17 07:11:38) > > The i915 doesn't depend on IOSF_MBI, asm/iosf_mbi.h already defines > > isof_mbi_* APIs when ISOF_MBI is disabled. > > > > Don't force IOSF_MBI to allow disabling IOSF_MBI for non SoC

Re: [PATCH 2/5] drm: rockchip: add missing registers for RK3188【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-07-21 Thread Alex Bee
Hi Andy, Am 20.07.20 um 10:22 schrieb Andy Yan: Hi Alex: On 7/19/20 4:03 AM, Alex Bee wrote: This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap registers to enable their respective functionality for RK3188's VOP. Signed-off-by: Alex Bee ---  

[PATCH 1/3] backlight: pwm_bl: Fix interpolation

2020-07-21 Thread Alexandru Stan
Whenever num-interpolated-steps was larger than the distance between 2 consecutive brightness levels the table would get really discontinuous. The slope of the interpolation would stick with integers only and if it was 0 the whole line segment would get skipped. Example settings:

Re: [PATCH 01/11] drm: remove optional dummy function from drivers using TTM

2020-07-21 Thread Christian König
Sorry, I once more forgot the cover letter. This is just some cleanup all over drivers using TTM. The only important functional change is the removal of the CMA (Can't Map Aperture) flag since this might be a bug fix. Please review and/or comment, Christian. Am 21.07.20 um 09:32 schrieb

Re: [PATCH 1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity'

2020-07-21 Thread Sam Ravnborg
Hi Lee. On Tue, Jul 21, 2020 at 08:39:19AM +0100, Lee Jones wrote: > Fixes the following kernel build warning: > > drivers/video/backlight/cr_bllcd.c: In function ‘cr_backlight_set_intensity’: > drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable > ‘intensity’

Re: [PATCH 01/11] drm: remove optional dummy function from drivers using TTM

2020-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 09:32:35AM +0200, Christian König wrote: > Implementing those is completely unecessary. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 5 - > drivers/gpu/drm/drm_gem_vram_helper.c | 5 -

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Christian König
Am 21.07.20 um 09:41 schrieb Daniel Vetter: On Mon, Jul 20, 2020 at 01:15:17PM +0200, Thomas Hellström (Intel) wrote: Hi, On 7/9/20 2:33 PM, Daniel Vetter wrote: Comes up every few years, gets somewhat tedious to discuss, let's write this down once and for all. What I'm not sure about is

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-21 Thread Daniel Vetter
On Mon, Jul 20, 2020 at 01:15:17PM +0200, Thomas Hellström (Intel) wrote: > Hi, > > On 7/9/20 2:33 PM, Daniel Vetter wrote: > > Comes up every few years, gets somewhat tedious to discuss, let's > > write this down once and for all. > > > > What I'm not sure about is whether the text should be

[PATCH 1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity'

2020-07-21 Thread Lee Jones
Fixes the following kernel build warning: drivers/video/backlight/cr_bllcd.c: In function ‘cr_backlight_set_intensity’: drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable ‘intensity’ [-Wunused-variable] 62 | int intensity = bd->props.brightness; | ^ Cc: Sam Ravnborg

[PATCH 05/11] drm/ttm: remove TTM_MEMTYPE_FLAG_CMA

2020-07-21 Thread Christian König
The original intention was to avoid CPU page table unmaps when BOs move between the GTT and SYSTEM domain. The problem is that this never correctly handled changes in the caching attributes or backing pages. Just drop this for now and simply unmap the CPU page tables in all cases.

[PATCH 10/11] drm/qxl: stop using TTM_MEMTYPE_FLAG_MAPPABLE v2

2020-07-21 Thread Christian König
The driver doesn't expose any not-mapable memory resources. v2: remove unused man variable as well Signed-off-by: Christian König --- drivers/gpu/drm/qxl/qxl_ttm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c

[PATCH 09/11] drm/nouveau: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread Christian König
The driver doesn't expose any not-mapable memory resources. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c

[PATCH 06/11] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread Christian König
The driver doesn't expose any not-mapable memory resources. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index

[PATCH 02/11] drm/ttm: cleanup io_mem interface with nouveau

2020-07-21 Thread Christian König
Nouveau is the only user of this functionality and evicting io space on -EAGAIN is really a misuse of the return code. Instead switch to using -ENOSPC here which makes much more sense and simplifies the code. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 2 --

[PATCH 08/11] drm/amdgpu: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread Christian König
The driver does support some not-mapable resources, but those are already handled correctly in the switch/case statement in the code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH 07/11] drm/vmwgfx: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread Christian König
The driver doesn't expose any not-mapable memory resources. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c

[PATCH 11/11] drm/ttm: remove TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-21 Thread Christian König
Not used any more. And it is bad design to use a TTM flag to do a check inside a driver. Signed-off-by: Christian König --- include/drm/ttm/ttm_bo_driver.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h index

[PATCH 03/11] drm/ttm: remove io_reserve_fastpath flag

2020-07-21 Thread Christian König
Just use the use_io_reserve_lru flag. It doesn't make much sense to have two flags. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 1 - drivers/gpu/drm/ttm/ttm_bo_util.c| 8 include/drm/ttm/ttm_bo_driver.h

[PATCH 04/11] drm/ttm: cleanup coding style and implementation.

2020-07-21 Thread Christian König
Only functional change is to always keep io_reserved_count up to date for debugging even when it is not used otherwise. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 97 +++ 1 file changed, 48 insertions(+), 49 deletions(-) diff --git

[PATCH 01/11] drm: remove optional dummy function from drivers using TTM

2020-07-21 Thread Christian König
Implementing those is completely unecessary. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 5 - drivers/gpu/drm/drm_gem_vram_helper.c | 5 - drivers/gpu/drm/qxl/qxl_ttm.c | 6 -- drivers/gpu/drm/radeon/radeon_ttm.c| 5

Re: [PATCH 8/8] drm/mgag200: Add support for G200 desktop cards

2020-07-21 Thread Thomas Zimmermann
Hi Am 20.07.20 um 21:18 schrieb Lyude Paul: > On Mon, 2020-07-20 at 09:04 +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 17.07.20 um 00:43 schrieb Lyude Paul: >>> On Wed, 2020-07-15 at 16:59 +0200, Thomas Zimmermann wrote: This patch adds support for G200 desktop cards. We can reuse the

Re: [PATCH 4/5] drm/vblank: Use spin_(un)lock_irq() in drm_queue_vblank_event()

2020-07-21 Thread Daniel Vetter
On Mon, Jul 20, 2020 at 03:07:35PM -0400, Lyude Paul wrote: > This one's easy - we're already calling kzalloc() in this function, so Nit: "kzalloc(GFP_KERNEL)", since kzalloc(GFP_ATOMIC) is perfectly fine in interrupt context. With that clarified for the entire series: Reviewed-by: Daniel Vetter

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 05:33:00AM +, Sidong Yang wrote: > Hi, Daniel and Melissa > > I tested some code for this problem trying to find the code that make problem > in igt test. > kms_cursor_crc test in igt test has 3 steps (preparation, test, cleanup). I > check each steps > and I found

Re: [PATCH 09/20] Documentation: i2c: eliminate duplicated word

2020-07-21 Thread Wolfram Sang
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote: > Drop doubled word "new". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Wolfram Sang > Cc: linux-...@vger.kernel.org Reviewed-by: Wolfram Sang signature.asc Description: PGP

<    1   2