Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Tim Gover
hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC VCO to support a core-frequency of 550 MHz which is the minimum frequency required by the HVS at 4Kp60. The side effect is that if the display clock requirements are lower than 4Kp60 then you will see different core frequencies

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Maxime Ripard
On Thu, Oct 01, 2020 at 08:48:43AM +0200, Maxime Ripard wrote: > Hi Stefan, > > On Wed, Sep 30, 2020 at 06:52:13PM +0200, Stefan Wahren wrote: > > Am 30.09.20 um 18:38 schrieb Nathan Chancellor: > > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > > >> Hi Nathan, > > >> > > >>

Re: [PATCH tip/core/rcu 11/15] drm/i915: Cleanup PREEMPT_COUNT leftovers

2020-10-02 Thread Thomas Gleixner
On Thu, Oct 01 2020 at 10:17, Joonas Lahtinen wrote: > Quoting paul...@kernel.org (2020-09-29 02:30:58) >> CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be >> removed. Cleanup the leftovers before doing so. > > Change looks fine: > > Reviewed-by: Joonas Lahtinen > > Are you looking

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Tim Gover
Sorry, my previous statement was misleading. enable_uart will select the mini_uart for gpio14,15 unless the disable-bt device tree overlay is loaded. As well as disabling bluetooth disable-bt swaps the uart0 pin configs to point the regular UART to gpio 14,15. After resolving the DT overlays the

Re: [RFC][PATCH 5/6] dma-buf: system_heap: Add pagepool support to system heap

2020-10-02 Thread Chris Goldsworthy
On 2020-09-29 21:46, Chris Goldsworthy wrote: On 2020-09-25 21:24, John Stultz wrote: Reuse/abuse the pagepool code from the network code to speed up allocation performance. This is similar to the ION pagepool usage, but tries to utilize generic code instead of a custom implementation. Cc:

[PULL] drm-misc-next-fixes

2020-10-02 Thread Maxime Ripard
Hi Daniel, Dave, Here's a few fixes for the next merge window Thanks! Maxime drm-misc-next-fixes-2020-10-02: Three fixes for vc4 that addresses dual-display breakages The following changes since commit 089d83418914abd4d908db117d9a3eca7f51a68c: drm/vc4: hvs: Pull the state of all the CRTCs

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Nicolas Saenz Julienne
Hi Tim, thanks for the info! On Thu, 2020-10-01 at 11:15 +0100, Tim Gover wrote: > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > VCO to support a core-frequency of 550 MHz which is the minimum > frequency required by the HVS at 4Kp60. The side effect is that if the >

Re: [PATCH] drm/amdgpu: Avoid null pointer dereference in soc15_reg_base_init()

2020-10-02 Thread Markus Elfring
> that change, the NULL pointer dereference does not occur: * Please provide a proper tag “Signed-off-by”. * How do you think about to add the tag “Fixes” to the commit message? * Would another imperative wording become helpful for the change description? * Would you like to choose an other

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Nicolas Saenz Julienne
On Wed, 2020-09-30 at 09:38 -0700, Nathan Chancellor wrote: > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > > Hi Nathan, > > > > On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote: > > > On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > > > > Now

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Nathan Chancellor
On Thu, Oct 01, 2020 at 11:22:03AM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2020-09-30 at 09:38 -0700, Nathan Chancellor wrote: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > > > Hi Nathan, > > > > > > On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote:

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Maxime Ripard
On Thu, Oct 01, 2020 at 11:22:03AM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2020-09-30 at 09:38 -0700, Nathan Chancellor wrote: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > > > Hi Nathan, > > > > > > On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote:

Re: [RFC PATCH 0/4] Add a RPMsg driver to support AI Processing Unit (APU)

2020-10-02 Thread Alexandre Bailon
Hi Daniel, On 10/1/20 10:48 AM, Daniel Vetter wrote: On Wed, Sep 30, 2020 at 01:53:46PM +0200, Alexandre Bailon wrote: This adds a RPMsg driver that implements communication between the CPU and an APU. This uses VirtIO buffer to exchange messages but for sharing data, this uses a dmabuf,

Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-10-02 Thread Maxime Ripard
On Thu, Sep 24, 2020 at 05:08:56PM +0900, Hoegeun Kwon wrote: > Hi Maxime, > > On 9/18/20 11:59 PM, Maxime Ripard wrote: > > The HVS has three FIFOs that can be assigned to a number of PixelValves > > through a mux. > > > > However, changing that FIFO requires that we disable and then enable the

Re: [PATCH 2/4] drm/ttm: rename and move ttm_bo_evict_mm as well

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 10:47 AM Christian König wrote: > > This function also works with whole device and not individual BOs. > > Signed-off-by: Christian König This doesn't operate on the device, but on the resource_manager. It's just stuck using the old api of (bdev, man_type) pairs instead

[PATCH v3] drm/panfrost: Fix job timeout handling

2020-10-02 Thread Boris Brezillon
If more than two jobs end up timeout-ing concurrently, only one of them (the one attached to the scheduler acquiring the lock) is fully handled. The other one remains in a dangling state where it's no longer part of the scheduling queue, but still blocks something in scheduler, leading to

[PATCH] drm/atomic: Make the kerneldoc a bit clearer

2020-10-02 Thread Daniel Vetter
Crank up the warning a notch and point at the right set of locking functions for atomic drivers. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 10 +- 1 file changed, 5

Re: [PATCH 2/4] drm/ttm: rename and move ttm_bo_evict_mm as well

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 11:07 AM Daniel Vetter wrote: > > On Fri, Oct 2, 2020 at 10:47 AM Christian König > wrote: > > > > This function also works with whole device and not individual BOs. > > > > Signed-off-by: Christian König > > This doesn't operate on the device, but on the

Re: [PATCH 4/4] drm/vmwgfx: move ttm_bo_swapout_all into vmwgfx

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 10:47 AM Christian König wrote: > > It is the sole user of this. > > Signed-off-by: Christian König Patches 1, 3&4: Acked-by: Daniel Vetter Patch 1 is maybe a bit big and shouldn't be all smashed, but whatever. -Daniel > --- > drivers/gpu/drm/ttm/ttm_bo.c| 11

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html lore.kernel.org is easier to pull stuff from :) Anyway, what ever happened

[PATCH v2] drm/sched: Avoid infinite waits in the drm_sched_entity_destroy() path

2020-10-02 Thread Boris Brezillon
If we don't initialize the entity to idle and the entity is never scheduled before being destroyed we end up with an infinite wait in the destroy path. v2: - Add Steven's R-b Signed-off-by: Boris Brezillon Reviewed-by: Steven Price --- This is something I noticed while debugging another issue

Re: [PATCH v2] drm/sched: Avoid infinite waits in the drm_sched_entity_destroy() path

2020-10-02 Thread Christian König
Am 02.10.20 um 08:55 schrieb Boris Brezillon: If we don't initialize the entity to idle and the entity is never scheduled before being destroyed we end up with an infinite wait in the destroy path. Good catch, of hand I would say that this is valid. v2: - Add Steven's R-b Signed-off-by:

Re: [PATCH v3 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-10-02 Thread Ville Syrjälä
On Fri, Oct 02, 2020 at 02:54:35AM +0530, Tejas Upadhyay wrote: > JSL has update in vswing table for eDP. > > BSpec: 21257 > > Changes since V2 : > - Added IS_EHL_JSL to replace IS_ELKHARTLAKE > - EHL/JSL PCI ids split added > - Changes rebased as per new drm top commit > >

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Greg Kroah-Hartman
On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: > This is a follow-up of this thread: > > https://www.spinics.net/lists/linux-input/msg68446.html lore.kernel.org is easier to pull stuff from :) Anyway, what ever happened to this series? Is there a newer one somewhere?

Re: [PATCH 2/2] drm/ttm: remove no_retry flag

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 1:31 PM Christian König wrote: > > Amdgpu was the only user of this. > > Signed-off-by: Christian König Uh this smells like a fishy band-aid. And the original commit introducing this also doesn't sched any light on why this should happen, and why it's specific to the

[drm-intel:drm-intel-next-queued 14/14] drivers/gpu/drm/i915/display/intel_lspcon.c:533:6: warning: no previous prototype for function 'lspcon_init'

2020-10-02 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: f542d671ffcec772a561cd41c7e2394392d9dafb commit: f542d671ffcec772a561cd41c7e2394392d9dafb [14/14] drm/i915: Init lspcon after HPD in intel_dp_detect() config: x86_64-randconfig-a003-20201001 (attached as .config)

Re: [PATCH 2/4] drm/ttm: rename and move ttm_bo_evict_mm as well

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 11:48 AM Christian König wrote: > > Am 02.10.20 um 11:16 schrieb Daniel Vetter: > > On Fri, Oct 2, 2020 at 11:07 AM Daniel Vetter wrote: > >> On Fri, Oct 2, 2020 at 10:47 AM Christian König > >> wrote: > >>> This function also works with whole device and not individual

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 1:30 PM Christian König wrote: > > Am 02.10.20 um 11:58 schrieb Daniel Vetter: > > On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: > >> On Wed, Sep 30, 2020 at 2:34 PM Christian König > >> wrote: > >>> Am 30.09.20 um 11:47 schrieb Daniel Vetter: > On

Re: [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar wrote: > > Add support to capture the drm atomic state snapshot which > can then be wired up with the devcoredump of the relevant display > errors to give useful information to debug the issues. > > Since the devcoredump is read by usermode and it is

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-02 Thread Daniel Vetter
On Thu, Oct 1, 2020 at 8:02 PM Chrisanthus, Anitha wrote: > > Hi Daniel, > I was finally able to test the driver with 5.9 kernel with minor changes in > the driver. > Ran the igt_vblank test and it passed/skipped all the subtests except the > pipe-A-accuracy-idle test. > Results are attached.

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-02 Thread Daniel Vetter
On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: > On Wed, Sep 30, 2020 at 2:34 PM Christian König > wrote: > > > > Am 30.09.20 um 11:47 schrieb Daniel Vetter: > > > On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: > > >> Am 30.09.20 um 10:19 schrieb Thomas

Re: [PATCH v3 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-10-02 Thread Ville Syrjälä
On Fri, Oct 02, 2020 at 02:54:34AM +0530, Tejas Upadhyay wrote: > Split the basic platform definition, macros, and PCI IDs to > differentiate between EHL and JSL platforms. > > Changes since V2 : > - Added IS_EHL_JSL to replace IS_ELKHARTLAKE > - EHL/JSL PCI ids split added > Changes

Re: linux-next: manual merge of the akpm tree with the drm-intel tree

2020-10-02 Thread Joonas Lahtinen
Quoting Daniel Vetter (2020-10-01 18:13:26) > On Thu, Oct 1, 2020 at 5:08 PM Jani Nikula > wrote: > > > > On Thu, 01 Oct 2020, Daniel Vetter wrote: > > > On Thu, Oct 1, 2020 at 3:53 PM Christoph Hellwig wrote: > > >> > > >> On Thu, Oct 01, 2020 at 08:39:17PM +1000, Stephen Rothwell wrote: > >

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Ville Syrjälä
On Thu, Oct 01, 2020 at 05:25:55PM +0200, Daniel Vetter wrote: > On Thu, Oct 1, 2020 at 5:15 PM Rob Clark wrote: > > > > On Thu, Oct 1, 2020 at 12:25 AM Daniel Vetter wrote: > > > > > > On Wed, Sep 30, 2020 at 11:16 PM Rob Clark wrote: > > > > > > > > From: Rob Clark > > > > > > > > The

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Ville Syrjälä
On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > On Thu, Oct 01, 2020 at 05:25:55PM +0200, Daniel Vetter wrote: > > On Thu, Oct 1, 2020 at 5:15 PM Rob Clark wrote: > > > > > > On Thu, Oct 1, 2020 at 12:25 AM Daniel Vetter wrote: > > > > > > > > On Wed, Sep 30, 2020 at 11:16 PM

[PATCH 1/2] drm/ttm: remove need_dma32 flag

2020-10-02 Thread Christian König
Drivers can just set the DMA32 flag in their TT creation function. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 +-- drivers/gpu/drm/drm_gem_vram_helper.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo.c| 6 +- drivers/gpu/drm/nouveau/nouveau_ttm.c

[PATCH 2/2] drm/ttm: remove no_retry flag

2020-10-02 Thread Christian König
Amdgpu was the only user of this. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- drivers/gpu/drm/ttm/ttm_tt.c| 3 --- include/drm/ttm/ttm_device.h| 2 -- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git

Re: [RFC PATCH 0/4] Add a RPMsg driver to support AI Processing Unit (APU)

2020-10-02 Thread Daniel Vetter
On Thu, Oct 01, 2020 at 07:28:27PM +0200, Alexandre Bailon wrote: > Hi Daniel, > > On 10/1/20 10:48 AM, Daniel Vetter wrote: > > On Wed, Sep 30, 2020 at 01:53:46PM +0200, Alexandre Bailon wrote: > > > This adds a RPMsg driver that implements communication between the CPU > > > and an > > > APU.

Re: [PATCH v2] drm/panfrost: Fix job timeout handling

2020-10-02 Thread Steven Price
On 02/10/2020 08:10, Boris Brezillon wrote: If more than two jobs end up timeout-ing concurrently, only one of them (the one attached to the scheduler acquiring the lock) is fully handled. The other one remains in a dangling state where it's no longer part of the scheduling queue, but still

Re: [PATCH RFC 0/1] drm/ttm: Allocate transparent huge pages without clearing __GFP_COMP

2020-10-02 Thread Christian König
Hi Alex, adding Daniel as well. Am 01.10.20 um 20:45 schrieb Alex Goins: Hi Christian, On Thu, 1 Oct 2020, Christian König wrote: Hi Alex, first of all accessing the underlying page of an exported DMA-buf is illegal! So I'm not 100% sure what you're intentions are here, please explain

[drm-intel:drm-intel-next-queued 14/14] drivers/gpu/drm/i915/display/intel_lspcon.c:533:6: error: no previous prototype for function 'lspcon_init'

2020-10-02 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: f542d671ffcec772a561cd41c7e2394392d9dafb commit: f542d671ffcec772a561cd41c7e2394392d9dafb [14/14] drm/i915: Init lspcon after HPD in intel_dp_detect() config: x86_64-randconfig-a005-20201001 (attached as .config)

[PATCH 4/4] drm/vmwgfx: move ttm_bo_swapout_all into vmwgfx

2020-10-02 Thread Christian König
It is the sole user of this. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 11 --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 6 +- include/drm/ttm/ttm_bo_api.h| 1 - 3 files changed, 5 insertions(+), 13 deletions(-) diff --git

[PATCH 2/4] drm/ttm: rename and move ttm_bo_evict_mm as well

2020-10-02 Thread Christian König
This function also works with whole device and not individual BOs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- drivers/gpu/drm/qxl/qxl_object.c

[PATCH 3/4] drm/ttm: drop glob parameter from ttm_bo_swapout

2020-10-02 Thread Christian König
We can always access the global state. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 +++-- drivers/gpu/drm/ttm/ttm_memory.c | 2 +- include/drm/ttm/ttm_bo_api.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-02 Thread Christian König
Am 02.10.20 um 11:58 schrieb Daniel Vetter: On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: On Wed, Sep 30, 2020 at 2:34 PM Christian König wrote: Am 30.09.20 um 11:47 schrieb Daniel Vetter: On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: Am 30.09.20 um 10:19

Re: [PATCH v2] drm/panfrost: Fix job timeout handling

2020-10-02 Thread Boris Brezillon
On Fri, 2 Oct 2020 09:10:32 +0200 Boris Brezillon wrote: > @@ -392,19 +411,41 @@ static void panfrost_job_timedout(struct drm_sched_job > *sched_job) > job_read(pfdev, JS_TAIL_LO(js)), > sched_job); > > + /* Scheduler is already stopped, nothing to do. */ > +

[PATCH v2] drm/panfrost: Fix job timeout handling

2020-10-02 Thread Boris Brezillon
If more than two jobs end up timeout-ing concurrently, only one of them (the one attached to the scheduler acquiring the lock) is fully handled. The other one remains in a dangling state where it's no longer part of the scheduling queue, but still blocks something in scheduler, leading to

Re: [PATCH 2/4] drm/ttm: rename and move ttm_bo_evict_mm as well

2020-10-02 Thread Christian König
Am 02.10.20 um 11:16 schrieb Daniel Vetter: On Fri, Oct 2, 2020 at 11:07 AM Daniel Vetter wrote: On Fri, Oct 2, 2020 at 10:47 AM Christian König wrote: This function also works with whole device and not individual BOs. Signed-off-by: Christian König This doesn't operate on the device, but

Re: [PATCH v3 1/7] drm/vram-helper: Remove invariant parameters from internal kmap function

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:31PM +0200, Thomas Zimmermann wrote: > The parameters map and is_iomem are always of the same value. Removed them > to prepares the function for conversion to struct dma_buf_map. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter > --- >

Re: [PATCH v2] drm/sched: Avoid infinite waits in the drm_sched_entity_destroy() path

2020-10-02 Thread Boris Brezillon
On Fri, 2 Oct 2020 10:31:31 +0200 Christian König wrote: > Am 02.10.20 um 08:55 schrieb Boris Brezillon: > > If we don't initialize the entity to idle and the entity is never > > scheduled before being destroyed we end up with an infinite wait in the > > destroy path. > > Good catch, of hand

Re: [PATCH RFC 0/1] drm/ttm: Allocate transparent huge pages without clearing __GFP_COMP

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 8:41 AM Christian König wrote: > > Hi Alex, > > adding Daniel as well. > > Am 01.10.20 um 20:45 schrieb Alex Goins: > > Hi Christian, > > > > On Thu, 1 Oct 2020, Christian König wrote: > > > >> Hi Alex, > >> > >> first of all accessing the underlying page of an exported

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 03:42:52PM +0200, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: > > On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: > > > Userland might want to execute e.g. 'w' (show blocked tasks), followed > > > by

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
Hi, W dniu 02.10.2020 o 16:02, Greg Kroah-Hartman pisze: On Fri, Oct 02, 2020 at 03:42:52PM +0200, Andrzej Pietrasiewicz wrote: Hi, W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: Userland might want to execute e.g.

Re: [PATCH v3 4/7] drm/gem: Update internal GEM vmap/vunmap interfaces to use struct dma_buf_map

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:34PM +0200, Thomas Zimmermann wrote: > GEM's vmap and vunmap interfaces now wrap memory pointers in struct > dma_buf_map. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_client.c | 18 +++--- > drivers/gpu/drm/drm_gem.c | 28

Re: [PATCH v3 5/7] drm/gem: Store client buffer mappings as struct dma_buf_map

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:35PM +0200, Thomas Zimmermann wrote: > Kernel DRM clients now store their framebuffer address in an instance > of struct dma_buf_map. Depending on the buffer's location, the address > refers to system or I/O memory. > > Callers of drm_client_buffer_vmap() receive a

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
W dniu 02.10.2020 o 14:33, Andrzej Pietrasiewicz pisze: W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html lore.kernel.org is

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Dave Stevenson
Hi Maxime On Fri, 2 Oct 2020 at 16:19, Maxime Ripard wrote: > > Hi Tim, > > On Thu, Oct 01, 2020 at 11:15:46AM +0100, Tim Gover wrote: > > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > > VCO to support a core-frequency of 550 MHz which is the minimum > > frequency

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 02:45:29PM +0200, Daniel Vetter wrote: > On Fri, Oct 02, 2020 at 02:36:33PM +0200, Andrzej Pietrasiewicz wrote: > > W dniu 02.10.2020 o 14:33, Andrzej Pietrasiewicz pisze: > > > W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: > > > > On Tue, Aug 18, 2020 at 01:28:23PM

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Greg Kroah-Hartman
On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: > Userland might want to execute e.g. 'w' (show blocked tasks), followed > by 's' (sync), followed by 1000 ms delay and then followed by 'c' (crash) > upon a single magic SysRq. Or one might want to execute the famous "Raising

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
Hi, W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: Userland might want to execute e.g. 'w' (show blocked tasks), followed by 's' (sync), followed by 1000 ms delay and then followed by 'c' (crash) upon a single magic

Re: [PATCH] drm/atomic: Make the kerneldoc a bit clearer

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 2:31 PM Maxime Ripard wrote: > > Hi, > > On Fri, Oct 02, 2020 at 09:56:20AM +0200, Daniel Vetter wrote: > > Crank up the warning a notch and point at the right set of locking > > functions for atomic drivers. > > > > Signed-off-by: Daniel Vetter > > Cc: Maarten Lankhorst

Re: [PATCH v3 3/7] drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:33PM +0200, Thomas Zimmermann wrote: > This patch replaces the vmap/vunmap's use of raw pointers in GEM object > functions with instances of struct dma_buf_map. GEM backends are > converted as well. > > For most GEM backends, this simply change the returned type. GEM

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Daniel Vetter
On Fri, Oct 02, 2020 at 02:36:33PM +0200, Andrzej Pietrasiewicz wrote: > W dniu 02.10.2020 o 14:33, Andrzej Pietrasiewicz pisze: > > W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: > > > On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: > > > > This is a follow-up of this

Re: [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 11:54 AM Daniel Vetter wrote: > > On Fri, Oct 02, 2020 at 10:22:42AM -0700, Rob Clark wrote: > > On Fri, Oct 2, 2020 at 12:36 AM Daniel Vetter wrote: > > > > > > On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar > > > wrote: > > > > > > > > Add support to capture the drm

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi86: Expose backlight controls

2020-10-02 Thread Doug Anderson
Hi, On Wed, Sep 30, 2020 at 3:40 PM Bjorn Andersson wrote: > > The TI SN65DSI86 can be configured to generate a PWM pulse on GPIO4, > to be used to drive a backlight driver. > > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/bridge/Kconfig| 1 + >

[PATCH] drm/bridge: ti-sn65dsi86: Add retries for link training

2020-10-02 Thread Douglas Anderson
On some panels hooked up to the ti-sn65dsi86 bridge chip we found that link training was failing. Specifically, we'd see: ti_sn65dsi86 2-002d: [drm:ti_sn_bridge_enable] *ERROR* Link training failed, link is off (-5) The panel was hooked up to a logic analyzer and it was found that, as part

[PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-02 Thread Rob Herring
Another round of wack-a-mole. The json-schema default is additional unknown properties are allowed, but for DT all properties should be defined. Cc: Thierry Reding Cc: Linus Walleij Cc: Stephen Boyd Cc: Shawn Guo Cc: Bjorn Andersson Cc: Baolin Wang Cc: Guenter Roeck Cc: Jonathan Cameron

[PATCH v8 0/4] Add support for KeemBay DRM driver

2020-10-02 Thread Anitha Chrisanthus
This is a new DRM driver for Intel's KeemBay SOC. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. This driver is tested with the KMB EVM board which is the refernce baord for Keem Bay SOC. The SOC's display pipeline is as follows +--++-+

[PATCH v8 1/4] drm/kmb: Keem Bay driver register definition

2020-10-02 Thread Anitha Chrisanthus
Register definitions for Keem Bay display driver v2: removed license text (Sam) v3: Squashed all 59 commits to one v4: review changes from Sam Ravnborg renamed dev_p to kmb v5: corrected spellings v6: corrected checkpatch warnings Cc: Sam Ravnborg Signed-off-by: Anitha Chrisanthus

[PATCH v8 2/4] drm/kmb: Add support for KeemBay Display

2020-10-02 Thread Anitha Chrisanthus
This is a basic KMS atomic modesetting display driver for KeemBay family of SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge driver at the connector level. Single CRTC with LCD controller->mipi DSI-> ADV bridge Only 1080p resolution and single plane is supported at this time.

[PATCH v8 3/4] drm/kmb: Mipi DSI part of the display driver

2020-10-02 Thread Anitha Chrisanthus
Initializes Mipi DSI and sets up connects to ADV bridge v2: removed license text upclassed dev_private, removed HAVE_IRQ. (Sam) v3: Squashed all 59 commits to one v4: review changes from Sam Ravnborg renamed dev_p to kmb v5: corrected spellings v6: corrected checkpatch warnings v7:

[PATCH v8 4/4] drm/kmb: Build files for KeemBay Display driver

2020-10-02 Thread Anitha Chrisanthus
v2: Added Maintainer entry Cc: Sam Ravnborg Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- MAINTAINERS | 6 ++ drivers/gpu/drm/Kconfig | 2 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/kmb/Kconfig | 13 +

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-02 Thread John Hubbard
On 10/2/20 10:53 AM, Daniel Vetter wrote: For $reasons I've stumbled over this code and I'm not sure the change to the new gup functions in 55a650c35fea ("mm/gup: frame_vector: convert get_user_pages() --> pin_user_pages()") was entirely correct. This here is used for long term buffers (not

[PATCH] dt-bindings: display: Add dsi-controller.yaml in DSI controller schemas

2020-10-02 Thread Rob Herring
Some DSI controllers are missing a reference to the recently added dsi-controller.yaml schema. Add it and we can drop the duplicate parts. Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Eric Anholt Cc: Nicolas Saenz Julienne Cc: Florian Fainelli Cc: Ray Jui Cc: Scott Branden Cc:

Re: [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 12:36 AM Daniel Vetter wrote: > > On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar wrote: > > > > Add support to capture the drm atomic state snapshot which > > can then be wired up with the devcoredump of the relevant display > > errors to give useful information to debug the

[PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames()

2020-10-02 Thread Daniel Vetter
FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for simple dma device that can't guarantee write protection. Which is also what all the callers are using. So just simplify this. Signed-off-by: Daniel Vetter Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park

[PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-02 Thread Daniel Vetter
For $reasons I've stumbled over this code and I'm not sure the change to the new gup functions in 55a650c35fea ("mm/gup: frame_vector: convert get_user_pages() --> pin_user_pages()") was entirely correct. This here is used for long term buffers (not just quick I/O) like RDMA, and John notes this

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä wrote: > > On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 01, 2020 at 05:25:55PM +0200, Daniel Vetter wrote: > > > On Thu, Oct 1, 2020 at 5:15 PM Rob Clark wrote: > > > > > > > > On Thu, Oct 1, 2020 at 12:25 AM Daniel

Re: [PATCH v3 6/7] drm/fb_helper: Support framebuffers in I/O memory

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:36PM +0200, Thomas Zimmermann wrote: > At least sparc64 requires I/O-specific access to framebuffers. This > patch updates the fbdev console accordingly. > > For drivers with direct access to the framebuffer memory, the callback > functions in struct fb_ops test for

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 8:06 PM Jason Gunthorpe wrote: > On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > > For $reasons I've stumbled over this code and I'm not sure the change > > to the new gup functions in 55a650c35fea ("mm/gup: frame_vector: > > convert get_user_pages() -->

Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames()

2020-10-02 Thread Oded Gabbay
On Fri, Oct 2, 2020 at 9:23 PM Tomasz Figa wrote: > > On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > > simple dma device that can't guarantee write protection. Which is also > > what all the callers are using. >

[PATCH][next] drm/i915: fix size_t greater or equal to zero comparison

2020-10-02 Thread Colin King
From: Colin Ian King Currently the check that the unsigned size_t variable i is >= 0 is always true because the unsigned variable will never be negative, causing the loop to run forever. Fix this by changing the pre-decrement check to a zero check on i followed by a decrement of i.

Re: [PATCH v3 6/7] drm/fb_helper: Support framebuffers in I/O memory

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 8:05 PM Daniel Vetter wrote: > > On Tue, Sep 29, 2020 at 05:14:36PM +0200, Thomas Zimmermann wrote: > > At least sparc64 requires I/O-specific access to framebuffers. This > > patch updates the fbdev console accordingly. > > > > For drivers with direct access to the

Re: [PATCH v3 7/7] drm/todo: Update entries around struct dma_buf_map

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:37PM +0200, Thomas Zimmermann wrote: > Instances of struct dma_buf_map should be useful throughout DRM's > memory management code. Furthermore, several drivers can now use > generic fbdev emulation. > > Signed-off-by: Thomas Zimmermann Acked-by: Daniel Vetter >

[PULL] drm-intel-next-fixes

2020-10-02 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes our first next-fixes. Please be aware this includes both drm-intel-next and drm-intel-gt-next. Also, most of patches from drm-intel-gt-next were accumulated for not being part of current drm-intel-fixes flow while we are defining the new split and flow. So, there

Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames()

2020-10-02 Thread Tomasz Figa
On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > simple dma device that can't guarantee write protection. Which is also > what all the callers are using. > > So just simplify this. > > Signed-off-by: Daniel Vetter >

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 4:01 AM Qais Yousef wrote: > > On 09/30/20 14:17, Rob Clark wrote: > > From: Rob Clark > > > > The android userspace treats the display pipeline as a realtime problem. > > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > > it is. (See

Re: [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Daniel Vetter
On Fri, Oct 02, 2020 at 10:22:42AM -0700, Rob Clark wrote: > On Fri, Oct 2, 2020 at 12:36 AM Daniel Vetter wrote: > > > > On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar > > wrote: > > > > > > Add support to capture the drm atomic state snapshot which > > > can then be wired up with the

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi86: Replace #pwm-cells

2020-10-02 Thread Doug Anderson
Hi, On Wed, Sep 30, 2020 at 3:40 PM Bjorn Andersson wrote: > > While the signal on GPIO4 to drive the backlight controller indeed is > pulse width modulated its purpose is specifically to control the > brightness of a backlight. I'm a bit on the fence about this. I guess you're doing this

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-02 Thread Chrisanthus, Anitha
> -Original Message- > From: Daniel Vetter > Sent: Friday, October 2, 2020 2:19 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > On Thu,

[PATCH v3 3/7] dma-buf: heaps: Remove heap-helpers code

2020-10-02 Thread John Stultz
The heap-helpers code was not as generic as initially hoped and it is now not being used, so remove it from the tree. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc:

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-02 Thread Chun-Kuang Hu
Hi, Jassi: Jassi Brar 於 2020年10月3日 週六 上午4:30寫道: > > On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > > > CMDQ helper provide timer to detect execution timeout, but DRM driver > > could have a better way to detect execution timeout by vblank IRQ. > > For DRM, CMDQ command should execute

[PATCH v3 1/7] dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists

2020-10-02 Thread John Stultz
In preparation for some patches to optmize the system heap code, rework the dmabuf exporter to utilize sgtables rather then pageslists for tracking the associated pages. This will allow for large order page allocations, as well as more efficient page pooling. In doing so, the system heap stops

[PATCH v3 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-10-02 Thread John Stultz
Hey All, So this is another revision of my patch series to performance optimizations to the dma-buf system heap. Unfortunately, in working these up, I realized the heap-helpers infrastructure we tried to add to miniimize code duplication is not as generic as we intended. For some heaps it makes

[PATCH v3 5/7] dma-buf: system_heap: Allocate higher order pages if available

2020-10-02 Thread John Stultz
While the system heap can return non-contiguous pages, try to allocate larger order pages if possible. This will allow slight performance gains and make implementing page pooling easier. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren

[PATCH v3 6/7] dma-buf: dma-heap: Keep track of the heap device struct

2020-10-02 Thread John Stultz
Keep track of the heap device struct. This will be useful for special DMA allocations and actions. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc: Ørjan Eide Cc:

[PATCH v3 4/7] dma-buf: heaps: Skip sync if not mapped

2020-10-02 Thread John Stultz
This patch is basically a port of Ørjan Eide's similar patch for ION https://lore.kernel.org/lkml/20200414134629.54567-1-orjan.e...@arm.com/ Only sync the sg-list of dma-buf heap attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be

[PATCH v3 2/7] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

2020-10-02 Thread John Stultz
Since the heap-helpers logic ended up not being as generic as hoped, move the heap-helpers dma_buf_ops implementations into the cma_heap directly. This will allow us to remove the heap_helpers code in a following patch. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc:

[PATCH v3 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-02 Thread John Stultz
This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU. This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping the buffer over and over between devices,