[PATCH 01/13] drm/ttm: nuke ttm_tt_set_(un)populated again

2020-10-25 Thread Christian König
Neither page allocation backend nor the driver should mess with that. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 -- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - drivers/gpu/drm/radeon/radeon_ttm.c | 2 -- drivers/gpu/drm/ttm/ttm_page_alloc.c |

[PATCH 11/13] drm/qxl: drop ttm_page_alloc.h include

2020-10-25 Thread Christian König
Not needed as far as I can see. Signed-off-by: Christian König --- drivers/gpu/drm/qxl/qxl_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index d8ecfb8b3193..a80d59634143 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++ b/driv

[PATCH 10/13] drm/vmwgfx: switch to new allocator

2020-10-25 Thread Christian König
It should be able to handle all cases now. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c| 4 --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 36 ++ 2 files changed, 3 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx

[PATCH 03/13] drm/ttm: make num_pages uint32_t

2020-10-25 Thread Christian König
We can still allocate 16TiB with that. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 +- drivers/gpu/drm/nouveau/nouveau_ttm.c | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- include/drm/ttm/ttm_tt.h| 2 +- 4 files changed,

drm/ttm: new TT backend allocation pool

2020-10-25 Thread Christian König
This replaces the spaghetti code in the two existing page pools. First of all depending on the allocation size it is between 3 (1GiB) and 5 (1MiB) times faster than the old implementation. It makes better use of buddy pages to allow for larger physical contiguous allocations which should

[PATCH 08/13] drm/radeon: switch to new allocator

2020-10-25 Thread Christian König
It should be able to handle all cases here. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 47 + 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index

[PATCH 05/13] drm/ttm: new TT backend allocation pool

2020-10-25 Thread Christian König
This replaces the spaghetti code in the two existing page pools. First of all depending on the allocation size it is between 3 (1GiB) and 5 (1MiB) times faster than the old implementation. It makes better use of buddy pages to allow for larger physical contiguous allocations which should result i

[PATCH 02/13] drm/ttm: move swapin out of page alloc backend

2020-10-25 Thread Christian König
This is not related to allocating the backing store in any way. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 8 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 8 drivers/gpu/drm/ttm/ttm_tt.c | 8 3 files changed, 8 insertions(+)

[PATCH 09/13] drm/nouveau: switch to new allocator

2020-10-25 Thread Christian König
It should be able to handle all cases now. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 30 ++- drivers/gpu/drm/nouveau/nouveau_drv.h | 1 - 2 files changed, 2 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c

[PATCH 07/13] drm/amdgpu: switch to new allocator

2020-10-25 Thread Christian König
It should be able to handle all cases here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 39 + 1 file changed, 14 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.

[PATCH 12/13] drm/vram_helpers: drop ttm_page_alloc.h include

2020-10-25 Thread Christian König
Not needed as far as I can see. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_vram_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 4442c9c23ff2..bd4a5740a038 100644 --- a/drivers/gpu/drm

[PATCH 13/13] drm/ttm: nuke old page allocator

2020-10-25 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/Kconfig |7 - drivers/gpu/drm/ttm/Makefile |3 +- drivers/gpu/drm/ttm/ttm_agp_backend.c|1 - drivers/gpu/drm/ttm/ttm_bo.c |1 - drivers/gpu/drm/ttm/ttm_memory.c

[PATCH 06/13] drm/ttm: wire up the new pool as default one

2020-10-25 Thread Christian König
Provide the necessary parameters by all drivers and use the new pool alloc when no driver specific function is provided. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- drivers/gpu/drm/drm_gem_vram_helper.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_ttm.c

[PATCH 04/13] drm/ttm: merge ttm_dma_tt back into ttm_tt

2020-10-25 Thread Christian König
It makes no difference to kmalloc if the structure is 48 or 64 bytes in size. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c| 10 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 14 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 +-- drivers/gpu/drm/nouv

Re: [RESEND PATCH v5 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-25 Thread Sam Ravnborg
Hi Lubomir. > > > +static int hx8837_bl_update_status(struct backlight_device *bl) > > > +{ > > > + struct hx8837_priv *priv = bl_get_data(bl); > > > + unsigned int val; > > > + int ret; > > > + > > > + ret = regmap_update_bits(priv->regmap, DCON_REG_BRIGHT, > > > +

Re: [PATCH] Implement .format_mod_supported in mxsfb

2020-10-25 Thread Guido Günther
Hi Daniel, On Sat, Oct 24, 2020 at 04:59:16PM +, Daniel Abrecht wrote: > This will make sure applications which use the IN_FORMATS blob > to figure out which modifiers they can use will pick up the > linear modifier which is needed by mxsfb. Such applications > will not work otherwise if an inc

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-25 Thread Rob Clark
On Thu, Oct 22, 2020 at 1:06 AM Viresh Kumar wrote: > > On 20-10-20, 07:13, Rob Clark wrote: > > On Tue, Oct 20, 2020 at 4:24 AM Viresh Kumar > > wrote: > > > > > > On 20-10-20, 12:56, Daniel Vetter wrote: > > > > Yeah that's bad practice. Generally you shouldn't need to hold locks > > > > in se

Re: [PATCH 05/13] drm/ttm: new TT backend allocation pool

2020-10-25 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.9 next-20201023] [If your patch is applied to the wrong git

[RFC PATCH] drm/ttm: ttm_pool_apply_caching() can be static

2020-10-25 Thread kernel test robot
Signed-off-by: kernel test robot --- ttm_pool.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 86bd173d93a52..a7818b3cd7c6e 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm

Re: [PATCH 05/13] drm/ttm: new TT backend allocation pool

2020-10-25 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.9 next-20201023] [If your patch is applied to the wrong git

Re: [PATCH 4/5] drm: Allow const struct drm_driver

2020-10-25 Thread Sam Ravnborg
On Fri, Oct 23, 2020 at 02:28:10PM +0200, Daniel Vetter wrote: > It's nice if a big function/ioctl table like this is const. Only > downside here is that we need a few more #ifdef to paper over the > differences when CONFIG_DRM_LEGACY is enabled. Maybe provides more > motivation to sunset that horr

Re: [PATCH 2/5] drm: Compile out legacy chunks from struct drm_device

2020-10-25 Thread Sam Ravnborg
On Fri, Oct 23, 2020 at 02:28:08PM +0200, Daniel Vetter wrote: > This means some very few #ifdef in code, but it allows us to > enlist the compiler to make sure this stuff isn't used anymore. > > More important, only legacy drivers change drm_device (for the > legacy_dev_list shadow attach managem

Re: [PATCH] drm/: Constify struct drm_driver

2020-10-25 Thread Sam Ravnborg
Hi Daniel. On Fri, Oct 23, 2020 at 06:04:44PM +0200, Daniel Vetter wrote: > Only the following drivers aren't converted: > - amdgpu, because of the driver_feature mangling due to virt support > - nouveau, because DRIVER_ATOMIC uapi is still not the default on the > platforms where it's supported

Re: [PATCH] drm/: Constify struct drm_driver

2020-10-25 Thread Daniel Vetter
On Sun, Oct 25, 2020 at 11:23 PM Sam Ravnborg wrote: > > Hi Daniel. > > On Fri, Oct 23, 2020 at 06:04:44PM +0200, Daniel Vetter wrote: > > Only the following drivers aren't converted: > > - amdgpu, because of the driver_feature mangling due to virt support > > - nouveau, because DRIVER_ATOMIC uapi

[PATCH v2] drm: mxsfb: Implement .format_mod_supported

2020-10-25 Thread Daniel Abrecht
This will make sure applications which use the IN_FORMATS blob to figure out which modifiers they can use will pick up the linear modifier which is needed by mxsfb. Such applications will not work otherwise if an incompatible implicit modifier ends up being selected. Before commit ae1ed0093281 ("

Re: [PATCH AUTOSEL 5.9 090/111] drm/amd/display: Fix a list corruption

2020-10-25 Thread Sasha Levin
On Mon, Oct 19, 2020 at 08:40:36AM -0400, Alex Deucher wrote: On Sun, Oct 18, 2020 at 3:19 PM Sasha Levin wrote: From: xinhui pan [ Upstream commit 1545fbf97eafc1dbdc2923e58b4186b16a834784 ] Remove the private obj from the internal list before we free aconnector. [ 56.925828] BUG: unable

Re: [PATCH] Implement .format_mod_supported in mxsfb

2020-10-25 Thread Daniel Abrecht
Hi Guido Am 2020-10-25 15:52, schrieb Guido Günther: Since this got broken by the switch away for the simple display pipeline helper (ae1ed0093281939b80664a687689f12436c0e874) could you add a fixes tag? Cheers, -- Guido Thanks, I've sent a v2 with the fixes tag added. Regards, Daniel Abrecht

Re: [PATCH v6 47/52] PM / devfreq: tegra20: Silence deferred probe error

2020-10-25 Thread Chanwoo Choi
On 10/26/20 7:17 AM, Dmitry Osipenko wrote: > Tegra EMC driver was turned into a regular kernel driver, meaning that it > could be compiled as a loadable kernel module now. Hence EMC clock isn't > guaranteed to be available and clk_get("emc") may return -EPROBE_DEFER. > Let's silence the deferred p

Re: [PATCH v6 50/52] PM / devfreq: tegra30: Silence deferred probe error

2020-10-25 Thread Chanwoo Choi
On 10/26/20 7:17 AM, Dmitry Osipenko wrote: > Tegra EMC driver was turned into a regular kernel driver, meaning that it > could be compiled as a loadable kernel module now. Hence EMC clock isn't > guaranteed to be available and clk_get("emc") may return -EPROBE_DEFER. > Let's silence the deferred p

Re: [PATCH v6 48/52] PM / devfreq: tegra20: Relax Kconfig dependency

2020-10-25 Thread Chanwoo Choi
On 10/26/20 7:17 AM, Dmitry Osipenko wrote: > The Tegra EMC driver now could be compiled as a loadable kernel module. > Currently devfreq driver depends on the EMC/MC drivers in Kconfig, and > thus, devfreq is forced to be a kernel module if EMC is compiled as a > module. This build dependency coul

Re: [PATCH 01/13] drm/ttm: nuke ttm_tt_set_(un)populated again

2020-10-25 Thread Dave Airlie
For 1,2,3,4 Reviewed-by: Dave Airlie should land those quicker, I'll dig a bit more into the others. Dave. On Mon, 26 Oct 2020 at 01:41, Christian König wrote: > > Neither page allocation backend nor the driver should mess with that. > > Signed-off-by: Christian König > --- > drivers/gpu/dr

Re: drm/ttm: new TT backend allocation pool

2020-10-25 Thread Dave Airlie
On Mon, 26 Oct 2020 at 01:41, Christian König wrote: > > This replaces the spaghetti code in the two existing page pools. > > First of all depending on the allocation size it is between 3 (1GiB) and > 5 (1MiB) times faster than the old implementation. > > It makes better use of buddy pages to allo