Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()

2022-03-07 Thread Arunpravin
Reviewed-by:Arunpravin On 07/03/22 6:24 pm, Dan Carpenter wrote: > Set the error code to -ENOMEM if drm_random_order() fails. > > Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- > 1

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Matthew Wilcox
On Sun, Mar 06, 2022 at 03:41:54PM -0800, Dave Hansen wrote: > In short: page faults stink. The core kernel has lots of ways of > avoiding page faults like madvise(MADV_WILLNEED) or mmap(MAP_POPULATE). > But, those only work on normal RAM that the core mm manages. > > SGX is weird. SGX memory

[PATCH] drm: remove min_order BUG_ON check

2022-03-07 Thread Arunpravin
place BUG_ON(order < min_order) outside do..while loop as it fails Unigine Heaven benchmark. Unigine Heaven has buffer allocation requests for example required pages are 161 and alignment request is 128. To allocate the remaining 33 pages, continues the iteration to find the order value which is

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread David Hildenbrand
On 07.03.22 15:22, Jarkko Sakkinen wrote: > On Mon, Mar 07, 2022 at 11:12:44AM +0100, David Hildenbrand wrote: >> On 06.03.22 06:32, Jarkko Sakkinen wrote: >>> For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow >>> to use that for initializing the device memory by providing

Re: [PATCH] simpldrm: Enable boot time VESA graphic mode selection.

2022-03-07 Thread Javier Martinez Canillas
On 3/4/22 21:47, Javier Martinez Canillas wrote: > Hello Thomas, > > On 3/4/22 21:00, Thomas Zimmermann wrote: >> Hi, >> >> I've merged the patches into drm-misc-fixes. Thanks a lot to both of you. >> > > Ard already picked these through the efi tree: > >

Re: [PATCH v3 2/6] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-07 Thread Hellstrom, Thomas
On Mon, 2022-03-07 at 19:10 +0530, Ramalingam C wrote: > Xe-HP and latest devices support Flat CCS which reserved a portion of > the device memory to store compression metadata, during the clearing > of > device memory buffer object we also need to clear the associated > CCS buffer. > >

Re: [PATCH v3 1/6] drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+

2022-03-07 Thread Hellstrom, Thomas
Hi, Ram. Typo in patch title FASR/FAST On Mon, 2022-03-07 at 19:10 +0530, Ramalingam C wrote: > XY_FAST_COLOR_BLT cmd is faster than the older XY_COLOR_BLT. Hence > for > clearing (Zero out) the pages of the newly allocated object, faster > cmd > is used. > > Signed-off-by: Ramalingam C >

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 11:12:44AM +0100, David Hildenbrand wrote: > On 06.03.22 06:32, Jarkko Sakkinen wrote: > > For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow > > to use that for initializing the device memory by providing a new callback > > f_ops->populate() for the

[PATCH v3 6/6] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-07 Thread Ramalingam C
When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content. When lmem object is swapped into a smem obj, smem obj will have the extra pages required to hold the

[PATCH v3 5/6] drm/i915/gt: Optimize the migration loop

2022-03-07 Thread Ramalingam C
Move the static calculations out of the loop. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 34 - 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c

[PATCH v3 4/6] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-07 Thread Ramalingam C
On Xe-HP and later devices, dedicated compression control state (CCS) stored in local memory is used for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the

[PATCH v3 3/6] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-03-07 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Christian Konig

[PATCH v3 2/6] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-07 Thread Ramalingam C
Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. XY_FAST_COLOR_BLT cmd provides a option to clear the ccs metadata

[PATCH v3 1/6] drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+

2022-03-07 Thread Ramalingam C
XY_FAST_COLOR_BLT cmd is faster than the older XY_COLOR_BLT. Hence for clearing (Zero out) the pages of the newly allocated object, faster cmd is used. Signed-off-by: Ramalingam C Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 ++

[PATCH v3 0/6] drm/i915/ttm: Evict and restore of compressed object

2022-03-07 Thread Ramalingam C
On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the

[PATCH] drm/msm/adreno: fix cast in adreno_get_param()

2022-03-07 Thread Dan Carpenter
These casts need to happen before the shift. The only time it would matter would be if "rev.core" is >= 128. In that case the sign bit would be extended and we do not want that. Fixes: afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace") Signed-off-by: Dan Carpenter ---

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 11:48:26PM -0800, Christoph Hellwig wrote: > On Sun, Mar 06, 2022 at 11:33:02AM +, Matthew Wilcox wrote: > > On Sun, Mar 06, 2022 at 07:32:04AM +0200, Jarkko Sakkinen wrote: > > > For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow > > > to use

Re: [PATCH RFC 1/3] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 03:16:57PM +0200, Jarkko Sakkinen wrote: > On Sun, Mar 06, 2022 at 10:43:31PM +, Matthew Wilcox wrote: > > On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote: > > > So can I conclude from this that in general having populate available for > > > device

Re: [PATCH] omapfb: Add missing of_node_put() in dvic_probe_of

2022-03-07 Thread Helge Deller
On 3/7/22 13:38, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") > Signed-off-by: Miaoqian Lin applied to the fbdev

Re: [PATCH RFC 1/3] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 10:43:31PM +, Matthew Wilcox wrote: > On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote: > > So can I conclude from this that in general having populate available for > > device memory is something horrid, or just the implementation path? > > You haven't

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-07 Thread Daniel Stone
Hi Andy, On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > On 2/25/22 15:51, Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 03:24:56PM -0800, Andrew Morton wrote: > On Sun, 6 Mar 2022 05:26:55 +0200 Jarkko Sakkinen wrote: > > > Sometimes you might want to use MAP_POPULATE to ask a device driver to > > initialize the device memory in some specific manner. SGX driver can use > > this to request

Re: [PATCH 5.15 000/262] 5.15.27-rc1 review

2022-03-07 Thread Naresh Kamboju
On Mon, 7 Mar 2022 at 15:07, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.15.27 release. > There are 262 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

[PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()

2022-03-07 Thread Dan Carpenter
Set the error code to -ENOMEM if drm_random_order() fails. Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-07 Thread Sascha Hauer
Hi Andy, On Mon, Mar 07, 2022 at 08:18:08PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/25/22 15:51, Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > >

[PATCH] omapfb: Add missing of_node_put() in dvic_probe_of

2022-03-07 Thread Miaoqian Lin
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") Signed-off-by: Miaoqian Lin --- drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 1 +

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-07 Thread Andy Yan
Hi Sascha: On 2/25/22 15:51, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All

Re: [PATCH v7 15/24] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz

2022-03-07 Thread Andy Yan
Hi:  I have a test with the 24 patches applied on Linux-5.17-rc5 on rk3568-evb1-v10 board with Sony XR-75z9j  HDMI TV, 4K don't work, the tv shows no signal. 1080P can work. On 2/25/22 15:51, Sascha Hauer wrote: From: Nickey Yang add 594Mhz configuration parameters in rockchip_phy_config

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 03:41:54PM -0800, Dave Hansen wrote: > On 3/6/22 15:24, Andrew Morton wrote: > > On Sun, 6 Mar 2022 05:26:55 +0200 Jarkko Sakkinen > > wrote: > > > >> Sometimes you might want to use MAP_POPULATE to ask a device driver to > >> initialize the device memory in some

Re: [PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-07 Thread Matthew Auld
On 04/03/2022 19:33, Ville Syrjälä wrote: On Fri, Mar 04, 2022 at 05:23:32PM +, Matthew Auld wrote: The offset we get looks to be the exact start of DSM, but the inital_plane_vma expects the address to be relative. Signed-off-by: Matthew Auld Cc: Thomas Hellström ---

Re: [PATCH] drm: Drop commas after SoC match table sentinels

2022-03-07 Thread Neil Armstrong
Hi, On Thu, 3 Mar 2022 13:44:56 +0100, Geert Uytterhoeven wrote: > It does not make sense to have a comma after a sentinel, as any new > elements must be added before the sentinel. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm: Drop

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread David Hildenbrand
On 06.03.22 06:32, Jarkko Sakkinen wrote: > For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow > to use that for initializing the device memory by providing a new callback > f_ops->populate() for the purpose. > > SGX patches are provided to show the callback in context. >

[PATCH] drm/omap: fix NULL but dereferenced coccicheck error

2022-03-07 Thread Wan Jiabing
Fix the following coccicheck warning: ./drivers/gpu/drm/omapdrm/omap_overlay.c:89:22-25: ERROR: r_ovl is NULL but dereferenced. Here should be ovl->idx rather than r_ovl->idx. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/omapdrm/omap_overlay.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 2/2] drm/i915/dg2: Add debugfs to control global preemption setting

2022-03-07 Thread Tvrtko Ursulin
On 04/03/2022 23:46, Matt Roper wrote: From: Akeem G Abodunrin Since DG2 and beyond only support global preemption enable/disable (see Wa_14015141709), userspace no longer has a way to control preemption on a per-context basis. Preemption is globally enabled by default, but the UMD teams

Re: [PATCH v12 03/23] dt-bindings: mediatek: add ethdr definition for mt8195

2022-03-07 Thread AngeloGioacchino Del Regno
Il 07/03/22 03:33, Nancy.Lin ha scritto: Hi Angelo, Thanks for the review. On Wed, 2022-03-02 at 11:13 +0100, AngeloGioacchino Del Regno wrote: Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu ---

Re: [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support

2022-03-07 Thread Naresh Kamboju
Hi Rob, On Sun, 20 Feb 2022 at 00:02, Rob Clark wrote: > > From: Rob Clark > > Avoid going down devfreq paths on devices where devfreq is not > initialized. > > Reported-by: Linux Kernel Functional Testing > Reported-by: Anders Roxell > Signed-off-by: Rob Clark I have tested this patch and

Re: [PATCH] drm: Drop commas after SoC match table sentinels

2022-03-07 Thread Geert Uytterhoeven
Hi Neil, On Mon, Mar 7, 2022 at 9:30 AM Neil Armstrong wrote: > On 03/03/2022 13:44, Geert Uytterhoeven wrote: > > It does not make sense to have a comma after a sentinel, as any new > > elements must be added before the sentinel. > > > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Neil

Re: [PATCH] drm: Drop commas after SoC match table sentinels

2022-03-07 Thread Neil Armstrong
On 03/03/2022 13:44, Geert Uytterhoeven wrote: It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- 2 files

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-07 Thread Reimar Döffinger
Hi, Sorry to butt in as an outsider, but this seems like a shockingly disrespectful discussion for such a wide CC list. I don't want to make rules how you discuss things (I very rarely contribute), and I see the value in a frank discussion, but maybe you could continue with a reduced CC list? I

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-07 Thread Joel Fernandes
On Sat, Mar 05, 2022 at 11:15:38PM +0900, Byungchul Park wrote: > On Fri, Mar 04, 2022 at 10:26:23PM -0500, Theodore Ts'o wrote: > > On Fri, Mar 04, 2022 at 09:42:37AM +0900, Byungchul Park wrote: > > > > > > All contexts waiting for any of the events in the circular dependency > > > chain will

[PATCH RFC] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
Sometimes you might want to use MAP_POPULATE to ask a device driver to initialize the device memory in some specific manner. SGX driver can use this to request more memory by issuing ENCLS[EAUG] x86 opcode for each page in the address range. Add f_ops->populate() with the same parameters as

RE: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()

2022-03-07 Thread Alison Wang
Acked-by: Alison Wang Best Regards, Alison Wang -Original Message- From: Yang Li Sent: 2022年3月3日 10:30 To: Alison Wang Cc: ste...@agner.ch; airl...@linux.ie; dan...@ffwll.ch; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; Yang Li ; Abaci Robot Subject: [EXT]

<    1   2