Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-03-17 Thread Daniel Vetter
On Tue, Mar 15, 2022 at 09:45:20AM +, Tvrtko Ursulin wrote: > > On 15/03/2022 07:28, Kasireddy, Vivek wrote: > > Hi Tvrtko, Daniel, > > > > > > > > On 11/03/2022 09:39, Daniel Vetter wrote: > > > > On Mon, 7 Mar 2022 at 21:38, Vivek Kasireddy > > > > wrote: > > > > > > > > > > On

Re: [PATCH v1] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table()

2022-03-17 Thread Daniel Vetter
On Tue, Mar 08, 2022 at 04:34:01PM +0300, Dmitry Osipenko wrote: > drm_gem_shmem_get_sg_table() never returns NULL on error, but a ERR_PTR. > Correct the doc comment which says that it returns NULL on error. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 2

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-03-17 Thread Tvrtko Ursulin
On 17/03/2022 09:47, Daniel Vetter wrote: On Tue, Mar 15, 2022 at 09:45:20AM +, Tvrtko Ursulin wrote: On 15/03/2022 07:28, Kasireddy, Vivek wrote: Hi Tvrtko, Daniel, On 11/03/2022 09:39, Daniel Vetter wrote: On Mon, 7 Mar 2022 at 21:38, Vivek Kasireddy wrote: On platforms capable

[PULL] drm-misc-fixes

2022-03-17 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the PR for drm-misc-fixes for this week. Besides the fixes, it contains a backmerge of drm/drm-fixes to get required Kconfig changes from upstream. Best regards Thomas drm-misc-fixes-2022-03-17: * drm/imx: Don't test bus flags in atomic check * drm/mgag200: Fix PLL

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Daniel Stone
Hi, On Thu, 17 Mar 2022 at 09:21, Christian König wrote: > Am 17.03.22 um 09:42 schrieb Sharma, Shashank: > >> AFAIU you probably want to be passing around a `struct pid *`, and > >> then somehow use pid_vnr() in the context of the process reading the > >> event to get the numeric pid.

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-03-17 Thread Tvrtko Ursulin
On 17/03/2022 07:08, Kasireddy, Vivek wrote: Hi Tvrtko, On 16/03/2022 07:37, Kasireddy, Vivek wrote: Hi Tvrtko, On 15/03/2022 07:28, Kasireddy, Vivek wrote: Hi Tvrtko, Daniel, On 11/03/2022 09:39, Daniel Vetter wrote: On Mon, 7 Mar 2022 at 21:38, Vivek Kasireddy wrote: On

Re: [PATCH] drm: drm_bufs: Error out if 'dev->agp' is a null pointer

2022-03-17 Thread Daniel Vetter
On Fri, Mar 11, 2022 at 07:23:02AM +, Zheyu Ma wrote: > The user program can control the 'drm_buf_desc::flags' via ioctl system > call and enter the function drm_legacy_addbufs_agp(). If the driver > doesn't initialize the agp resources, the driver will cause a null > pointer dereference. > >

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Christian König
Am 17.03.22 um 10:29 schrieb Daniel Vetter: On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote: Am 16.03.22 um 16:36 schrieb Rob Clark: [SNIP] just one point of clarification.. in the msm and i915 case it is purely for debugging and telemetry (ie. sending crash logs back to distro

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Daniel Vetter
On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: > From: Rob Clark > > In the system suspend path, we don't want to be racing with the > scheduler kthreads pushing additional queued up jobs to the hw > queue (ringbuffer). So park them first. While we are at it, > move the wait for

Re: [PATCH 1/6] drm: allow real encoder to be passed for drm_writeback_connector

2022-03-17 Thread Daniel Vetter
On Fri, Mar 11, 2022 at 10:05:53AM +0200, Laurent Pinchart wrote: > On Fri, Mar 11, 2022 at 10:46:13AM +0300, Dmitry Baryshkov wrote: > > On Fri, 11 Mar 2022 at 04:50, Abhinav Kumar > > wrote: > > > > > > For some vendor driver implementations, display hardware can > > > be shared between the

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Christian König
Am 17.03.22 um 10:59 schrieb Daniel Vetter: On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: From: Rob Clark In the system suspend path, we don't want to be racing with the scheduler kthreads pushing additional queued up jobs to the hw queue (ringbuffer). So park them first. While

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2022 at 10:04:36AM +, Tvrtko Ursulin wrote: > > On 17/03/2022 09:47, Daniel Vetter wrote: > > On Tue, Mar 15, 2022 at 09:45:20AM +, Tvrtko Ursulin wrote: > > > > > > On 15/03/2022 07:28, Kasireddy, Vivek wrote: > > > > Hi Tvrtko, Daniel, > > > > > > > > > > > > > > On

Re: [PATCH v1] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table()

2022-03-17 Thread Dmitry Osipenko
On 3/17/22 12:52, Daniel Vetter wrote: > On Tue, Mar 08, 2022 at 04:34:01PM +0300, Dmitry Osipenko wrote: >> drm_gem_shmem_get_sg_table() never returns NULL on error, but a ERR_PTR. >> Correct the doc comment which says that it returns NULL on error. >> >> Signed-off-by: Dmitry Osipenko >> ---

Re: [PATCH 2/2] fbdev: Fix cfb_imageblit() for arbitrary image widths

2022-03-17 Thread Daniel Vetter
On Sun, Mar 13, 2022 at 08:29:52PM +0100, Thomas Zimmermann wrote: > Commit 0d03011894d2 ("fbdev: Improve performance of cfb_imageblit()") > broke cfb_imageblit() for image widths that are not aligned to 8-bit > boundaries. Fix this by handling the trailing pixels on each line > separately. The

Re: [PATCH 4/4] drm/gma500: Cosmetic cleanup of irq code

2022-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2022 at 10:25:55AM +0100, Patrik Jakobsson wrote: > Use the gma_ prefix instead of psb_ since the code is common for all > chips. Various coding style fixes. Removal of unused code. Removal of > duplicate function declarations. I didn't really find the above removal things, was

Re: [PATCH 1/2] fbdev: Fix sys_imageblit() for arbitrary image widths

2022-03-17 Thread Javier Martinez Canillas
Hello Thomas, On 3/13/22 20:29, Thomas Zimmermann wrote: > Commit 6f29e04938bf ("fbdev: Improve performance of sys_imageblit()") > broke sys_imageblit() for image width that are not aligned to 8-bit > boundaries. Fix this by handling the trailing pixels on each line > separately. The performance

Re: [Freedreno] [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-17 Thread Dmitry Baryshkov
On 16/03/2022 20:26, Abhinav Kumar wrote: On 3/16/2022 12:31 AM, Dmitry Baryshkov wrote: On 16/03/2022 03:28, Abhinav Kumar wrote: On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI support. Add support for disabling other features

[PATCH 5.4 38/43] drm/vrr: Set VRR capable prop only if it is attached to connector

2022-03-17 Thread Greg Kroah-Hartman
From: Manasi Navare [ Upstream commit 62929726ef0ec72cbbe9440c5d125d4278b99894 ] VRR capable property is not attached by default to the connector It is attached only if VRR is supported. So if the driver tries to call drm core set prop function without it being attached that causes NULL

[PATCH 5.10 16/23] drm/vrr: Set VRR capable prop only if it is attached to connector

2022-03-17 Thread Greg Kroah-Hartman
From: Manasi Navare [ Upstream commit 62929726ef0ec72cbbe9440c5d125d4278b99894 ] VRR capable property is not attached by default to the connector It is attached only if VRR is supported. So if the driver tries to call drm core set prop function without it being attached that causes NULL

[PATCH 5.15 18/25] drm/vrr: Set VRR capable prop only if it is attached to connector

2022-03-17 Thread Greg Kroah-Hartman
From: Manasi Navare [ Upstream commit 62929726ef0ec72cbbe9440c5d125d4278b99894 ] VRR capable property is not attached by default to the connector It is attached only if VRR is supported. So if the driver tries to call drm core set prop function without it being attached that causes NULL

[PATCH 5.16 22/28] drm/vrr: Set VRR capable prop only if it is attached to connector

2022-03-17 Thread Greg Kroah-Hartman
From: Manasi Navare [ Upstream commit 62929726ef0ec72cbbe9440c5d125d4278b99894 ] VRR capable property is not attached by default to the connector It is attached only if VRR is supported. So if the driver tries to call drm core set prop function without it being attached that causes NULL

[PATCH v4 2/3] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2022-03-17 Thread Kieran Bingham
From: Laurent Pinchart Implement the bridge connector-related .get_edid() operation, and report the related bridge capabilities and type. Signed-off-by: Laurent Pinchart Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- Changes since v1: - The connector .get_modes() operation

[PATCH v4 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-17 Thread Kieran Bingham
When the SN65DSI86 is used in DisplayPort mode, its output is likely routed to a DisplayPort connector, which can benefit from hotplug detection. Support it in such cases, with both polling mode and IRQ based detection. The implementation is limited to the bridge operations, as the connector

[PATCH v4 0/3] drm/bridge: ti-sn65dsi86: Support non-eDP DisplayPort connectors

2022-03-17 Thread Kieran Bingham
Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and provide IRQ based hotplug detect to identify when the connector is present. no-hpd is extended to be the default behaviour for non DisplayPort connectors. This series is based upon Sam Ravnborgs and Rob Clarks series [0] to

[PATCH v4 1/3] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode

2022-03-17 Thread Kieran Bingham
From: Laurent Pinchart Despite the SN65DSI86 being an eDP bridge, on some systems its output is routed to a DisplayPort connector. Enable DisplayPort mode when the next component in the display pipeline is detected as a DisplayPort connector, and disable eDP features in that case.

[PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread Lee Jones
Presently the Client can be freed whilst still in use. Use the already provided lock to prevent this. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org

Re: [PATCH v1 1/3] mm: split vm_normal_pages for LRU and non-LRU handling

2022-03-17 Thread Jason Gunthorpe
On Thu, Mar 17, 2022 at 09:13:50AM +0100, David Hildenbrand wrote: > On 17.03.22 03:54, Alistair Popple wrote: > > Felix Kuehling writes: > > > >> On 2022-03-11 04:16, David Hildenbrand wrote: > >>> On 10.03.22 18:26, Alex Sierra wrote: > DEVICE_COHERENT pages introduce a subtle distinction

RE: [Intel-gfx] [PATCH v6 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-03-17 Thread Kasireddy, Vivek
Hi Tvrtko, > > On 16/03/2022 07:37, Kasireddy, Vivek wrote: > > Hi Tvrtko, > > > >> > >> On 15/03/2022 07:28, Kasireddy, Vivek wrote: > >>> Hi Tvrtko, Daniel, > >>> > > On 11/03/2022 09:39, Daniel Vetter wrote: > > On Mon, 7 Mar 2022 at 21:38, Vivek Kasireddy > wrote: > >> >

Re: [RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-17 Thread Christian König
Am 16.03.22 um 16:28 schrieb Robert Beckett: On 16/03/2022 14:39, Christian König wrote: Am 16.03.22 um 15:26 schrieb Robert Beckett: [SNIP] this is where I replace an existing range check via drm_mm with the range check I added in this patch. Mhm, I still don't get the use case from the

[PATCH] fbdev: defio: fix the pagelist corruption

2022-03-17 Thread Chuansheng Liu
Easily hit the below list corruption: == list_add corruption. prev->next should be next (c0ceb090), but was ec604507edc8. (prev=ec604507edc8). WARNING: CPU: 65 PID: 3959 at lib/list_debug.c:26 __list_add_valid+0x53/0x80 CPU: 65 PID: 3959 Comm: fbdev Tainted: G U RIP:

[linux-next:master] BUILD REGRESSION 8a11187eb62b8b910d2c5484e1f5d160e8b11eb4

2022-03-17 Thread kernel test robot
- fs-btrfs-ordered-data.c:warning:expecting-prototype-for-Add-an-ordered-extent-to-the-per().-Prototype-was-for-btrfs_add_ordered_extent()-instead | `-- fs-btrfs-tree-log.c:warning:This-comment-starts-with-but-isn-t-a-kernel-doc-comment.-Refer-Documentation-doc-guide-kerne

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Christian König
Am 16.03.22 um 16:36 schrieb Rob Clark: [SNIP] just one point of clarification.. in the msm and i915 case it is purely for debugging and telemetry (ie. sending crash logs back to distro for analysis if user has crash reporting enabled).. it isn't used for triggering any action like killing app

Re: [PATCH] drm/ttm: fix uninit ptr deref in range manager alloc error path

2022-03-17 Thread Christian König
Am 16.03.22 um 20:50 schrieb Robert Beckett: ttm_range_man_alloc would try to ttm_resource_fini the res pointer before it is allocated. Fixes: de3688e469b0 (drm/ttm: add ttm_resource_fini v2) Signed-off-by: Robert Beckett Reviewed-by: Christian König Good catch, going to push that to

Re: [PATCH 00/25] drm/msm/dpu: wide planes support

2022-03-17 Thread Dmitry Baryshkov
On 17/03/2022 04:10, Abhinav Kumar wrote: Hi Dmitry I have reviewed the series , some patches completely , some of them especially the plane to sspp mapping is something i still need to check. But I had one question on the design. I thought we were going to have a boot param to control

Re: [PATCH v1 1/3] mm: split vm_normal_pages for LRU and non-LRU handling

2022-03-17 Thread David Hildenbrand
On 17.03.22 03:54, Alistair Popple wrote: > Felix Kuehling writes: > >> On 2022-03-11 04:16, David Hildenbrand wrote: >>> On 10.03.22 18:26, Alex Sierra wrote: DEVICE_COHERENT pages introduce a subtle distinction in the way "normal" pages can be used by various callers throughout the

[PATCH v2 1/5] drm/format-helper: Rename drm_fb_xrgb8888_to_mono_reversed()

2022-03-17 Thread Geert Uytterhoeven
There is no "reversed" handling in drm_fb_xrgb_to_mono_reversed(): the function just converts from color to grayscale, and reduces the number of grayscale levels from 256 to 2 (i.e. brightness 0-127 is mapped to 0, 128-255 to 1). All "reversed" handling is done in the repaper driver, where

[PATCH v2 2/5] drm/format-helper: Fix XRGB888 to monochrome conversion

2022-03-17 Thread Geert Uytterhoeven
The conversion functions drm_fb_xrgb_to_mono() and drm_fb_gray8_to_mono_line() do not behave correctly when the horizontal boundaries of the clip rectangle are not multiples of 8: a. When x1 % 8 != 0, the calculated pitch is not correct, b. When x2 % 8 != 0, the pixel data for the last

[PATCH v2 3/5] drm/ssd130x: Fix rectangle updates

2022-03-17 Thread Geert Uytterhoeven
The rectangle update functions ssd130x_fb_blit_rect() and ssd130x_update_rect() do not behave correctly when x1 != 0 or y1 != 0, or when y1 or y2 are not aligned to display page boundaries. E.g. when used as a text console, only the first line of text is shown on the display. 1. The buffer

[PATCH v2 5/5] drm/repaper: Reduce temporary buffer size in repaper_fb_dirty()

2022-03-17 Thread Geert Uytterhoeven
As the temporary buffer is no longer used to store 8-bit grayscale data, its size can be reduced to the size needed to store the monochrome bitmap data. Fixes: 24c6bedefbe71de9 ("drm/repaper: Use format helper for xrgb to monochrome conversion") Signed-off-by: Geert Uytterhoeven

[PATCH v2 0/5] drm: Fix monochrome conversion for sdd130x

2022-03-17 Thread Geert Uytterhoeven
Hi all, This patch series contains fixes and improvements for the XRGB888 to monochrome conversion in the DRM core, and for its users. This has been tested on an Adafruit FeatherWing 128x32 OLED, connected to an OrangeCrab ECP5 FPGA board running a 64 MHz VexRiscv RISC-V softcore, using

[PATCH v2 4/5] drm/ssd130x: Reduce temporary buffer sizes

2022-03-17 Thread Geert Uytterhoeven
ssd130x_clear_screen() allocates a temporary buffer sized to hold one byte per pixel, while it only needs to hold one bit per pixel. ssd130x_fb_blit_rect() allocates a temporary buffer sized to hold one byte per pixel for the whole frame buffer, while it only needs to hold one bit per pixel for

[PATCH 3/3] drm: bridge: it66121: Add audio support

2022-03-17 Thread Nicolas Belin
Adding the audio support on the HDMI bridge for I2S only. Signed-off-by: Nicolas Belin Signed-off-by: Andy.Hsieh --- drivers/gpu/drm/bridge/ite-it66121.c | 627 +++ 1 file changed, 627 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c

[PATCH 1/4] drm/gma500: Remove unused declarations and other cruft

2022-03-17 Thread Patrik Jakobsson
Most of these are old leftovers from one of the driver merges. This is all dead code. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.h | 75 +--- 1 file changed, 1 insertion(+), 74 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.h

[PATCH 2/4] drm/gma500: Move gma_intel_crtc_funcs into gma_display.c

2022-03-17 Thread Patrik Jakobsson
All functions live in gma_display.c already so move the vtable. Also shorten the name to gma_crtc_funcs. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c| 2 +- drivers/gpu/drm/gma500/gma_display.c | 12 drivers/gpu/drm/gma500/gma_display.h

[PATCH 4/4] drm/gma500: Cosmetic cleanup of irq code

2022-03-17 Thread Patrik Jakobsson
Use the gma_ prefix instead of psb_ since the code is common for all chips. Various coding style fixes. Removal of unused code. Removal of duplicate function declarations. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 8 +-- drivers/gpu/drm/gma500/opregion.c|

[PATCH 3/4] drm/gma500: Don't store crtc_funcs in psb_ops

2022-03-17 Thread Patrik Jakobsson
The drm_crtc_funcs are all generic and no chip specific functions are necessary. We can therefore directly put gma_crtc_funcs into the drm_crtc. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c| 1 - drivers/gpu/drm/gma500/oaktrail_device.c | 1 -

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Daniel Vetter
On Mon, Mar 14, 2022 at 10:23:27AM -0400, Alex Deucher wrote: > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > > > On Thu, 10 Mar 2022 11:56:41 -0800 > > Rob Clark wrote: > > > > > For something like just notifying a compositor that a gpu crash > > > happened, perhaps drm_event is

Re: [RESEND PATCH] drm/doc: Clarify what ioctls can be used on render nodes

2022-03-17 Thread Daniel Vetter
On Mon, Mar 07, 2022 at 08:32:36AM -0700, Jeffrey Hugo wrote: > The documentation for render nodes indicates that only "PRIME-related" > ioctls are valid on render nodes, but the documentation does not clarify > what that means. If the reader is not familiar with PRIME, they may > beleive this to

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-17 Thread Andy Yan
Hi Sascha: On 3/16/22 20:22, Andy Yan wrote: Hi Sascha and Daniel: On 3/16/22 15:40, Sascha Hauer wrote: On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote: Hi Sascha: On 3/11/22 16:33, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with

Re: [RFC PATCH 1/4] drm/amdkfd: Improve amdgpu_vm_handle_moved

2022-03-17 Thread Christian König
Am 17.03.22 um 01:20 schrieb Felix Kuehling: Let amdgpu_vm_handle_moved update all BO VA mappings of BOs reserved by the caller. This will be useful for handling extra BO VA mappings in KFD VMs that are managed through the render node API. Yes, that change is on my TODO list for quite a while

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Christian König
Am 17.03.22 um 09:42 schrieb Sharma, Shashank: On 3/16/2022 10:50 PM, Rob Clark wrote: On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma wrote: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information

Re: [PATCH,v2] drm/panel: Fix return value check in nt35950_probe()

2022-03-17 Thread AngeloGioacchino Del Regno
Il 17/03/22 09:37, Lu Wei ha scritto: In function nt35950_probe(), mipi_dsi_device_register_full() is called to create a MIPI DSI device. If it fails, a pointer encoded with an error will be returned, so use IS_ERR() to check the return value. Besides, use PTR_ERR to return the actual errno.

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote: > Am 16.03.22 um 16:36 schrieb Rob Clark: > > [SNIP] > > just one point of clarification.. in the msm and i915 case it is > > purely for debugging and telemetry (ie. sending crash logs back to > > distro for analysis if user has

Re: [PATCH V9 1/5] dt-bindings: display: mediatek: add aal binding for MT8183

2022-03-17 Thread Krzysztof Kozlowski
On 17/03/2022 06:18, Rex-BC Chen wrote: > Add aal binding for MT8183. > > Signed-off-by: Rex-BC Chen > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-17 Thread Geert Uytterhoeven
Hi Chuansheng, On Thu, Mar 17, 2022 at 7:17 AM Chuansheng Liu wrote: > Easily hit the below list corruption: > == > list_add corruption. prev->next should be next (c0ceb090), but > was ec604507edc8. (prev=ec604507edc8). > WARNING: CPU: 65 PID: 3959 at lib/list_debug.c:26 >

[PULL] drm-intel-next-fixes

2022-03-17 Thread Joonas Lahtinen
Hi Dave & Daniel, Fix for vm_access() out-of-bounds access and PSR not staying disabled during fastset once determined not reliable. Then a naming fix to avoid conflicts for potential future fixes. Regards, Joonas *** drm-intel-next-fixes-2022-03-17: - Do not re-enable PSR after it was

Re: [PATCH 3/3] drm/msm: Add a way to override processes comm/cmdline

2022-03-17 Thread Dan Carpenter
On Wed, Mar 16, 2022 at 05:29:45PM -0700, Rob Clark wrote: > switch (param) { > + case MSM_PARAM_COMM: > + case MSM_PARAM_CMDLINE: { > + char *str, **paramp; > + > + str = kmalloc(len + 1, GFP_KERNEL); if (!str) return -ENOMEM; > + if

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Sharma, Shashank
On 3/16/2022 10:50 PM, Rob Clark wrote: On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma wrote: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information like: - process ID of the process involved

Re: [PATCH v3 1/3] drm: allow real encoder to be passed for drm_writeback_connector

2022-03-17 Thread Laurent Pinchart
Hi Abhinav, Thank you for the patch. On Wed, Mar 16, 2022 at 11:48:16AM -0700, Abhinav Kumar wrote: > For some vendor driver implementations, display hardware can > be shared between the encoder used for writeback and the physical > display. > > In addition resources such as clocks and

[PATCH 1/3] dt-bindings: display: bridge: it66121: Add audio support

2022-03-17 Thread Nicolas Belin
Update the ITE bridge HDMI it66121 bindings in order to support audio. Signed-off-by: Nicolas Belin --- .../devicetree/bindings/display/bridge/ite,it66121.yaml| 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml

[PATCH 0/3] drm: bridge: it66121: Add audio support

2022-03-17 Thread Nicolas Belin
This patch series adds the audio support on the it66121 HDMI bridge. Patch 1 updates the ITE 66121 HDMI bridge bindings in order to support audio. Patch 2 sets the register page length or window length of the ITE 66121 HDMI bridge to 0x100 according to the documentation. Patch 3 contains the

[PATCH 2/3] drm: bridge: it66121: Fix the register page length

2022-03-17 Thread Nicolas Belin
Set the register page length or window length to 0x100 according to the documentation. Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") Signed-off-by: Nicolas Belin --- drivers/gpu/drm/bridge/ite-it66121.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] drm/i915: Add logical mapping for video decode engines

2022-03-17 Thread Souza, Jose
On Wed, 2022-03-16 at 16:45 -0700, Lucas De Marchi wrote: > From: Matthew Brost > > Add logical mapping for VDBOXs. This mapping is required for > split-frame workloads, which otherwise fail with > > -F8C53528: [GUC] 0441-INVALID_ENGINE_SUBMIT_MASK > > ... if the application is

Re: [PATCH] drm/vc4: add tracepoints for CL submissions

2022-03-17 Thread Maxime Ripard
On Thu, Mar 10, 2022 at 12:54:32PM +0100, Chema Casanova wrote: > El 10/3/22 a las 12:12, Maxime Ripard escribió: > > On Tue, Mar 01, 2022 at 01:58:26PM -0100, Melissa Wen wrote: > > > On 02/25, Maxime Ripard wrote: > > > > Hi Melissa, > > > > > > > > On Tue, Feb 01, 2022 at 08:26:51PM -0100,

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread Lee Jones
On Thu, 17 Mar 2022, Felix Kuehling wrote: > > Am 2022-03-17 um 11:00 schrieb Lee Jones: > > Good afternoon Felix, > > > > Thanks for your review. > > > > > Am 2022-03-17 um 09:16 schrieb Lee Jones: > > > > Presently the Client can be freed whilst still in use. > > > > > > > > Use the already

Re: [Freedreno] [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-17 Thread Dmitry Baryshkov
On 17/03/2022 15:44, Dmitry Baryshkov wrote: On 16/03/2022 20:26, Abhinav Kumar wrote: On 3/16/2022 12:31 AM, Dmitry Baryshkov wrote: On 16/03/2022 03:28, Abhinav Kumar wrote: On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI

Re: [PATCH 1/2] drm/i915: Fix renamed struct field

2022-03-17 Thread Souza, Jose
On Wed, 2022-03-16 at 16:45 -0700, Lucas De Marchi wrote: > Earlier versions of commit a5b7ef27da60 ("drm/i915: Add struct to hold > IP version") named "ver" as "arch" and then when it was renamed it > missed the rename on MEDIA_VER_FULL() since it it's currently not used. Reviewed-by: José

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread Felix Kuehling
Am 2022-03-17 um 09:16 schrieb Lee Jones: Presently the Client can be freed whilst still in use. Use the already provided lock to prevent this. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: amd-...@lists.freedesktop.org

Re: [PATCH 3/3] drm/msm: Add a way to override processes comm/cmdline

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 1:21 AM Dan Carpenter wrote: > > On Wed, Mar 16, 2022 at 05:29:45PM -0700, Rob Clark wrote: > > switch (param) { > > + case MSM_PARAM_COMM: > > + case MSM_PARAM_CMDLINE: { > > + char *str, **paramp; > > + > > + str = kmalloc(len + 1,

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 3:06 AM Christian König wrote: > > Am 17.03.22 um 10:59 schrieb Daniel Vetter: > > On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: > >> From: Rob Clark > >> > >> In the system suspend path, we don't want to be racing with the > >> scheduler kthreads pushing

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-17 Thread Thomas Zimmermann
Hi Am 17.03.22 um 06:46 schrieb Chuansheng Liu: Easily hit the below list corruption: == list_add corruption. prev->next should be next (c0ceb090), but was ec604507edc8. (prev=ec604507edc8). WARNING: CPU: 65 PID: 3959 at lib/list_debug.c:26 __list_add_valid+0x53/0x80 CPU: 65

Re: (subset) [PATCH] drm/vc4: add tracepoints for CL submissions

2022-03-17 Thread Maxime Ripard
On Tue, 1 Feb 2022 20:26:51 -0100, Melissa Wen wrote: > Trace submit_cl_ioctl and related IRQs for CL submission and bin/render > jobs execution. It might be helpful to get a rendering timeline and > track job throttling. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread Lee Jones
On Thu, 17 Mar 2022, Lee Jones wrote: > Presently the Client can be freed whilst still in use. > > Use the already provided lock to prevent this. > > Cc: Felix Kuehling > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc:

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread Lee Jones
Good afternoon Felix, Thanks for your review. > Am 2022-03-17 um 09:16 schrieb Lee Jones: > > Presently the Client can be freed whilst still in use. > > > > Use the already provided lock to prevent this. > > > > Cc: Felix Kuehling > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: "Pan,

Re: amd-gfx Digest, Vol 70, Issue 199

2022-03-17 Thread Felix Kuehling
Am 2022-03-16 um 21:57 schrieb Yat Sin, David: Use proper amdgpu_gem_prime_import function to handle all kinds of imports. Remember the dmabuf reference to enable proper multi-GPU attachment to multiple VMs without erroneously re-exporting the underlying BO multiple times. Signed-off-by: Felix

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread Felix Kuehling
Am 2022-03-17 um 11:00 schrieb Lee Jones: Good afternoon Felix, Thanks for your review. Am 2022-03-17 um 09:16 schrieb Lee Jones: Presently the Client can be freed whilst still in use. Use the already provided lock to prevent this. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Matthew Brost
On Thu, Mar 17, 2022 at 03:06:18AM -0700, Christian König wrote: > Am 17.03.22 um 10:59 schrieb Daniel Vetter: > > On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: > >> From: Rob Clark > >> > >> In the system suspend path, we don't want to be racing with the > >> scheduler kthreads

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote: > > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote: > > Am 16.03.22 um 16:36 schrieb Rob Clark: > > > [SNIP] > > > just one point of clarification.. in the msm and i915 case it is > > > purely for debugging and telemetry (ie.

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote: > > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote: > > Am 16.03.22 um 16:36 schrieb Rob Clark: > > > [SNIP] > > > just one point of clarification.. in the msm and i915 case it is > > > purely for debugging and telemetry (ie.

Re: [PATCH 2/2] fbdev: Fix cfb_imageblit() for arbitrary image widths

2022-03-17 Thread Javier Martinez Canillas
On 3/13/22 20:29, Thomas Zimmermann wrote: > Commit 0d03011894d2 ("fbdev: Improve performance of cfb_imageblit()") > broke cfb_imageblit() for image widths that are not aligned to 8-bit > boundaries. Fix this by handling the trailing pixels on each line > separately. The performance improvements

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-17 Thread Javier Martinez Canillas
Hello Chuansheng, On 3/17/22 06:46, Chuansheng Liu wrote: > Easily hit the below list corruption: > == > list_add corruption. prev->next should be next (c0ceb090), but > was ec604507edc8. (prev=ec604507edc8). > WARNING: CPU: 65 PID: 3959 at lib/list_debug.c:26 >

Re: [PATCH 4/4] drm/gma500: Cosmetic cleanup of irq code

2022-03-17 Thread Patrik Jakobsson
On Thu, Mar 17, 2022 at 12:02 PM Daniel Vetter wrote: > > On Thu, Mar 17, 2022 at 10:25:55AM +0100, Patrik Jakobsson wrote: > > Use the gma_ prefix instead of psb_ since the code is common for all > > chips. Various coding style fixes. Removal of unused code. Removal of > > duplicate function

Re: [PATCH v2 0/5] drm: Fix monochrome conversion for sdd130x

2022-03-17 Thread Javier Martinez Canillas
Hello Geert, On 3/17/22 09:18, Geert Uytterhoeven wrote: > Hi all, > > This patch series contains fixes and improvements for the XRGB888 to > monochrome conversion in the DRM core, and for its users. > > This has been tested on an Adafruit FeatherWing 128x32 OLED, connected > to an

[v8 1/5] drm/edid: seek for available CEA block from specific EDID block index

2022-03-17 Thread Lee Shawn C
drm_find_cea_extension() always look for a top level CEA block. Pass ext_index from caller then this function to search next available CEA ext block from a specific EDID block pointer. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Cc: intel-gfx Signed-off-by: Lee Shawn C ---

[v8 2/5] drm/edid: parse multiple CEA extension block

2022-03-17 Thread Lee Shawn C
Try to find and parse more CEA ext blocks if edid->extensions is greater than one. v2: split prvious patch to two. And do CEA block parsing in this one. v3: simplify this patch based on previous change. v4: refine patch v3. v5: revert previous change. And check cea pointer return from

[v8 3/5] drm/edid: read HF-EEODB ext block

2022-03-17 Thread Lee Shawn C
According to HDMI 2.1 spec. "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) is utilized by Sink Devices to provide an alternate method to indicate an EDID Extension Block count larger than 1, while avoiding the need to present a VESA Block Map in the first E-EDID Extension Block."

[v8 4/5] drm/edid: parse HF-EEODB CEA extension block

2022-03-17 Thread Lee Shawn C
While adding CEA modes, try to get available EEODB block number. Then based on it to parse numbers of ext blocks, retrieve CEA information and add more CEA modes. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Cc: intel-gfx Signed-off-by: Lee Shawn C ---

[v8 5/5] drm/edid: check for HF-SCDB block

2022-03-17 Thread Lee Shawn C
Find HF-SCDB information in CEA extensions block. And retrieve Max_TMDS_Character_Rate that support by sink device. v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse drm_parse_hdmi_forum_vsdb() to parse this packet. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Cc: intel-gfx

[v8 0/5] enhanced edid driver compatibility

2022-03-17 Thread Lee Shawn C
Support to parse multiple CEA extension blocks and HF-EEODB to extend drm edid driver's capability. v4: add one more patch to support HF-SCDB v5: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse drm_parse_hdmi_forum_vsdb() to parse this packet. v6: save proper extension block index if CTA

Re: [PATCH] drm/panel: add CONFIG_DRM_KMS_HELPER dependencies

2022-03-17 Thread Thomas Zimmermann
Hi Arnd Am 16.03.22 um 21:59 schrieb Arnd Bergmann: On Wed, Mar 16, 2022 at 8:31 PM Thomas Zimmermann wrote: Am 16.03.22 um 20:12 schrieb Thomas Zimmermann: Adding a dependency in all drivers that select DRM_MIPI_DBI avoids the problem for now, adding the dependency in DRM_MIPI_DBI as well

[PATCH] drm/panel: ili9341: fix optional regulator handling

2022-03-17 Thread Daniel Mack
If the optional regulator lookup fails, reset the pointer to NULL. Other functions such as mipi_dbi_poweron_reset_conditional() only do a NULL pointer check and will otherwise dereference the error pointer. Fixes: 5a04227326b04c15 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by:

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Andrey Grodzovsky
On 2022-03-17 13:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: Am 17.03.22 um 17:18 schrieb Rob Clark: On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote: Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what

Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware

2022-03-17 Thread Daniel Dadap
On 3/17/22 12:35, Alex Deucher wrote: Sorry for jumping in here, but I can't seem to find the original thread with this comment. amdgpu_atombios_encoder_init_backlight() is not applicable to these systems. That is the old pre-DC code path. You want amdgpu_dm_register_backlight_device() for

Re: [PATCH] drm/amdgpu: Fix spelling mistake "regiser" -> "register"

2022-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 15, 2022 at 4:20 PM Colin Ian King wrote: > > There is a spelling mistake in a dev_error error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky wrote: > > > On 2022-03-17 14:25, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky > > wrote: > >> > >> On 2022-03-17 13:35, Rob Clark wrote: > >>> On Thu, Mar 17, 2022 at 9:45 AM Christian König > >>> wrote: > Am

[RFC] drm/msm: Add a way for userspace to allocate GPU iova

2022-03-17 Thread Rob Clark
From: Rob Clark The motivation at this point is mainly native userspace mesa driver in a VM guest. The one remaining synchronous "hotpath" is buffer allocation, because guest needs to wait to know the bo's iova before it can start emitting cmdstream/state that references the new bo. By

Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware

2022-03-17 Thread Daniel Dadap
On 3/17/22 11:42, Hans de Goede wrote: Hi Daniel, On 3/17/22 14:28, Daniel Dadap wrote: On Mar 17, 2022, at 07:17, Hans de Goede wrote: Hi, On 3/16/22 21:33, Daniel Dadap wrote: Some notebook systems with EC-driven backlight control appear to have a firmware bug which causes the system

[PATCH v11 00/13] Add GuC Error Capture Support

2022-03-17 Thread Alan Previn
This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register said lists of global,

Re: [PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()

2022-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 16, 2022 at 4:42 AM Dan Carpenter wrote: > > This post-op should be a pre-op so that we do not pass -1 as the bit > number to test_bit(). The current code will loop downwards from 63 to > -1. After changing to a pre-op, it loops from 63 to 0. > > Fixes:

Re: [PATCH v5 1/9] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:46) > Rename the edp_out label in the sc7280 platform to mdss_edp_out > so that the nodes related to mdss are all grouped together in > the board specific files. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

  1   2   >