Re: [PATCH v3 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-21 Thread Krzysztof Kozlowski
On 21/09/2022 06:16, Jason-JH Lin wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Tue, 2022-09-20 at 17:25 +0200, Krzysztof Kozlowski wrote: >> On 20/09/2022 16:01, Jason-JH.Lin wrote: >>> For previous MediaTek SoCs, such as MT8173, there are 2 display HW >>> pipelines binding to 1

Re: [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-09-21 Thread Niranjana Vishwanathapura
On Mon, Sep 12, 2022 at 04:11:54PM +0300, Jani Nikula wrote: On Sat, 27 Aug 2022, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement the bind and unbind of an object at the specified GPU virtual addresses. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar

Re: [PATCH v3 0/8] Support for NVDEC on Tegra234

2022-09-21 Thread Mikko Perttunen
On 9/21/22 10:26, Krzysztof Kozlowski wrote: On 20/09/2022 10:11, Mikko Perttunen wrote: From: Mikko Perttunen v3: * Updated patch 3 based on comments v2: * Updated patches 1,3 based on comments * Added Acked-by to patch 2 Original message: Hi all, this series adds support for the HW

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-21 Thread Thomas Zimmermann
Hi Am 21.09.22 um 10:37 schrieb Ville Syrjälä: On Wed, Sep 21, 2022 at 09:59:10AM +0200, Thomas Zimmermann wrote: Hi Ville Am 20.09.22 um 16:31 schrieb Ville Syrjälä: On Tue, Sep 20, 2022 at 03:56:18PM +0200, Thomas Zimmermann wrote: Set partial updates on a plane if the framebuffer has not

Re: [Intel-gfx] [RFC PATCH v3 10/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-09-21 Thread Niranjana Vishwanathapura
On Mon, Sep 05, 2022 at 04:08:57PM +0100, Tvrtko Ursulin wrote: On 02/09/2022 06:41, Niranjana Vishwanathapura wrote: On Thu, Sep 01, 2022 at 08:58:57AM +0100, Tvrtko Ursulin wrote: On 01/09/2022 06:09, Niranjana Vishwanathapura wrote: On Wed, Aug 31, 2022 at 08:38:48AM +0100, Tvrtko

Re: [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-21 Thread Christian König
Am 20.09.22 um 19:13 schrieb Matthew Auld: On 20/09/2022 18:06, Nirmoy Das wrote: For delayed BO release i915_ttm_delete_mem_notify() gets called twice, once with proper bo->resource and another time with NULL. We shouldn't do anything for the 2nd time as we already cleanedup the obj once.

Re: [PATCH 13/18] phy: mediatek: mipi: mt8173: use GENMASK to generate bits mask

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use GENMASK() macro to generate bits mask Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 06/18] phy: mediatek: hdmi: mt2701: use GENMASK and BIT to generate mask and bits

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use GENMASK() and BIT() macros to generate mask and bits Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 04/18] phy: mediatek: ufs: use common register access helpers

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: No need define private register access helpers, use common ones defined in phy-mtk-io.h Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 05/18] phy: mediatek: pcie: use new helper to update register bits

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: The new helper will use FIELD_PREP() macro to prepare bits value according to mask, then we no need do it anymore. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 08/18] phy: mediatek: hdmi: mt2701: use common helper to access registers

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use MediaTek phy's common helper to access registers, then we can remove hdmi's I/O helpers. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-09-21 Thread Maxime Ripard
On Mon, Sep 19, 2022 at 08:17:11PM +0200, Marek Vasut wrote: > On 9/19/22 15:43, Maxime Ripard wrote: > > Hi, > > Hello Maxime, > > > On Sun, Sep 18, 2022 at 02:56:00PM +0200, Marek Vasut wrote: > > > On 8/1/22 15:11, Marek Vasut wrote: > > > > Fill in hs_rate and lp_rate to struct

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-09-21 Thread Krzysztof Kozlowski
On Tue, 20 Sep 2022 09:59:04 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > is used because the

[RFC v4 07/14] drm/i915/vm_bind: Add out fence support

2022-09-21 Thread Niranjana Vishwanathapura
Add support for handling out fence for vm_bind call. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h | 4 + .../drm/i915/gem/i915_gem_vm_bind_object.c| 81 +++ drivers/gpu/drm/i915/i915_vma.c

[RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-21 Thread Niranjana Vishwanathapura
The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between these two paths by abstracting out the common functionalities into a separate file where possible. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/Makefile

[RFC v4 09/14] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-09-21 Thread Niranjana Vishwanathapura
Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects binding would have been requested by the userspace

[RFC v4 02/14] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-09-21 Thread Niranjana Vishwanathapura
Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_sw_fence.c | 25 ++---

[RFC v4 04/14] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-21 Thread Niranjana Vishwanathapura
Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan

[RFC v4 01/14] drm/i915/vm_bind: Expose vm lookup function

2022-09-21 Thread Niranjana Vishwanathapura
Make i915_gem_vm_lookup() function non-static as it will be used by the vm_bind feature. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ++- drivers/gpu/drm/i915/gem/i915_gem_context.h | 3 +++ 2 files changed,

[RFC v4 11/14] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-09-21 Thread Niranjana Vishwanathapura
Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- .../gpu/drm/i915/gem/i915_gem_execbuffer3.c | 189 +- 1 file changed, 188 insertions(+), 1 deletion(-) diff --git

[RFC v4 13/14] drm/i915/vm_bind: Skip vma_lookup for persistent vmas

2022-09-21 Thread Niranjana Vishwanathapura
vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing (ie., multiple bindings to the same section of the object). Skip vma_lookup for persistent vmas as it supports aliasing. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi

[RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-21 Thread Niranjana Vishwanathapura
Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 20 +++- drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 ++

[RFC v4 12/14] drm/i915/vm_bind: userptr dma-resv changes

2022-09-21 Thread Niranjana Vishwanathapura
For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- .../gpu/drm/i915/gem/i915_gem_execbuffer3.c | 99 +++

[RFC v4 10/14] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-09-21 Thread Niranjana Vishwanathapura
Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/i915_vma.c | 16 +++-

[RFC v4 05/14] drm/i915/vm_bind: Support for VM private BOs

2022-09-21 Thread Niranjana Vishwanathapura
Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as it requires a single dma_resv object update for all private BOs vs list of dma_resv objects update for shared BOs, in the execbuf path. VM private BOs can be

[RFC v4 06/14] drm/i915/vm_bind: Handle persistent vmas

2022-09-21 Thread Niranjana Vishwanathapura
Treat VM_BIND vmas as persistent across execbuf ioctl calls and handle them during the request submission in the execbuff path. Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi

[RFC v4 14/14] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-09-21 Thread Niranjana Vishwanathapura
Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 - drivers/gpu/drm/i915/i915_getparam.c| 3 +++

[RFC v4 00/14] drm/i915/vm_bind: Add VM_BIND functionality

2022-09-21 Thread Niranjana Vishwanathapura
DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physical pages of an object (aliasing). These mappings (also referred to as

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-21 Thread Ville Syrjälä
On Wed, Sep 21, 2022 at 09:59:10AM +0200, Thomas Zimmermann wrote: > Hi Ville > > Am 20.09.22 um 16:31 schrieb Ville Syrjälä: > > On Tue, Sep 20, 2022 at 03:56:18PM +0200, Thomas Zimmermann wrote: > >> Set partial updates on a plane if the framebuffer has not been changed > >> on an atomic

[PATCH] PM: runtime: Return properly from rpm_resume() if dev->power.needs_force_resume flag is set

2022-09-21 Thread Liu Ying
After a device transitions to sleep state through it's system suspend callback pm_runtime_force_suspend(), the device's driver may still try to do runtime PM for the device(runtime suspend first and then runtime resume) although runtime PM is disabled by that callback. The runtime PM operations

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between these two paths by abstracting out the common functionalities into a separate file where possible. Looks like a good start

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-21 Thread Ville Syrjälä
On Wed, Sep 21, 2022 at 11:39:51AM +0200, Thomas Zimmermann wrote: > Hi > > Am 21.09.22 um 10:37 schrieb Ville Syrjälä: > > On Wed, Sep 21, 2022 at 09:59:10AM +0200, Thomas Zimmermann wrote: > >> Hi Ville > >> > >> Am 20.09.22 um 16:31 schrieb Ville Syrjälä: > >>> On Tue, Sep 20, 2022 at

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-09-21 Thread Krzysztof Kozlowski
On 20/09/2022 16:59, Chris Morgan wrote: > From: Chris Morgan > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > is used because the hardware itself

Re: [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix

2022-09-21 Thread Krzysztof Kozlowski
On 20/09/2022 16:59, Chris Morgan wrote: > From: Chris Morgan > > NewVision (also sometimes written as New Vision) is a company based in > Shenzen that manufactures ICs for controlling LCD panels. > > https://www.newvisiondisplay.com/ > > Signed-off-by: Chris Morgan Acked-by: Krzysztof

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-21 Thread Thomas Zimmermann
Hi Ville Am 20.09.22 um 16:31 schrieb Ville Syrjälä: On Tue, Sep 20, 2022 at 03:56:18PM +0200, Thomas Zimmermann wrote: Set partial updates on a plane if the framebuffer has not been changed on an atomic commit. If such a plane has damage clips, the driver will use them; otherwise the update

Re: [PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff()

2022-09-21 Thread Allen-KH Cheng
On 9/19/22 21:32, AngeloGioacchino Del Regno wrote: > Il 19/09/22 10:40, Hsin-Yi Wang ha scritto: >> On Mon, Sep 19, 2022 at 4:39 PM Nícolas F. R. A. Prado >> wrote: >>> >>> As the comment right before the mtk_dsi_stop() call advises, >>> mtk_dsi_stop() should only be called after >>>

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry

2022-09-21 Thread Zheng Hacker
I've sent it using git send-email with another email account (zyytlz...@163.com) Regards, Zheng Wang Jani Nikula 于2022年9月19日周一 17:30写道: > > On Mon, 19 Sep 2022, Zheng Wang <1002992...@qq.com> wrote: > > From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > > From: xmzyshypnc

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 20

Re: [PATCH V2 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 bindings

2022-09-21 Thread Krzysztof Kozlowski
On 20/09/2022 19:09, Chris Morgan wrote: > From: Chris Morgan > > Add documentation for the Samsung AMS495QA01 panel. > > Signed-off-by: Chris Morgan > --- > .../display/panel/samsung,ams495qa01.yaml | 46 +++ > 1 file changed, 46 insertions(+) > create mode 100644 >

Re: [PATCH v3 0/8] Support for NVDEC on Tegra234

2022-09-21 Thread Krzysztof Kozlowski
On 21/09/2022 09:50, Mikko Perttunen wrote: > On 9/21/22 10:26, Krzysztof Kozlowski wrote: >> On 20/09/2022 10:11, Mikko Perttunen wrote: >>> From: Mikko Perttunen >>> >>> v3: >>> * Updated patch 3 based on comments >>> >>> v2: >>> * Updated patches 1,3 based on comments >>> * Added Acked-by to

Re: [PATCH 11/18] phy: mediatek: hdmi: mt8173: use common helper to access registers

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use MediaTek phy's common helper to access registers, then we can remove hdmi's I/O helpers. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 09/18] phy: mediatek: hdmi: mt8173: use GENMASK to generate bits mask

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use GENMASK() macro to generate bits mask Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 10/18] phy: mediatek: hdmi: mt8173: use FIELD_PREP to prepare bits field

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use FIELD_PREP() macro to prepare bits field value, then no need define macros of bits offset. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 07/18] phy: mediatek: hdmi: mt2701: use FIELD_PREP to prepare bits field

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use FIELD_PREP() macro to prepare bits field value, then no need define macros of bits offset. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 12/18] phy: mediatek: hdmi: remove register access helpers

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Remove private register access helpers, use the common ones instead. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 2/2] drm/panfrost: replace endian-specific types with generic ones

2022-09-21 Thread Steven Price
On 20/09/2022 23:13, Alyssa Rosenzweig wrote: > Tentative r-b, but we *do* need to make a decision on how we want to > handle endianness. I don't have strong feelings but the results of that > discussion should go in the commit message. Linux currently treats the dump objects specially - the

Re: [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-21 Thread Iddamsetty, Aravind
On 20-09-2022 13:05, Jani Nikula wrote: > On Tue, 20 Sep 2022, Aravind Iddamsetty wrote: >> As an integrated GPU, MTL does not have local memory and >> HAS_LMEM() returns false. However the platform's stolen memory >> is presented via BAR2 (i.e., the BAR we traditionally consider >> to be the

[PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function

2022-09-21 Thread Tommaso Merciai
The builds of arm64 allmodconfig with clang failed to build next-20220920 with the following result: 1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized] note: initialize the variable 'r' to silence this warning This fix compilation error Signed-off-by: Tommaso

Re: [PATCH v3 0/8] Support for NVDEC on Tegra234

2022-09-21 Thread Krzysztof Kozlowski
On 20/09/2022 10:11, Mikko Perttunen wrote: > From: Mikko Perttunen > > v3: > * Updated patch 3 based on comments > > v2: > * Updated patches 1,3 based on comments > * Added Acked-by to patch 2 > > Original message: > > Hi all, > > this series adds support for the HW video decoder, NVDEC, >

Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function

2022-09-21 Thread Tommaso Merciai
Hi Christian, On Tue, Sep 20, 2022 at 02:23:58PM +0200, Christian König wrote: > Am 20.09.22 um 14:22 schrieb Tommaso Merciai: > > The builds of arm64 allmodconfig with clang failed to build > > next-20220920 with the following result: > > > > 1190:3: error: variable 'r' is uninitialized when

Re: [PATCH 16/18] phy: mediatek: mipi: mt8183: use GENMASK to generate bits mask

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use GENMASK() macro to generate bits mask Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 18/18] phy: mediatek: mipi: remove register access helpers

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Remove private register access helpers, use the common ones instead. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 15/18] phy: mediatek: mipi: mt8173: use common helper to access registers

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use MediaTek phy's common helper to access registers, then we can remove mipi-dsi's I/O helpers. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 14/18] phy: mediatek: mipi: mt8173: use FIELD_PREP to prepare bits field

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use FIELD_PREP() macro to prepare bits field value, then no need define macros of bits offset. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 17/18] phy: mediatek: mipi: mt8183: use common helper to access registers

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Use MediaTek phy's common helper to access registers, then we can remove mipi-dsi's I/O helpers. Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 01/18] phy: mediatek: add a new helper to update bitfield

2022-09-21 Thread AngeloGioacchino Del Regno
Il 20/09/22 11:00, Chunfeng Yun ha scritto: Due to FIELD_PREP() macro can be used to prepare a bitfield value, local ones can be remove; add the new helper to make bitfield update easier. Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-io.h | 7 +++ 1 file changed, 7

Re: [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-21 Thread Das, Nirmoy
Hi Matt On 9/20/2022 7:06 PM, Nirmoy Das wrote: For delayed BO release i915_ttm_delete_mem_notify() gets called twice, once with proper bo->resource and another time with NULL. We shouldn't do anything for the 2nd time as we already cleanedup the obj once. References:

Re: [PATCH v3] drm/sched: Add FIFO sched policy to run queue v3

2022-09-21 Thread Luben Tuikov
Inlined: On 2022-09-20 15:16, Andrey Grodzovsky wrote: > > On 2022-09-19 23:11, Luben Tuikov wrote: >> Please run this patch through checkpatch.pl, as it shows >> 12 warnings with it. Use these command line options: >> "--strict --show-types". >> >> Inlined: >> >> On 2022-09-13 16:40, Andrey

Re: [PATCH v2 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header

2022-09-21 Thread Maxime Ripard
Hi, On Tue, Sep 20, 2022 at 06:01:08PM +0200, Stefan Wahren wrote: > Am 20.09.22 um 14:50 schrieb Maxime Ripard: > > We'll need the clock IDs in more drivers than just the clock driver from > > now on, so let's move them in the firmware header. > > recently as i reviewed the clk-raspberrypi i

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-21 Thread Iddamsetty, Aravind
replying here for earlier comments too. On 21-09-2022 01:35, Lucas De Marchi wrote: > On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote: >> On Tue, Sep 20, 2022 at 12:49:40PM +0530, Aravind Iddamsetty wrote: >>> As an integrated GPU, MTL does not have local memory and >>> HAS_LMEM()

Re: [Intel-gfx] [RFC PATCH v3 07/17] drm/i915/vm_bind: Handle persistent vmas

2022-09-21 Thread Niranjana Vishwanathapura
On Mon, Sep 12, 2022 at 04:16:06PM +0300, Jani Nikula wrote: On Sat, 27 Aug 2022, Andi Shyti wrote: From: Niranjana Vishwanathapura Treat VM_BIND vmas as persistent across execbuf ioctl calls and handle them during the request submission in the execbuff path. Support eviction by maintaining

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

2022-09-21 Thread Krzysztof Kozlowski
On 20/09/2022 10:11, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra234 NVDEC firmware is loaded from a secure carveout, where it > has been loaded by a bootloader. When booting NVDEC, we need to tell it > the address of this firmware, which we can determine by checking the >

Re: [Intel-gfx] [RFC v4 02/14] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Signed-off-by: Niranjana Vishwanathapura ---

Re: [PATCH 2/2] drm/panfrost: replace endian-specific types with generic ones

2022-09-21 Thread Robin Murphy
On 2022-09-21 09:48, Steven Price wrote: On 20/09/2022 23:13, Alyssa Rosenzweig wrote: Tentative r-b, but we *do* need to make a decision on how we want to handle endianness. I don't have strong feelings but the results of that discussion should go in the commit message. Linux currently

RE: [PATCH] virt: acrn: obtain pa from VMA with PFNMAP flag

2022-09-21 Thread Huang, Yonghua
Hi Daniel, Thank you for this info, we will fix this issue. Almost miss this mail, sorry! -Yonghua > -Original Message- > From: Daniel Vetter > Sent: Wednesday, August 10, 2022 20:20 > To: Huang, Yonghua > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; >

Re: [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

2022-09-21 Thread Dmitry Osipenko
On 9/20/22 17:13, Sumit Semwal wrote: > Hi Dmitry, > > Thanks very much for the series. > > On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko > wrote: >> >> Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking >> specification by asserting that the reservation lock is held. >

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-09-21 Thread Thomas Zimmermann
Hi Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt: On Wed, 2022-07-20 at 16:27 +0200, Thomas Zimmermann wrote: +#if !defined(CONFIG_PPC) +static inline void out_8(void __iomem *addr, int val) +{ } +static inline void out_le32(void __iomem *addr, int val) +{ } +static inline unsigned int

Re: [PATCH v6,2/3] drm: mediatek: Adjust the dpi output format to MT8186

2022-09-21 Thread xinlei . lee
On Wed, 2022-09-21 at 09:35 +0800, CK Hu wrote: > Hi, Xinlei: > > On Wed, 2022-09-14 at 21:21 +0800, xinlei@mediatek.com wrote: > > From: Xinlei Lee > > > > Dpi output needs to adjust the output format to dual edge for > > MT8186. > > The bridge ic on MT8186 uses the output format of > >

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-21 Thread Maxime Ripard
On Wed, Sep 07, 2022 at 06:44:53PM +0200, Noralf Trønnes wrote: > > > Den 07.09.2022 12.36, skrev Stefan Wahren: > > Hi Maxime, > > > > Am 05.09.22 um 16:57 schrieb Maxime Ripard: > >> On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: > >>> > >>> Den 01.09.2022 21.35, skrev Noralf

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-21 Thread Thomas Zimmermann
Hi Am 21.09.22 um 12:18 schrieb Ville Syrjälä: [...] Though I don't really know if a there is software relying on that behaviuor. I suppose one idea could be to keep that behaviour for the legacy ioctls but not for atomic. Ee. any fb directly specified in a legacy setcrtc/setplane/pageflip

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 01:02, Dixit, Ashutosh wrote: On Fri, 16 Sep 2022 08:00:50 -0700, Badal Nilawar wrote: diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon index e2974f928e58..bc061238e35c 100644 ---

Re: [PATCH 2/2] drm/panfrost: replace endian-specific types with generic ones

2022-09-21 Thread Alyssa Rosenzweig
> > Or of course we could just actually use native endian and detect from > > the magic which endian is in use. That would require ripping out the > > cpu_to_lexx() calls in Linux and making the user space tool more > > intelligent. I'm happy with that, but it's pushing the complexity onto Mesa. >

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Andi Shyti
Hi Badal, > +struct hwm_reg { > +}; > + > +struct hwm_drvdata { > + struct i915_hwmon *hwmon; > + struct intel_uncore *uncore; > + struct device *hwmon_dev; > + char name[12]; > +}; > + > +struct i915_hwmon { > + struct hwm_drvdata ddat; > + struct mutex hwmon_lock;

Re: [PATCH v6,3/3] drm: mediatek: Add mt8186 dpi compatible to mtk_dpi.c

2022-09-21 Thread xinlei . lee
On Wed, 2022-09-21 at 09:42 +0800, CK Hu wrote: > Hi, Xinlei: > > On Wed, 2022-09-14 at 21:21 +0800, xinlei@mediatek.com wrote: > > From: Xinlei Lee > > > > Add the compatible because use edge_cfg_in_mmsys in mt8186. > > > > Signed-off-by: Xinlei Lee > > --- > >

Re: [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON

Re: [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter)

Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2022-09-21 Thread Andy Shevchenko
On Wed, Sep 21, 2022 at 4:48 AM ChiaEn Wu wrote: > On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo wrote: > > On Mon, Aug 29, 2022 ChiaEn Wu wrote: > > > +#define MT6370_ITORCH_MIN_uA 25000 > > > +#define MT6370_ITORCH_STEP_uA 12500 > > > +#define MT6370_ITORCH_MAX_uA

Re: [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are

Re: [PATCH v2 08/10] drm/ofdrm: Add CRTC state

2022-09-21 Thread Thomas Zimmermann
Hi Am 26.07.22 um 15:36 schrieb Javier Martinez Canillas: On 7/20/22 16:27, Thomas Zimmermann wrote: Add a dedicated CRTC state to ofdrm to later store information for palette updates. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/ofdrm.c | 62

Re: [PATCH v2 07/10] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-09-21 Thread Thomas Zimmermann
Hi Am 26.07.22 um 15:17 schrieb Javier Martinez Canillas: Hello Thomas, On 7/20/22 16:27, Thomas Zimmermann wrote: Open Firmware provides basic display output via the 'display' node. DT platform code already provides a device that represents the node's framebuffer. Add a DRM driver for the

Re: [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: - Updated the date and kernel version in feature description v3: - Cleaned up hwm_energy function and removed unused function i915_hwmon_energy_status_get

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-09-21 Thread Thomas Zimmermann
Hi Am 05.08.22 um 02:22 schrieb Benjamin Herrenschmidt: On Tue, 2022-07-26 at 16:40 +0200, Michal Suchánek wrote: Hello, On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: On 7/20/22 16:27, Thomas Zimmermann wrote: Add a per-model device-function structure in

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-09-21 Thread Chris Morgan
On Wed, Sep 21, 2022 at 08:51:34AM +0200, Krzysztof Kozlowski wrote: > On 20/09/2022 16:59, Chris Morgan wrote: > > From: Chris Morgan > > > > Add documentation for the NewVision NV3051D panel bindings. > > Note that for the two expected consumers of this panel binding > > the underlying LCD

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Nilawar, Badal
On 21-09-2022 18:14, Andi Shyti wrote: Hi Badal, +struct hwm_reg { +}; + +struct hwm_drvdata { + struct i915_hwmon *hwmon; + struct intel_uncore *uncore; + struct device *hwmon_dev; + char name[12]; +}; + +struct i915_hwmon { + struct hwm_drvdata ddat; +

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Andi Shyti
Hi Badal, > > > +struct hwm_reg { > > > +}; > > > + > > > +struct hwm_drvdata { > > > + struct i915_hwmon *hwmon; > > > + struct intel_uncore *uncore; > > > + struct device *hwmon_dev; > > > + char name[12]; > > > +}; > > > + > > > +struct i915_hwmon { > > > + struct hwm_drvdata ddat; > > > +

Re: [PATCH v10 3/9] compiler_types.h: Add assert_type to catch type mis-match while compiling

2022-09-21 Thread Gwan-gyeong Mun
On 9/13/22 3:01 PM, Kees Cook wrote: On Fri, Sep 09, 2022 at 07:59:07PM +0900, Gwan-gyeong Mun wrote: It adds assert_type and assert_typable macros to catch type mis-match while compiling. The existing typecheck() macro outputs build warnings, but the newly added assert_type() macro uses the

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-21 Thread Maxime Ripard
Hi, Thanks again for your help On Sun, Sep 11, 2022 at 06:30:39AM +0200, kFYatek wrote: > W dniu 9.09.2022 o 16:00, Maxime Ripard pisze: > > On Wed, Sep 07, 2022 at 11:31:21PM +0200, Mateusz Kwiatkowski wrote: > >> The "canonical" modelines (at least for vc4's VEC, see the notes below): > >> >

Re: [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3:

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-09-21 Thread Chris Morgan
On Wed, Sep 21, 2022 at 05:21:19PM +0200, Krzysztof Kozlowski wrote: > On 21/09/2022 16:38, Chris Morgan wrote: > >>> + compatible: > >>> +items: > >>> + - enum: > >>> + - anbernic,rg353p-panel > >> > >> Are these vendor prefixs documented? > > > > Yes, they are in another

[PATCH AUTOSEL 5.10 7/7] drm/rockchip: Fix return type of cdn_dp_connector_mode_valid

2022-09-21 Thread Sasha Levin
From: Nathan Huckleberry [ Upstream commit b0b9408f132623dc88e78adb5282f74e4b64bb57 ] The mode_valid field in drm_connector_helper_funcs is expected to be of type: enum drm_mode_status (* mode_valid) (struct drm_connector *connector, struct drm_display_mode

[PATCH AUTOSEL 5.4 4/5] drm/amd/display: Limit user regamma to a valid value

2022-09-21 Thread Sasha Levin
From: Yao Wang1 [ Upstream commit 3601d620f22e37740cf73f8278eabf9f2aa19eb7 ] [Why] For HDR mode, we get total 512 tf_point and after switching to SDR mode we actually get 400 tf_point and the rest of points(401~512) still use dirty value from HDR mode. We should limit the rest of the points to

[PATCH AUTOSEL 5.15 07/10] drm/amd/display: Reduce number of arguments of dml31's CalculateWatermarksAndDRAMSpeedChangeSupport()

2022-09-21 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 37934d4118e22bceb80141804391975078f31734 ] Most of the arguments are identical between the two call sites and they can be accessed through the 'struct vba_vars_st' pointer. This reduces the total amount of stack space that

[PATCH AUTOSEL 5.10 2/7] drm/gma500: Fix BUG: sleeping function called from invalid context errors

2022-09-21 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 63e37a79f7bd939314997e29c2f5a9f0ef184281 ] gma_crtc_page_flip() was holding the event_lock spinlock while calling crtc_funcs->mode_set_base() which takes ww_mutex. The only reason to hold event_lock is to clear gma_crtc->page_flip_event on mode_set_base()

[PATCH AUTOSEL 5.10 6/7] drm/amd/display: Mark dml30's UseMinimumDCFCLK() as noinline for stack usage

2022-09-21 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 41012d715d5d7b9751ae84b8fb255e404ac9c5d0 ] This function consumes a lot of stack space and it blows up the size of dml30_ModeSupportAndSystemConfigurationFull() with clang:

[PATCH AUTOSEL 5.15 09/10] drm/amd/display: Mark dml30's UseMinimumDCFCLK() as noinline for stack usage

2022-09-21 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 41012d715d5d7b9751ae84b8fb255e404ac9c5d0 ] This function consumes a lot of stack space and it blows up the size of dml30_ModeSupportAndSystemConfigurationFull() with clang:

[PATCH AUTOSEL 4.19 2/3] drm/amd/display: Limit user regamma to a valid value

2022-09-21 Thread Sasha Levin
From: Yao Wang1 [ Upstream commit 3601d620f22e37740cf73f8278eabf9f2aa19eb7 ] [Why] For HDR mode, we get total 512 tf_point and after switching to SDR mode we actually get 400 tf_point and the rest of points(401~512) still use dirty value from HDR mode. We should limit the rest of the points to

[PATCH AUTOSEL 4.19 3/3] drm/rockchip: Fix return type of cdn_dp_connector_mode_valid

2022-09-21 Thread Sasha Levin
From: Nathan Huckleberry [ Upstream commit b0b9408f132623dc88e78adb5282f74e4b64bb57 ] The mode_valid field in drm_connector_helper_funcs is expected to be of type: enum drm_mode_status (* mode_valid) (struct drm_connector *connector, struct drm_display_mode

[PATCH AUTOSEL 5.4 5/5] drm/rockchip: Fix return type of cdn_dp_connector_mode_valid

2022-09-21 Thread Sasha Levin
From: Nathan Huckleberry [ Upstream commit b0b9408f132623dc88e78adb5282f74e4b64bb57 ] The mode_valid field in drm_connector_helper_funcs is expected to be of type: enum drm_mode_status (* mode_valid) (struct drm_connector *connector, struct drm_display_mode

[PATCH AUTOSEL 5.4 3/5] drm/amdgpu: use dirty framebuffer helper

2022-09-21 Thread Sasha Levin
From: Hamza Mahfooz [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ] Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs struct. Signed-off-by: Hamza Mahfooz Acked-by: Alex Deucher Signed-off-by:

Re: [PATCH v3 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-21 Thread Jason-JH Lin
On Wed, 2022-09-21 at 08:28 +0200, Krzysztof Kozlowski wrote: > On 21/09/2022 06:16, Jason-JH Lin wrote: > > Hi Krzysztof, > > > > Thanks for the reviews. > > > > On Tue, 2022-09-20 at 17:25 +0200, Krzysztof Kozlowski wrote: > > > On 20/09/2022 16:01, Jason-JH.Lin wrote: > > > > For previous

  1   2   >