[PATCH v2 03/14] drm/msm/a6xx: Introduce GMU wrapper support

2023-02-14 Thread Konrad Dybcio
Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs but don't implement the associated GMUs. This is due to the fact that the GMU directly pokes at RPMh. Sadly, this means we have to take care of enabling & scaling power rails, clocks and bandwidth ourselves. Reuse existing

[PATCH v2 05/14] drm/msm/adreno: Disable has_cached_coherent for A610/A619_holi

2023-02-14 Thread Konrad Dybcio
These SKUs don't support the feature. Disable it to make the GPU stop crashing after almost each and every submission - the received data on the GPU end was simply incomplete in garbled, resulting in almost nothing being executed properly. Signed-off-by: Konrad Dybcio ---

[PATCH v2 06/14] drm/msm/gpu: Use dev_pm_opp_set_rate for non-GMU GPUs

2023-02-14 Thread Konrad Dybcio
Currently we only utilize the OPP table connected to the GPU for getting (available) frequencies. We do however need to scale the voltage rail(s) accordingly to ensure that we aren't trying to run the GPU at 1GHz with a VDD_LOW vote, as that would result in an otherwise inexplainable hang. Tell

[PATCH v2 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-02-14 Thread Konrad Dybcio
A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 (blair). This is what seems to be a first occurrence of this happening, but it's easy to overcome by guarding the SoC-specific fuse values with of_machine_is_compatible(). Do just that to enable frequency limiting on these

[PATCH v2 14/14] drm/msm/a6xx: Add A610 speedbin support

2023-02-14 Thread Konrad Dybcio
A610 is implemented on at least three SoCs: SM6115 (bengal), SM6125 (trinket) and SM6225 (khaje). Trinket does not support speed binning (only a single SKU exists) and we don't yet support khaje upstream. Hence, add a fuse mapping table for bengal to allow for per-chip frequency limiting.

[PATCH v2 10/14] drm/msm/a6xx: Fix up A6XX protected registers

2023-02-14 Thread Konrad Dybcio
One of the protected ranges was too small (compared to the data we have downstream). Fix it. Fixes: 408434036958 ("drm/msm/a6xx: update/fix CP_PROTECT initialization") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 11/14] drm/msm/a6xx: Enable optional icc voting from OPP tables

2023-02-14 Thread Konrad Dybcio
On GMU-equipped GPUs, the GMU requests appropriate bandwidth votes for us. This is however not the case for the other GPUs. Add the dev_pm_opp_of_find_icc_paths() call to let the OPP framework handle bus voting as part of power level setting. Signed-off-by: Konrad Dybcio ---

[PATCH v2 12/14] drm/msm/a6xx: Use "else if" in GPU speedbin rev matching

2023-02-14 Thread Konrad Dybcio
The GPU can only be one at a time. Turn a series of ifs into if + elseifs to save some CPU cycles. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c

Re: [PATCH 01/10] drm/amd/display: Turn global functions into static

2023-02-14 Thread Alex Deucher
On Mon, Feb 13, 2023 at 3:49 PM Arthur Grillo wrote: > > Turn global functions that are only used locally into static ones. This > reduces the number of -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo The first hunk was already fixed, but I applied the second hunk. Alex > ---

Re: [PATCH 03/10] drm/amd/amdgpu: Add function prototypes to headers

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Add function prototypes to headers to reduce the number of > -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 09/10] drm/amd/display: Make variables declaration inside ifdef guard

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Make variables declaration inside ifdef guard, as they are only used > inside the same ifdef guard. This remove some of the > -Wunused-but-set-variable warning. > > Signed-off-by: Arthur Grillo > --- >

Re: [RFC PATCH 5/7] drm/msm/dpu: Document and enable TEAR interrupts on DSI interfaces

2023-02-14 Thread Abhinav Kumar
On 2/14/2023 5:06 AM, Marijn Suijten wrote: On 2023-02-13 19:09:32, Abhinav Kumar wrote: On 2/13/2023 1:46 PM, Dmitry Baryshkov wrote: On 13/02/2023 21:37, Jessica Zhang wrote: On 12/31/2022 1:50 PM, Marijn Suijten wrote: All SoCs since DPU 5.0.0 (and seemingly up until and including

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Harry Wentland
On 2/14/23 10:49, Sebastian Wick wrote: > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > wrote: >> >> On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: >>> >>> >>> On 2/3/23 10:19, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: >

Re: [PATCH 4/4] drm/msm/a5xx: fix context faults during ring switch

2023-02-14 Thread Rob Clark
On Mon, Feb 13, 2023 at 6:10 PM Dmitry Baryshkov wrote: > > The rptr_addr is set in the preempt_init_ring(), which is called from > a5xx_gpu_init(). It uses shadowptr() to set the address, however the > shadow_iova is not yet initialized at that time. Move the rptr_addr > setting to the

Re: [PATCH 04/10] drm/amd/display: Add previously missing includes

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Add includes that were previously missing to reduce the number of > -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 1 + >

[PATCH v2 00/14] GMU-less A6xx support (A610, A619_holi)

2023-02-14 Thread Konrad Dybcio
v1 -> v2: - Fix A630 values in [2/14] - Fix [6/14] for GMU-equipped GPUs Link to v1: https://lore.kernel.org/linux-arm-msm/20230126151618.225127-1-konrad.dyb...@linaro.org/ This series concludes my couple-weeks-long suffering of figuring out the ins and outs of the "non-standard" A6xx GPUs

Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet 3 10IGL5

2023-02-14 Thread Hans de Goede
Hi, On 2/14/23 17:46, Darrell Kavanagh wrote: > Another Lenovo convertable where the panel is installed landscape but is > reported to the kernel as portrait. > > Signed-off-by: Darrell Kavanagh Thanks, patch looks good to me: Reviewed-by: Hans de Goede Note for other developers the reason

Re: [PATCH 02/10] drm/amd/display: Add function prototypes to headers

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Add function prototypes to headers to reduce the number of > -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.h | 2 ++ >

Re: [PATCH 05/10] drm/amd/display: Fix excess arguments on kernel-doc

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Remove arguments present on kernel-doc that are not present on the > function declaration and add the new ones if present. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c| 15

Re: [PATCH v4 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-14 Thread Teres Alexis, Alan Previn
On Thu, 2023-02-09 at 16:42 -0800, Teres Alexis, Alan Previn wrote: > Add MTL's function for ARB session creation using PXP firmware > version 4.3 ABI structure format. > > Also add MTL's function for ARB session invalidation but this > reuses PXP firmware version 4.2 ABI structure format. > >

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > > wrote: > >> > >> On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > >>> > >>> > >>> On 2/3/23 10:19, Ville Syrjälä wrote: >

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-14 Thread Ville Syrjälä
On Tue, Feb 14, 2023 at 02:27:19PM -0500, Harry Wentland wrote: > > > On 2/14/23 05:28, Ville Syrjälä wrote: > > On Tue, Feb 14, 2023 at 10:54:27AM +0100, Jonas Ådahl wrote: > >> On Tue, Feb 14, 2023 at 11:25:56AM +0200, Ville Syrjälä wrote: > >>> On Thu, Feb 09, 2023 at 03:16:23PM +0100, Jonas

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Harry Wentland
On 2/14/23 14:45, Sebastian Wick wrote: On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: On 2/14/23 10:49, Sebastian Wick wrote: On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: On 2/3/23 10:19, Ville Syrjälä

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-14 Thread Rob Clark
On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > In i915 we have this concept of "wait boosting" where we give a priority boost > for instance to fences which are actively waited upon from userspace. This has > it's pros and cons and can certainly be discussed

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-14 Thread Rob Clark
On Tue, Feb 14, 2023 at 11:14 AM Rob Clark wrote: > > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > wrote: > > > > From: Tvrtko Ursulin > > > > In i915 we have this concept of "wait boosting" where we give a priority > > boost > > for instance to fences which are actively waited upon from

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-14 Thread Harry Wentland
On 2/14/23 05:28, Ville Syrjälä wrote: On Tue, Feb 14, 2023 at 10:54:27AM +0100, Jonas Ådahl wrote: On Tue, Feb 14, 2023 at 11:25:56AM +0200, Ville Syrjälä wrote: On Thu, Feb 09, 2023 at 03:16:23PM +0100, Jonas Ådahl wrote: On Wed, Feb 08, 2023 at 11:10:16PM +0200, Ville Syrjala wrote:

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Ville Syrjälä
On Tue, Feb 14, 2023 at 08:45:00PM +0100, Sebastian Wick wrote: > On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: > > > > > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > > > wrote: > > >> > > >> On Fri, Feb 03, 2023 at 10:24:52AM -0500,

Re: [PATCH 1/1] drm/bridge: analogix_dp: add a quirk for Bob panel

2023-02-14 Thread Brian Norris
Hi, You seem to have sent this twice, perhaps to adjust the To/CC list. I think I've picked the right one to reply to, but it's usually nice to use a "v2" notation or otherwise put a comment somewhere in the email. On Wed, Feb 08, 2023 at 12:44:06PM +0800, Kencp huang wrote: > From: zain wang >

[PATCH] drm/amd/display: only warn once in dce110_edp_wait_for_hpd_ready()

2023-02-14 Thread Hamza Mahfooz
Since, hot plugging eDP displays isn't supported, it is sufficient for us to warn about the lack of a connected display once. So, use ASSERT() in dce110_edp_wait_for_hpd_ready() instead of DC_LOG_WARNING(). Signed-off-by: Hamza Mahfooz ---

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 9:10 PM Ville Syrjälä wrote: > > On Tue, Feb 14, 2023 at 08:45:00PM +0100, Sebastian Wick wrote: > > On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland > > wrote: > > > > > > > > > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > > > On Fri, Feb 3, 2023 at 5:00 PM Ville

<    1   2