[PATCH 1/2] drm/nouveau/nvkm/outp: Use WARN_ON() in conditionals in nvkm_outp_init_route()

2023-04-07 Thread Lyude Paul
Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c index 6094805fbd63..06b19883a06b 100644 ---

[PATCH 2/2] drm/nouveau/kms: Add INHERIT ioctl to nvkm/nvif for reading IOR state

2023-04-07 Thread Lyude Paul
Now that we're supporting things like Ada and the GSP, there's situations where we really need to actually know the display state that we're starting with when loading the driver in order to prevent breaking GSP expectations. The first step in doing this is making it so that we can read the

Re: [PATCH v4 34/42] drm/msm/dpu: enable DSPP and DSC on sc8180x

2023-04-07 Thread Dmitry Baryshkov
On 08/04/2023 02:43, Abhinav Kumar wrote: On 4/4/2023 6:06 AM, Dmitry Baryshkov wrote: Enable DSPP and DSC hardware blocks on sc8180x platform. Signed-off-by: Dmitry Baryshkov ---   .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h   | 26 +--   1 file changed, 24 insertions(+), 2

Re: [PATCH] drm/vmwgfx: remove unused mksstat_init_record function

2023-04-07 Thread Nick Desaulniers
On Fri, Mar 24, 2023 at 12:54 PM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:716:21: error: unused function > 'mksstat_init_record' [-Werror,-Wunused-function] > static inline char *mksstat_init_record(mksstat_kern_stats_t stat_idx, > ^ >

Re: [PATCH] drm/nouveau/svm: remove unused ret variable

2023-04-07 Thread Nick Desaulniers
On Wed, Mar 29, 2023 at 4:14 PM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/nouveau/nouveau_svm.c:929:6: error: variable > 'ret' set but not used [-Werror,-Wunused-but-set-variable] > int ret; > ^ > This variable is not used so remove it. > > Signed-off-by:

Re: [PATCH 2/2] drm/nouveau/kms: Add INHERIT ioctl to nvkm/nvif for reading IOR state

2023-04-07 Thread kernel test robot
Hi Lyude, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.3-rc5 next-20230406]

Re: [PATCH] drm/amd/display: remove unused matching_stream_ptrs variable

2023-04-07 Thread Nick Desaulniers
On Fri, Apr 7, 2023 at 10:52 AM Nick Desaulniers wrote: > > Jimmy, can you review? > > The change LGTM; but I'm not sure if there was something else intended here. Nevermind, Jimmy's email address bounced. Reviewed-by: Nick Desaulniers > > On Sat, Mar 25, 2023 at 6:45 AM Tom Rix wrote: > > >

Re: [PATCH v5 2/9] video/aperture: use generic code to figure out the vga default device

2023-04-07 Thread Helge Deller
On 4/6/23 15:21, Thomas Zimmermann wrote: From: Daniel Vetter Since vgaarb has been promoted to be a core piece of the pci subsystem we don't have to open code random guesses anymore, we actually know this in a platform agnostic way, and there's no need for an x86 specific hack. See also

[PATCH v5 2/4] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 on sm8450

2023-04-07 Thread Dmitry Baryshkov
Mark DSPP_2 and DSPP_3 as used for LM_2 and LM_3 Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: (subset) [PATCH v6 0/9] Fix DSI host idx detection on HW revision clash

2023-04-07 Thread Bjorn Andersson
On Sat, 18 Mar 2023 14:42:46 +0100, Konrad Dybcio wrote: > v5 -> v6: > - Squash both fixes that concerned the deprecated QCM2290 compatible to > avoid warnings > > v5: > https://lore.kernel.org/r/20230307-topic-dsi_qcm-v5-0-9d4235b77...@linaro.org > > v4 -> v5: > - Drop superfluous items:

Re: (subset) [PATCH v2 00/23] drm/msm+PM+icc: Make job_run() reclaim-safe

2023-04-07 Thread Bjorn Andersson
On Mon, 20 Mar 2023 07:43:22 -0700, Rob Clark wrote: > From: Rob Clark > > Inspired by > https://lore.kernel.org/dri-devel/20200604081224.863494-10-daniel.vet...@ffwll.ch/ > it seemed like a good idea to get rid of memory allocation in job_run() > fence signaling path, and use lockdep

Re: [PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-04-07 Thread Nick Desaulniers
On Fri, Mar 31, 2023 at 9:40 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: variable > 'num_of_active_display' set but not used [-Werror,-Wunused-but-set-variable] > int num_of_active_display = 0; > ^ > This

Re: [PATCH v4 34/42] drm/msm/dpu: enable DSPP and DSC on sc8180x

2023-04-07 Thread Abhinav Kumar
On 4/4/2023 6:06 AM, Dmitry Baryshkov wrote: Enable DSPP and DSC hardware blocks on sc8180x platform. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 26 +-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/kmb: remove unused set_test_mode_src_osc_freq_target_low, hi_bits functions

2023-04-07 Thread Nick Desaulniers
On Sat, Mar 18, 2023 at 6:39 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/kmb/kmb_dsi.c:822:2: error: unused function > 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function] > set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, >

Re: [PATCH v15 01/10] device property: Add remote endpoint to devcon matcher

2023-04-07 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-03-31 02:11:36) > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to evaluate those for a match too,

Re: [PATCH v4 00/42] drm/msm/dpu: rework HW catalog

2023-04-07 Thread Dmitry Baryshkov
On Tue, 04 Apr 2023 16:05:40 +0300, Dmitry Baryshkov wrote: > This huge series attempts to restructure the DPU HW catalog into a > manageable and reviewable data set. In order to ease review and testing > I merged all the necessary fixes into this series. Also I cherry-picked > & slightly fixed

Re: [PATCH] drm/qxl: remove unused num_relocs variable

2023-04-07 Thread Nick Desaulniers
On Fri, Mar 31, 2023 at 10:24 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/qxl/qxl_ioctl.c:149:14: error: variable > 'num_relocs' set but not used [-Werror,-Wunused-but-set-variable] > int i, ret, num_relocs; > ^ > This variable is not used so

Re: [PATCH] drm/nouveau/acr: remove unused loc variable

2023-04-07 Thread Nick Desaulniers
On Fri, Mar 31, 2023 at 1:42 PM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: error: variable > 'loc' set but not used [-Werror,-Wunused-but-set-variable] > u32 loc, sig, cnt, *meta; > ^ > This variable is

Re: [Nouveau] [PATCH] drm/nouveau/fb: add missing sysmen flush callbacks

2023-04-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2023-04-05 at 13:04 +0200, Karol Herbst wrote: > Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203 > Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common > code") > Signed-off-by: Karol Herbst > --- >

[PATCH v5 4/4] drm/msm/dpu: use CTL_SC7280_MASK for sm8450's ctl_0

2023-04-07 Thread Dmitry Baryshkov
On sm8450 platform the CTL_0 doesn't differ from the rest of CTL blocks, so switch it to CTL_SC7280_MASK too. Some background: original commit 100d7ef6995d ("drm/msm/dpu: add support for SM8450") had all (relevant at that time) bit spelled individually. Then commit 0e91bcbb0016 ("drm/msm/dpu: Add

[PATCH v5 3/4] drm/msm/dpu: enable DSPP and DSC on sc8180x

2023-04-07 Thread Dmitry Baryshkov
Enable DSPP and DSC hardware blocks on sc8180x platform. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 28 +-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h

[PATCH v5 1/4] drm/msm/dpu: enable DPU_CTL_SPLIT_DISPLAY for sc8280xp

2023-04-07 Thread Dmitry Baryshkov
Theoretically, since sm8150 we should be using a single CTL for the split panel case, but since we do not support it for now, fallback to DPU_CTL_SPLIT_DISPLAY. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 5 +++-- 1 file changed, 3

[PATCH v5 0/4] drm/msm/dpu: more catalog fixes

2023-04-07 Thread Dmitry Baryshkov
This is a spin-off from [1]. Since most of the patches have been merged, split away the small fixes. Continue the versioning of the patches. Changes since v4: - Fix commit message of sc8280xp patch. It is split display/panel rather than split source (Abhinav) - Added DSC_4 and DSC_5 to sc8180x

Re: [PATCH] drm/vmwgfx: remove unused vmw_overlay function

2023-04-07 Thread Nick Desaulniers
On Tue, Mar 21, 2023 at 11:24 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:56:35: error: > unused function 'vmw_overlay' [-Werror,-Wunused-function] > static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev) >

Re: [PATCH] drm/amd/display: remove unused matching_stream_ptrs variable

2023-04-07 Thread Nick Desaulniers
Jimmy, can you review? The change LGTM; but I'm not sure if there was something else intended here. On Sat, Mar 25, 2023 at 6:45 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: error: > variable 'matching_stream_ptrs' set

Re: (subset) [PATCH v3 0/5] SM8[12]50 GPU speedbin

2023-04-07 Thread Bjorn Andersson
On Fri, 31 Mar 2023 03:14:48 +0200, Konrad Dybcio wrote: > This series brings SM8[12]50 (A6[45]0) speedbin support along with a > touch-up for 8150, allowing Adreno to cooperate with the display hw. > > Tested on Xperia 5 II (SM8250 Edo PDX206) and Xperia 5 (SM8150 Kumano > Bahamut). > > v2 ->

Re: [PATCH 2/2] drm/nouveau/kms: Add INHERIT ioctl to nvkm/nvif for reading IOR state

2023-04-07 Thread kernel test robot
Hi Lyude, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.3-rc5 next-20230406]

Re: [PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-04-07 Thread Dmitry Baryshkov
On 01/04/2023 01:12, Mark Yacoub wrote: From: Sean Paul Expand upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new

Re: [PATCH v8 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-04-07 Thread Dmitry Baryshkov
On 01/04/2023 01:12, Mark Yacoub wrote: From: Sean Paul Add the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Reviewed-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub

Re: [PATCH v8 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-04-07 Thread Dmitry Baryshkov
On 01/04/2023 01:12, Mark Yacoub wrote: From: Sean Paul Add the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Reviewed-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub

[PATCH 0/5] Fix mediatek-drm coverity issues

2023-04-07 Thread Jason-JH . Lin
Add this patch series to fix these mediatek-drm coverity issues. Jason-JH.Lin (5): drm/mediatek: Remove freeing not dynamic allocated memory drm/mediatek: Add cnt checking for coverity issue drm/mediatek: Add initialization for mtk_gem_obj drm/mediatek: Add casting before assign

[PATCH 4/5] drm/mediatek: Add casting before assign

2023-04-07 Thread Jason-JH . Lin
Add casting before assign to avoid the unintentional integer overflow or unintended sign extension. Signed-off-by: Jason-JH.Lin Fixes: 1a64a7aff8da ("drm/mediatek: Fix cursor plane no update") --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 20

[PATCH 5/5] drm/mediatek: Fix dereference before null check

2023-04-07 Thread Jason-JH . Lin
Null-checking state suggests that it may be null, but it has already been dereferenced on drm_atomic_get_new_plane_state(state, plane). The parameter state will never be NULL currently, so just remove the state is NULL flow in this function. Signed-off-by: Jason-JH.Lin Fixes: 5ddb0bd4ddc3

[PATCH 1/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-07 Thread fei . yang
From: Fei Yang On MTL, GT can no longer allocate on LLC - only the CPU can. This, along with addition of support for ADM/L4 cache calls a MOCS/PAT table update. Also defines PTE encode functions for MTL as it has different PAT index definition than previous platforms. BSpec: 44509, 45101, 44235

Re: [PATCH] drm/msm/adreno: fix sparse warnings in a6xx code

2023-04-07 Thread Javier Martinez Canillas
Dmitry Baryshkov writes: > Sparse reports plenty of warnings against the a6xx code because of > a6xx_gmu::mmio and a6xx_gmu::rscc members. For some reason they were > defined as __iomem pointers rather than pointers to __iomem memory. > Correct the __iomem attribute. > > Fixes: 02ef80c54e7c

[PATCH 2/5] drm/mediatek: Add cnt checking for coverity issue

2023-04-07 Thread Jason-JH . Lin
CERT-C Characters and Strings (CERT STR31-C) all_drm_priv[cnt] evaluates to an address that could be at negative offset of an array. In mtk_drm_get_all_drm_priv(): Guarantee that storage for strings has sufficient space for character data and the null terminator. So change cnt to unsigned int

[PATCH 3/5] drm/mediatek: Add initialization for mtk_gem_obj

2023-04-07 Thread Jason-JH . Lin
Calling mtk_gem_obj = kzalloc() which returns uninitialized memory, because mtk_gem_obj is uninitialized. It may cause using uninitialized value mtk_gem_obj->base.resv when calling drm_gem_object_init(). So add initialization for mtk_gem_obj. Signed-off-by: Jason-JH.Lin Fixes: 119f5173628a

[PATCH 1/5] drm/mediatek: Remove freeing not dynamic allocated memory

2023-04-07 Thread Jason-JH . Lin
Fixing the coverity issue of: mtk_drm_cmdq_pkt_destroy frees address of mtk_crtc->cmdq_handle So remove the free function. Signed-off-by: Jason-JH.Lin Fixes: 7627122fd1c0 ("drm/mediatek: Add cmdq_handle in mtk_crtc") --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 - 1 file changed, 1

[PATCH 5/8] drm/i915: preparation for using PAT index

2023-04-07 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

[PATCH 3/8] drm/i915/mtl: workaround coherency issue for Media

2023-04-07 Thread fei . yang
From: Fei Yang This patch implements Wa_22016122933. In MTL, memory writes initiated by Media tile update the whole cache line even for partial writes. This creates a coherency problem for cacheable memory if both CPU and GPU are writing data to different locations within a single cache line.

[PATCH 6/8] drm/i915: use pat_index instead of cache_level

2023-04-07 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

[PATCH 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-07 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out its life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[PATCH 2/8] drm/i915/mtl: enforce mtl PTE encode

2023-04-07 Thread fei . yang
From: Fei Yang PTE encode functions are platform dependent. This patch ensures the correct PTE encode function is used by calling pte_encode function pointer instead of the hardcoded gen8 version of PTE encode. Signed-off-by: Fei Yang --- drivers/gpu/drm/i915/display/intel_dpt.c | 2 +-

[PATCH 7/8] drm/i915: making mtl pte encode generic for gen12

2023-04-07 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Cc: Andi Shyti

[PATCH 4/8] drm/i915/mtl: end support for set caching ioctl

2023-04-07 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-07 Thread fei . yang
From: Fei Yang The series includes patches needed to enable MTL. Also add new extension for GEM_CREATE uAPI to let user space set cache policy for buffer objects. Fei Yang (8): drm/i915/mtl: Define MOCS and PAT tables for MTL drm/i915/mtl: enforce mtl PTE encode drm/i915/mtl: workaround

Re: [CI] drm/i915/mtl: Define GuC firmware version for MTL

2023-04-07 Thread Rodrigo Vivi
On Thu, Apr 06, 2023 at 05:37:58PM -0700, Lucas De Marchi wrote: > On Fri, Mar 31, 2023 at 03:52:16PM -0700, john.c.harri...@intel.com wrote: > > From: John Harrison > > > > First release of GuC for Meteorlake. > > > > NB: As this is still pre-release and likely to change, use explicit > >

Re: [PATCH v5 1/9] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > From: Daniel Vetter > > This one nukes all framebuffers, which is a bit much. In reality > gma500 is igpu and never shipped with anything discrete, so there should > not be any difference. > > v2: Unfortunately the framebuffer sits outside of the pci bars for >

Re: [CI] drm/i915/mtl: Define GuC firmware version for MTL

2023-04-07 Thread Lucas De Marchi
On Fri, Apr 07, 2023 at 05:45:52AM -0400, Rodrigo Vivi wrote: On Thu, Apr 06, 2023 at 05:37:58PM -0700, Lucas De Marchi wrote: On Fri, Mar 31, 2023 at 03:52:16PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > First release of GuC for Meteorlake. > > NB: As this is still

[PATCH v5 01/20] dt-bindings: display: tegra: add Tegra20 VIP

2023-04-07 Thread Luca Ceresoli
VIP is the parallel video capture component within the video input subsystem of Tegra20 (and other Tegra chips, apparently). Signed-off-by: Luca Ceresoli Reviewed-by: Krzysztof Kozlowski Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags - remove leftover

[PATCH v5 00/20] Add Tegra20 parallel video input capture

2023-04-07 Thread Luca Ceresoli
New in v5: dropped the patch that was removing lots of the logic behind enum_format, after discussion with Hans. The rest is unmodified except for rebasing and fixing a couple typos in comments. Full details follow. Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can receive

[PATCH v5 03/20] staging: media: tegra-video: improve documentation of tegra_video_format fields

2023-04-07 Thread Luca Ceresoli
Some fields are irrelevant for Tegra20/VIP. Add a note to clarify that. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2 --- drivers/staging/media/tegra-video/vi.h | 6 +++--- 1 file

[PATCH v5 07/20] staging: media: tegra-video: slightly simplify cleanup on errors

2023-04-07 Thread Luca Ceresoli
of_node_put(node) does nothing if node == NULL, so it can be moved to the cleanup section at the bottom. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2 ---

[PATCH v5 09/20] staging: media: tegra-video: move tegra210_csi_soc to C file

2023-04-07 Thread Luca Ceresoli
This declaration is used only in csi.c, no need to export it elsewhere. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags This patch was added in v3. --- drivers/staging/media/tegra-video/csi.c | 4

[PATCH v5 08/20] staging: media: tegra-video: move private struct declaration to C file

2023-04-07 Thread Luca Ceresoli
struct tegra_vi_graph_entity is an internal implementation detail of the VI module. Move its declaration from vi.h to vi.c. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2 ---

[PATCH v5 05/20] staging: media: tegra-video: fix typos in comment

2023-04-07 Thread Luca Ceresoli
Add "skip" in "so we can *skip* the current channel" or it doesn't make sense. Also add articles where appropriate to fix English grammar. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2

[PATCH v5 06/20] staging: media: tegra-video: improve error messages

2023-04-07 Thread Luca Ceresoli
tegra_vi_channels_alloc() can primarily fail for two reasons: 1. "ports" node not found 2. port_num > vi->soc->vi_max_channels Case 1 prints nothing, case 2 has a dev_err(). The caller [tegra_vi_init()] has a generic dev_err() on any failure. This mean that in case 2 we print two messages, and

[PATCH v5 02/20] dt-bindings: display: tegra: vi: add 'vip' property and example

2023-04-07 Thread Luca Ceresoli
The Tegra20 VI peripheral can receive parallel input from the VIP parallel input module. Add it to the allowed properties and augment the existing nvidia,tegra20-vi example to show a 'vip' property. Signed-off-by: Luca Ceresoli Reviewed-by: Rob Herring --- No changes in v5 Changed in

[PATCH v5 04/20] staging: media: tegra-video: document tegra_channel_get_remote_source_subdev

2023-04-07 Thread Luca Ceresoli
Clarify what this function does. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2 --- drivers/staging/media/tegra-video/vi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v5 10/20] staging: media: tegra-video: remove unneeded include

2023-04-07 Thread Luca Ceresoli
There is only a pointer reference to struct tegra_vi in video.h, thus vi.h is not needed. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2 --- drivers/staging/media/tegra-video/video.h | 1 -

[PATCH v5 11/20] staging: media: tegra-video: Kconfig: allow TPG only on Tegra210

2023-04-07 Thread Luca Ceresoli
We are about to add support for the Tegra20 parallel video capture, which has no TPG. In preparation for that, limit the VIDEO_TEGRA_TPG option to Tegra210 which is the only implementation currently provided by this driver. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Block waiting for GuC reset to complete

2023-04-07 Thread Rodrigo Vivi
On Wed, Apr 05, 2023 at 09:45:22PM -0700, Ashutosh Dixit wrote: > Instead of erroring out when GuC reset is in progress, block waiting for > GuC reset to complete which is a more reasonable uapi behavior. > > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/i915/i915_hwmon.c | 13

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Get mutex and rpm ref just once in hwm_power_max_write

2023-04-07 Thread Rodrigo Vivi
On Wed, Apr 05, 2023 at 09:45:20PM -0700, Ashutosh Dixit wrote: > In preparation for follow-on patches, refactor hwm_power_max_write to take > hwmon_lock and runtime pm wakeref at start of the function and release them > at the end, therefore acquiring these just once each. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-07 Thread Rodrigo Vivi
On Wed, Apr 05, 2023 at 09:45:21PM -0700, Ashutosh Dixit wrote: > On dGfx, the PL1 power limit being enabled and set to a low value results > in a low GPU operating freq. It also negates the freq raise operation which > is done before GuC firmware load. As a result GuC firmware load can time >

Re: [PATCH 0/2] drm/vkms: A couple of trivial cleanups

2023-04-07 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Hello, > > This series contains two trivial cleanups for the vkms driver. > > Patch #1 just gets rid of a wrapper helper that wasn't really adding that > much value and patch #2 drops the header > that was only used to call the drm_simple_encoder_init()

Re: [PATCH v3 01/13] firmware/sysfb: Fix EFI/VESA format selection

2023-04-07 Thread Pierre Asselin
Thomas Zimmermann wrote: > Select color format for EFI/VESA firmware scanout buffer from the > number of bits per pixel and the position of the individual color > components. Fixes the selected format for the buffer in several odd > cases. For example, XRGB1555 has been reported as ARGB1555

Re: [PATCH v3 36/65] clk: versatile: sp810: Add a determine_rate hook

2023-04-07 Thread Pawel Moll
On 04/04/2023 11:11, Maxime Ripard wrote: > The Versatile sp810 "timerclken" clock implements a mux with a > set_parent hook, but doesn't provide a determine_rate implementation. > > This is a bit odd, since set_parent() is there to, as its name implies, > change the parent of a clock.

[PATCH v5 20/20] staging: media: tegra-video: add support for Tegra20 parallel input

2023-04-07 Thread Luca Ceresoli
The VI peripheral of Tegra supports capturing from MIPI CSI-2 or parallel video (called VIP in the docs). The staging tegra-video driver currently implements MIPI CSI-2 video capture for Tegra210. Add support for parallel video capture (VIP) on Tegra20. With the generalizations added to the VI

[PATCH v5 16/20] staging: media: tegra-video: move syncpt init/free to a per-soc op

2023-04-07 Thread Luca Ceresoli
tegra_channel_host1x_syncpt_init() gets the host1x syncpts needed for the Tegra210 implementation, and tegra_channel_host1x_syncpts_free() puts them. Tegra20 needs to get and put a different syncpt. In preparation for adding Tegra20 support, move these functions to new ops in the soc-specific

[PATCH v5 17/20] staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi

2023-04-07 Thread Luca Ceresoli
In preparation to implement Tegra20 parallel video capture, add a variable to hold the required syncpt and document all the syncpt variables. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags Changed in v3: - recycle

[PATCH v5 12/20] staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op

2023-04-07 Thread Luca Ceresoli
tegra_channel_fmt_align() takes care of the size constraints, alignment and rounding requirements of the Tegra210 VI peripheral. Tegra20 has different constraints. In preparation for adding Tegra20 support, move this function to a new op in the soc-specific `struct tegra_vi_ops` . Also move to

[PATCH v5 13/20] staging: media: tegra-video: move default format to soc-specific data

2023-04-07 Thread Luca Ceresoli
The tegra_default_format in vi.c is specific to Tegra210 CSI. In preparation for adding Tegra20 VIP support, move the default format to a new field in the soc-specific `struct tegra_vi_soc`. Instead of an entire format struct, only store a pointer to an item in the existing format array. No

[PATCH v5 15/20] staging: media: tegra-video: add a per-soc enable/disable op

2023-04-07 Thread Luca Ceresoli
The Tegra20 VI needs an additional operation to enable the VI, add an operation for that. Signed-off-by: Luca Ceresoli Reviewed-by: Dmitry Osipenko --- No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2 --- drivers/staging/media/tegra-video/vi.c | 7

[PATCH v5 14/20] staging: media: tegra-video: move MIPI calibration calls from VI to CSI

2023-04-07 Thread Luca Ceresoli
The CSI module does not handle all the MIPI lane calibration procedure, leaving a small part of it to the VI module. In doing this, tegra_channel_enable_stream() (vi.c) manipulates the private data of the upstream subdev casting it to struct 'tegra_csi_channel', which will be wrong after

[PATCH v5 18/20] staging: media: tegra-video: add hooks for planar YUV and H/V flip

2023-04-07 Thread Luca Ceresoli
Tegra20 supports planar YUV422 capture, which can be implemented by writing U and V base address registers in addition to the "main" base buffer address register. It also supports H and V flip, which among others requires to write the start address (i.e. the 1st offset to write, at the end of the

[PATCH v5 19/20] staging: media: tegra-video: add H/V flip controls

2023-04-07 Thread Luca Ceresoli
Tegra20 can do horizontal and vertical image flip, but Tegra210 cannot (either the hardware, or this driver). In preparation to adding Tegra20 support, add a flag in struct tegra_vi_soc so the generic vi.c code knows whether the flip controls should be added or not. Also provide a generic

[PATCH 1/2] drm/i915: constify pointers to hwmon_channel_info

2023-04-07 Thread Krzysztof Kozlowski
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlow...@linaro.org/ Therefore I propose this should also go via

[PATCH 2/2] drm/nouveau: constify pointers to hwmon_channel_info

2023-04-07 Thread Krzysztof Kozlowski
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlow...@linaro.org/ Therefore I propose this should also go via

Re: [PATCH 01/68] hwmon: constify pointers to hwmon_channel_info

2023-04-07 Thread Guenter Roeck
On Thu, Apr 06, 2023 at 10:29:56PM +0200, Krzysztof Kozlowski wrote: > HWmon core receives an array of pointers to hwmon_channel_info and it > does not modify it, thus it can be array of const pointers for safety. > This allows drivers to make them also const. > > Signed-off-by: Krzysztof